Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-enable manteinance mode on server updates #457

Open
SamuAlfageme opened this issue Jan 25, 2018 · 0 comments
Open

Auto-enable manteinance mode on server updates #457

SamuAlfageme opened this issue Jan 25, 2018 · 0 comments
Assignees
Labels

Comments

@SamuAlfageme
Copy link

SamuAlfageme commented Jan 25, 2018

If you happen to have a desktop sync client open during the updater's operation it can easily go mad if the server doesn't advertise at any point that is going trough some special condition (such as replacing its own code).

Current Behavior:

At some point,

curl 'https://<server>/status.php' \
    -H 'Authorization:Basic ...' \
    -H 'User-Agent:Mozilla/5.0 (Macintosh) mirall/2.5.0-nightly20171030' \
    [...]'

gets replied back and forth with a 302 redirection to https://<server>/index.php and eventually goes 401:

Expected Behavior:

Receiving a 503 and properly setting the maintenance value on status.php will help the client handle this situation on a more graceful manner (see owncloud/client#5755) - This will require, keeping status.php available during upgrade.

cc/ @DeepDiver1975 opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants