-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate updater code from core in releases #409
Comments
@jvillafanez I think you had big ideas for this but can't remember where you posted them |
This was the concept of the current implementation. What is missing? |
@DeepDiver1975 I guess the point here is separate code delivering |
Added missing part "in releases". What I mean is providing a way for the updater to update itself independently from core. So if you're on OC 9.0.3 and we have an important fix to make updating work, then the updater would first update itself to the latest version and then do the core update. |
This also means that we only maintain one updater version, the latest one, instead of maintaining multiple updater versions, one for each core branch. |
@PVince81 I would offer to do it in a silent, unconditional and single-file manner. |
Well, better rewrite them again here 😄 Let's simplify the updater:
There is still the open issue of "ownCloud versions discovery". Using an "updater server" is way to complex and make testing difficult: we need to start a server, patch the server code with the something to provide the new ownCloud version, connect the updater to the patched server.... As an additional note, the updater should be able to update any ownCloud installation. If I have several ownCloud in my computer, the same updater should be able to update all of them, not all at once but the ones I want. I don't want to download one updater per ownCloud installation. I guess this sums up my opinion. |
This is where phar can be of interest- at least for cli |
There is no need to deploy the whole update server config/config.php fakeresponse.xml:
or
|
Any pastebin service can be a custom update server: |
We should consider removing the update server from this. Just provide a file in xml, json or whatever format with the whole list of versions and let the updater choose the best options for the server it wants to update. Removing the update server leads to a simpler architecture and make things easier to test from my point of view. Note that it's MANDATORY to automate this. Any change that makes the updater easier to automate should be really welcomed, because this will only get bigger and bigger. |
Provide a separate channel for only the updater code. This way there is only ever a single updater codebase that needs to update itself.
This would make it easier for testing and fixing update issues by telling people to update the updater to the latest version.
@VicDeo @DeepDiver1975 @davitol
The text was updated successfully, but these errors were encountered: