Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: New updater #204

Open
2 tasks
VicDeo opened this issue Dec 15, 2015 · 11 comments
Open
2 tasks

TODO: New updater #204

VicDeo opened this issue Dec 15, 2015 · 11 comments
Assignees

Comments

@VicDeo
Copy link
Member

VicDeo commented Dec 15, 2015

Postponed from 9.0

  • upgrade:backupData Backup data (optionally)
  • upgrade:backupDb Backup DB (optionally)

done with single occ upgrade invocation:
- [ ] upgrade:preUpgradeRepair Repair and cleanup (pre upgrade, DB collations update, ..)
- [ ] upgrade:dbUpgrade db schema upgrade
- [ ] upgrade:postUpgradeCleanup repair and cleanup step 2 (online) [danger, might take long]
- [ ] upgrade:postUpgradeRepair repair and cleanup step 1 (post upgrade, repair legacy storage, ..) [danger, might take long]
- [ ] upgrade:updateConfig update config.php

@ghost ghost added this to the 9.1-next milestone Feb 2, 2016
@karlitschek
Copy link

I think not having a db backup is ok. Maybe we should still have the step in the updater which basically says: 'and now please do amanually a db backup'
Not sure what you mean with the other steps. They are implementd in occ but will be called by the updater, right?

@VicDeo
Copy link
Member Author

VicDeo commented Feb 3, 2016

@karlitschek Right now occ upgrade performs all these steps at once.
Splitting occ upgrade into smaller pieces will be done when the application is ready

@karlitschek
Copy link

What do you mean with 'application ready'? Making this steps executable independently was one of the main goal for the new updater.

@PVince81
Copy link
Contributor

  • add more steps from the upgrade command
    • disable third party apps
    • enable new bundled/shipped apps

@PVince81
Copy link
Contributor

  • update steps for every app ? (appinfo/preupdate.php, appinfo/update.php), might need better API to be able to get feedback from app's updates

@PVince81
Copy link
Contributor

Ideas:

  • add more feedback on schema migration:
    • which SQL statements will be executed as part of the schema diff
    • count entries of each affected tables and compute a possible time estimate about how long it will take (it's fine if we say it takes a day even if it's much shorter)

@VicDeo
Copy link
Member Author

VicDeo commented Mar 30, 2016

@PVince81

Update steps for every app ?

I'd vote for step by step migrations based on doctrine/migrations (as a long-term goal)
e.g.

genericAppId/appinfo/setup/install-1.0.0.0.php
genericAppId/appinfo/setup/install-1.1.0.0.php
genericAppId/appinfo/setup/update-1.0.0.0-1.0.0.1.php
genericAppId/appinfo/setup/update-1.1.1.2-1.1.1.3.php
genericAppId/appinfo/setup/update-1.1.1.4-1.1.1.5.php
genericAppId/appinfo/setup/update-1.1.2.1-1.1.2.2.php
genericAppId/appinfo/setup/update-1.1.3.2-1.1.3.3.php
genericAppId/appinfo/setup/update-1.1.3.6-1.1.3.7.php
etc

With the following logic:

  • missing genericAppId/appinfo/setup/ dir means that legacy migration will be used
  • missing update file means 'there is nothing to change in DB/settings, just increase the version'

On install:

  • choose closest install.php to the version that is going to be installed
  • apply all update-*.php inbetween version from install.php and actual version

On update

  • apply all update-*.php inbetween current and new version

In this case there is no need to perform additional version checks in the app.

@ruddyconsult
Copy link

@VicDeo
Please advise on my situation already described to you once separately. Reminder: I tried to restore my most recent updater-backup 8.2.3.2 after an incident that took my Owncloud offline. It didn't suffice. Should I continue with older updater-backup copies, or alter the config.php file somehow?

@PVince81
Copy link
Contributor

@VicDeo please update the checkboxes

1 similar comment
@PVince81
Copy link
Contributor

@VicDeo please update the checkboxes

@PVince81
Copy link
Contributor

asked on IRC, he said "nothing to update according to #304"

@PVince81 PVince81 modified the milestones: 9.1, maybe some day May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants