Release search_elastic 2.4.0

[phil-davis]

Reasons

• Needed to go with server core 10.13 because of the Symfony 4 to 5 upgrade Update Symfony from 4.4.* to 5.4.* core#39630
• PR Always return an int from Symfony Command execute method #322 made code changes needed for Symfony 5
• Refactor connector #319
  • https://github.com/owncloud/enterprise/issues/5556
  • https://github.com/owncloud/enterprise/issues/5643

Note: the change in that PR also works fine with server core 10.12 and before, so there should be no need to bump the core min-version.

The app can be released any time before 10.13 - it should work fine with any of the recent oC10 core releases.

Full testplan needed

• [QA] 2.4.0 Testplan #328

Product approval

• Verify transifex commits (enterprise should update weekly, others daily): If folder l10n exists, then git log should show '[tx] updated from transifex` ...
• Ping ProductManagement to check info.xml description and screenshot

QA

• Create QA Milestone and set the description to $version
• Move tickets from milestone development to qa (testplan and tickets mentioned in release ticket)
• Create release branch with the format "release-$version"
• Create "$version Testplan" (QA templates or Enterprise)
• copy new/reopened issues from the previous release ticket as 'Issues to review' below.
• check if Non-normal Release Process applies, and adapt this checklist.

Documentation

• Changes in the docs needed? If so create issue in https://github.com/owncloud/docs-server/issues/new .

Marketing

• Ping @owncloud/marketing
• Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
• Request a screenshot if the app is new or changed fundamentally

Build

All actions to be done on the release branch (git pull; git checkout -b release-x.x.x) from here:

• Bump version in appinfo/info.xml (no version suffix)
• Check php version dependency and minimum ownCloud version dependency in appinfo/info.xml
• Bump "sonar.projectVersion=" in sonar-project.properties (no version suffix)
• Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

• git tag -s v${version}-rc.1 on release branch (see https://confluence.owncloud.com/display/EN/Product+Owners+List)
• Build and sign RC tarball from github tag v${version}-rc.1 (see handbook for how to build)
• Check buildlog for security reports
• Check github security tab dependabot reports
  • -> if critical or high entries are reported: open a release blocker issue.
• Upload as Github release using changelog entries
• Test and document in testplan + manual explorative testing:
  • If this is an enterprise app: Enabling the app must start the grace period
  • Add section "Changlog Testing" using github releases text or CHANGELOG.md from release branch
  • Do changelog tests
  • Do regression tests
  • Watch out for untranslated strings when locale is de oder de_DE.
  • PHP 7.3 compatibility (HCLOUD_SERVER_IMAGE=debian-10 OC10_VERSION=10.11 oc10.sh ...)
  • => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

• Check that no documentation issues are pending
• Rename last RC tarball to final
• Create github tag for final v${version} on release branch
• Upload as Github release using changelog entries

Publishing

• Upload tarball to marketplace (see handbook in confluence for details)
• Publish tarball for customers - old 10, old 10.0 and new portal (see handbook for details)
• Send mail to release-coordination with link to this ticket and to the changelog
• Copy email to rocket chat #updates channel

Post-release

• Add a new 'Unreleased' section in CHANGELOG.md (and also update links at the bottom!)
• Create PR to merge changes back to the master branch with description "Closes #XYZ" with the release ticket number
• Rename QA milestone to $version and close the milestone
• Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
• Ensure release template is up to date
• Ensure the testplan template (community or enterprise) is up to date
• Close the testplan issue

[jnweiger]

Issues seen while testing

• Hitting ENTER on the search string sometimes does not cause a search query #287 (old issue, still relevant)
• [QA] RelevanceV2 finds 'dollar' where the word does not occur #329
• [QA] misleading plural s in the name of new config variable connectors_search #330
• [QA] too many matches for fluxcompensator #331

new issues seen with RC.1

• Boolean OR sometimes matches literal *or* e.g. in 'order' #335
• Search with doublequotes also matches unrelated filenames #336
• search results are invisible, when PDF viewer is open core#41058

[jnweiger]

We have RC1:

• https://github.com/owncloud/search_elastic/releases/download/v2.4.0-rc.1/search_elastic-2.4.0-rc.1.tar.gz

[jnweiger]

Changelog QA passed. the critical tokenizer error #331 is fixed. Some more errors around #287 exist, new issues opened. Not considered blockers.

[phil-davis]

https://github.com/owncloud/search_elastic/releases/tag/v2.4.0
was released 2 Nov 2023