Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and fix OC storage driver issues like rename, etc #164

Open
9 of 14 tasks
exalate-issue-sync bot opened this issue Aug 19, 2020 · 3 comments
Open
9 of 14 tasks

Check and fix OC storage driver issues like rename, etc #164

exalate-issue-sync bot opened this issue Aug 19, 2020 · 3 comments

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Aug 19, 2020

We need to make sure that the id to path lookup is kept up to date on

  • AddGrant, uses fs.propagate(ctx, np)
  • RemoveGrant, PR in [owncloud] propagate mtime on RemoveGrant cs3org/reva#1115
  • UpdateGrant, calls AddGrant
  • CreateHome not necessary
  • CreateDir, uses fs.propagate(ctx, np)
  • CreateReference only in the share folder
  • SetArbitraryMetadata, uses fs.propagate(ctx, np)
  • UnsetArbitraryMetadata, uses fs.propagate(ctx, np)
  • Delete, calls trash(), which uses fs.propagate(ctx, path.Dir(np))
  • Move, uses fs.propagate(ctx, newName) and fs.propagate(ctx, path.Dir(oldName))
  • RestoreRevision, uses fs.propagate(ctx, np)
  • PurgeRecycleItem not necessary
  • EmptyRecycle not necessary
  • RestoreRecycleItem, uses fs.propagate(ctx, tgt)

Note that the owncloud storage driver does not support changing the storage on disk. It does not pick up changes on disk, which happen when the testsuite wipes a users home. The id mapping in redis needs to be wiped as well.

@exalate-issue-sync exalate-issue-sync bot added Exalated This issue is under sync OCIS-Sprint-17 p3-medium story User Story labels Aug 19, 2020
@exalate-issue-sync
Copy link
Author

Remote key is https://jira.owncloud.com/browse/OCIS-377

@exalate-issue-sync exalate-issue-sync bot removed the Exalated This issue is under sync label Aug 21, 2020
@exalate-issue-sync
Copy link
Author

Vincent Petry commented: cs3org/reva#1115 was merged, let's update ocis-reva

@exalate-issue-sync
Copy link
Author

Vincent Petry commented: ocis-reva was updated on ocis master, I think we can close this ticket ? [~jfd]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants