Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display collaborators type #4203

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Display collaborators type #4203

merged 4 commits into from
Nov 1, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Oct 18, 2020

Description

We've added a new line into the collaborators autocomplete and list in the sidebar to display their type.

Related Issue

Screenshots (if appropriate):

image
image

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Oct 18, 2020
@LukasHirt LukasHirt requested a review from kulmann October 18, 2020 17:35
@LukasHirt LukasHirt self-assigned this Oct 18, 2020
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the screenshot in your PR description, I would very much like to have consistency in the way how the email address is displayed in the autocomplete list item and the list of people you shared with. I.e. autocomplete list item should have the meta-style (grayed out) email address behind the username.

@LukasHirt
Copy link
Collaborator Author

Looking at the screenshot in your PR description, I would very much like to have consistency in the way how the email address is displayed in the autocomplete list item and the list of people you shared with. I.e. autocomplete list item should have the meta-style (grayed out) email address behind the username.

Sorry, was a wrong screenshot 🤦 Updated

@kulmann
Copy link
Member

kulmann commented Oct 20, 2020

Thanks :-) Is it a quick win to also fix the width of the autocomplete list item?

@micbar
Copy link
Contributor

micbar commented Oct 29, 2020

@LukasHirt Can we move this forward? WIP limit ;-)

@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Oct 29, 2020

Can we move this forward? WIP limit ;-)

@micbar Sure, will take care of it tomorrow 😉

@LukasHirt LukasHirt force-pushed the collaborators-autocomplete branch from 08bb70b to befd557 Compare October 30, 2020 13:44
@LukasHirt
Copy link
Collaborator Author

@kulmann Width of autocomplete fixed and adjusted a selector in the tests so they should pass now.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LukasHirt LukasHirt merged commit bf4a1d7 into master Nov 1, 2020
@LukasHirt LukasHirt deleted the collaborators-autocomplete branch November 1, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show username of users when sharing
3 participants