Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play videos in media viewer #3803

Merged
merged 6 commits into from
Jul 27, 2020
Merged

Play videos in media viewer #3803

merged 6 commits into from
Jul 27, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jul 21, 2020 •
edited
Loading

Description

Enable previewing videos in media viewer. This is POC. There are still missing features which need to be implemented.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Open tasks:

  • Open issues to re-new the signed URL after it expires
  • Open issues to clean up the code a bit
  • Open issues to create a better UI

@LukasHirt LukasHirt self-assigned this Jul 21, 2020
@LukasHirt
Copy link
Collaborator Author

I wonder if there's a nice way to preserve caching of the files.

https://github.com/owncloud/phoenix/blob/08082606d99ac2f01266c92435b193d3141fba6d/apps/media-viewer/src/Mediaviewer.vue#L223

Setting some timer to check if the timeout expired and refresh the cache seems really ugly.

@individual-it individual-it mentioned this pull request Jul 22, 2020
Closed
2 tasks
@individual-it
Copy link
Member

issue for creating UI tests #3807

@LukasHirt LukasHirt mentioned this pull request Jul 24, 2020
Closed
5 tasks
@LukasHirt LukasHirt marked this pull request as ready for review July 24, 2020 09:28
@LukasHirt LukasHirt requested a review from kulmann July 24, 2020 09:28
@LukasHirt LukasHirt mentioned this pull request Jul 24, 2020
Closed
@LukasHirt LukasHirt force-pushed the feature/media-viewer-videos branch from 1fbea83 to f1e1d23 Compare July 27, 2020 07:25
@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jul 27, 2020
@butonic
Copy link
Member

butonic commented Jul 27, 2020

playback of mp4 works!

@butonic butonic self-requested a review July 27, 2020 14:22
butonic
butonic approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@butonic butonic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with 400MB mp4

  • playback in browser works (uses signed url)
  • playback in vlc works (by copying the signed URL) ;-)

@butonic butonic merged commit 1d3b6c8 into master Jul 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/media-viewer-videos branch July 27, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasHirt @individual-it @butonic