Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deploy as an app fragments and refactored release makefile #3162

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Removed deploy as an app fragments and refactored release makefile #3162

merged 1 commit into from
Mar 9, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Mar 7, 2020 •
edited
Loading

Related Issue

Motivation and Context

Clean code

How Has This Been Tested?

  • test environment: Manually
  • test case 1: Build release

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer Type:Technical-Debt labels Mar 7, 2020
@LukasHirt LukasHirt self-assigned this Mar 7, 2020
@update-docs
Copy link

update-docs bot commented Mar 7, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt force-pushed the tech-debt/remove-oc-app-fragments branch from b5384ad to a47db4b Compare March 7, 2020 13:31
@LukasHirt LukasHirt marked this pull request as ready for review March 7, 2020 13:39
@LukasHirt LukasHirt requested a review from DeepDiver1975 as a code owner March 7, 2020 13:39
@LukasHirt LukasHirt requested a review from PVince81 March 7, 2020 13:39
@DeepDiver1975 DeepDiver1975 merged commit c8c77d4 into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the tech-debt/remove-oc-app-fragments branch March 9, 2020 15:06
@DeepDiver1975
Copy link
Member

FYI: phoenix app has been unpublished from marketplace

@LukasHirt LukasHirt mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer Type:Technical-Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove fragments of deployment as app approach
2 participants
@LukasHirt @DeepDiver1975