Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save password history only if feature is enabled #256

Open
lefherz opened this issue Sep 8, 2019 · 1 comment
Open

Save password history only if feature is enabled #256

lefherz opened this issue Sep 8, 2019 · 1 comment

Comments

@lefherz
Copy link

lefherz commented Sep 8, 2019

Currently the password history is also saved if the "password history" seting is disabled. This means a lot of old passwords are saved in the database, without an advantage (as new passwords aren't checked against them anyway).

In case the database is leaked to an attacker, they gain the hashes of a lot more old passwords. This puts users in danger, who e.g. changed their old passwords to new policy-compliant passwords because of our app, but still use their old insecure passwords on other platforms. If an attacker cracks the hash, the attacker can then retry these passwords with their other accounts.

With the small improvement of not storing old passwords or even dropping the table if the setting is disabled, less old passwords could be leaked.

@PVince81
Copy link
Contributor

PVince81 commented Sep 9, 2019

@micbar @IljaN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants