Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Improve accessibility of ocAutocomplete #557

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

marcus-herrmann
Copy link
Contributor

Context: owncloud/web#2593

Autocomplete pattern based on WAI-ARIA authoring practices 1.1

Please note: after selection of a suggestion, the selected value will now be filled into the input part of the autocomplete. This behaviour can bis disabled by setting fillOnSelection="false". Be aware that when doing so the component will be much less accessible, and the information about a successful selection must be communicated to screen readers, for example with help of a live region (<oc-hidden-announcer>)

Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@PVince81 PVince81 merged commit c8c9eab into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/a11y-documentation/autocomplete branch December 17, 2019 12:50
tboerger pushed a commit that referenced this pull request Dec 17, 2019
Merge: 2216bab cf5e980
Author: Vincent Petry <[email protected]>
Date:   Tue Dec 17 13:50:02 2019 +0100

    Merge pull request #557 from owncloud/feature/a11y-documentation/autocomplete

    Improve accessibility of ocAutocomplete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants