Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use built-in session functions of the OpenID Connect Library" #97

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 3, 2020

Reverts #96

This is the wrong approach. ownclouds strict same site cookie (php7.3+) is causing this

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #97   +/-   ##
=========================================
  Coverage     93.65%   93.65%           
  Complexity      113      113           
=========================================
  Files            10       10           
  Lines           394      394           
=========================================
  Hits            369      369           
  Misses           25       25           
Impacted Files Coverage Δ Complexity Δ
lib/Client.php 100.00% <ø> (ø) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b131e5b...269d1c9. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 6bb7b34 into master Sep 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert-96-bugfix/dont-reuse-oc-sessoin-for-oidc-client-state branch September 3, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant