Add configurable post_logout_redirect_uri #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
============================================
+ Coverage 91.32% 93.65% +2.32%
Complexity 113 113
============================================
Files 10 10
Lines 392 394 +2
============================================
+ Hits 358 369 +11
+ Misses 34 25 -9
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Jul 28, 2020
| @@ -145,7 +145,9 @@ public function afterLogout($accessToken, $idToken): void { | |||
| $this->session->remove('oca.openid-connect.refresh-token'); | |||
| $this->session->remove('oca.openid-connect.id-token'); | |||
| $this->logger->debug('OIDC Logout: ending session ' . $accessToken . ' id: ' . $idToken); | |||
| $this->client->signOut($idToken, null); | |||
| $openIdConfig = $this->client->getOpenIdConfig(); | |||
| $redirectUri = $openIdConfig['post_logout_redirect_uri'] ?? null; | |||
There was a problem hiding this comment.
isset ? the key might be completly missing - right?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add postlogout redirect URI
Types of changes
Checklist:
Open tasks: