openidconnect 2.2.0

[jnweiger]

Reason

• PR feat: account info auto-update #222 fixes Update user information during logging in #187
• PR chore: composer require jumbojett/openid-connect-php 0.9.8 #247 fixes openidconnect 2.2.0 and Duo SSO/code_challenge_methods_supported #246
• Send to auth module so the login type is recognized in core #272

Product approval

• Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
• Ping pmaier to check info.xml description and screenshot
• Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick

QA

• Create QA Milestone and set the description to $version
• Move tickets from milestone development to qa (testplan and tickets mentioned in release ticket)
• Create release branch with the format "release-$version"
• Create "2.2.0 Testplan" --> [QA] 2.2.0 Testplan #240 (QA templates or Enterprise)
• copy new/reopened issues from the previous release ticket as 'Issues to review' below.
• check if Non-normal Release Process applies, and adapt this checklist.

Documentation

• Changes in the docs needed? If so create issue in owncloud/docs-server.

Marketing

• Ping @owncloud/marketing
• Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
• Request a screenshot if the app is new or changed fundamentally

Build

All actions to be done on the release branch from here:

• Bump version in info.xml (no version suffix)
• Bump "sonar.projectVersion=" in sonar-project.properties (no version suffix)
• Check php version dependency in info.xml
• Check minimum ownCloud version dependency in info.xml
• Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

• Ping product owner to create github tag for v${version}-rc1 on release branch (see https://confluence.owncloud.com/display/EN/Product+Owners+List)
• Build and sign RC tarball from github tag v${version}-rc1 (see handbook for how to build)
• Upload as Github release using changelog entries
• Test and document in testplan + manual explorative testing:
  • If this is an enterprise app: Enabling the app must start the grace period
  • Add section "Changlog Testing" using github releases text or CHANGELOG.md from release branch
  • Do changelog tests
  • Do regression tests
  • => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

• Check that no documentation issues are pending
• Rename last RC tarball to final
• Create github tag for final v${version} on release branch
• Upload as Github release using changelog entries

Publishing

• Upload tarball to marketplace (see handbook in confluence for details)
• Publish tarball for customers - old 10, old 10.0 and new portal (see handbook for details)
• Send mail to release-coordination with link to this ticket and to the changelog
• Copy email to rocket chat #updates channel

Post-release

• Add a new 'Unreleased' section in CHANGELOG.md (and also update links at the bottom!)
• Create PR to merge changes back to the master branch with description "Closes #XYZ" with the release ticket number
• Rename QA milestone to $version and close the milestone
• Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
• Ensure release template is up to date
• Ensure the testplan template (community or enterprise) is up to date
• Close the testplan issue

[DeepDiver1975]

Please make sure to create the release branch from the correct commit. I merged a bunch of prs which are not for this release.

Thx

[DeepDiver1975]

Actually this commit should be fine
94fcbc3

[jnweiger]

Please make sure to create the release branch from the correct commit. I merged a bunch of prs which are not for this release.

Thx

Between 94fcbc3
and head of master, there are only library bumps and compose updates. Nothing worth avoiding. I am puzzled.

From my POV, we can also have #243 in this release.

[DeepDiver1975]

regression reported: #246

[DeepDiver1975]

needs to be incorporated into the next rc #247 @jnweiger

[jnweiger]

Included in https://github.com/owncloud/openidconnect/releases/tag/v2.2.0-rc.2 - Thanks!

[jnweiger]

Issues seen while Testing

• [QA] Configured attribute preferred_username is not known #248
• [QA] desktop client does not start oidc flow #251
• [QA] admin cannot login, when basic_auth_guest_only is true #261
• [QA] admin or guest user cannot connect a desktop or mobile client client#10160
• [QA] autoprovisioning from keycloak causes internal server error during very first login when ther eis no picture #273
• [QA] post logout redirect does not work with keycloak #276
• [QA] 'mode' parameter unclear, does not work as documented #277
• [QA] user information not always updated when update enabled = true #278
• [QA] desktop client opens a new browser tab every 5 minutes when connected via IDP client#10372
• [QA] no logout from identity provider possible android#3872
• [QA] openidconnect token refresh is not automatic android#3873
• [QA] sync root folder is constructed from user's full name without escaping special characters client#10427
• [QA] instance.sh has high potential of data loss when upgrading docs-server#807
• [QA] instance.sh forgets to chown everything docs-server#808
• [QA] instance.sh suggests to run occ upgrade while still in maintenance mode docs-server#809

[DeepDiver1975]

include #254

[phil-davis]

Note: PR #222 added a parameter autoProvisioningService to the constructor of LoginFlowController

https://github.com/owncloud/openidconnect/blob/master/lib/Controller/LoginFlowController.php#L84

That class is used/extended in https://github.com/owncloud/msteamsbridge and so the code in that app needed a matching change. See issue https://github.com/owncloud/msteamsbridge/issues/37 which is fixed in PR https://github.com/owncloud/msteamsbridge/pull/36

I think that https://github.com/owncloud/msteamsbridge will need to be released "in sync" with https://github.com/owncloud/openidconnect (or some further code changes made somewhere that auto-detect what parameters to pass to the constructor or...)

[jnweiger]

https://github.com/owncloud/openidconnect/releases/tag/v2.2.0-rc.7

[jnweiger]

QA passed with several minor defects, see above.

Cannot find code for #261 -- probably not yet implemented?