Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit OpenID Connect logins to users of specific user backend #100

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 15, 2020

Description

This adds a config option to limit users which are logged in via OpenID Connect to specific user backends - e.g. LDAP

Config.php:

<?php
$CONFIG = [
	'openid-connect' => [
		'allowed-user-backends' => ['LDAP']

Motivation and Context

In more security aware environments this can be of interest ..... 🙈

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot from 2020-09-15 13-11-20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 self-assigned this Sep 15, 2020
@DeepDiver1975 DeepDiver1975 force-pushed the feature/limit-user-backend branch from 689b24e to 50808df Compare September 15, 2020 11:22
@pmaier1 pmaier1 mentioned this pull request Sep 15, 2020
42 tasks
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #100 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     93.65%   93.81%   +0.15%     
- Complexity      114      117       +3     
============================================
  Files            10       10              
  Lines           394      404      +10     
============================================
+ Hits            369      379      +10     
  Misses           25       25              
Impacted Files Coverage Δ Complexity Δ
lib/Service/UserLookupService.php 100.00% <100.00%> (ø) 12.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94cb3f2...50808df. Read the comment docs.

@jnweiger
Copy link
Contributor

The release is back in dev due to this.

@mmattel
Copy link
Contributor

mmattel commented Sep 15, 2020

This is docs relevant because it contains (as far I can see) a new config option !
Please file a docs issue so it can be tracked. In case of merging a PR.

@DeepDiver1975
Copy link
Member Author

@mrkwenzel #101 - issue opened ....

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 DeepDiver1975 merged commit da7bb22 into master Sep 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/limit-user-backend branch September 15, 2020 12:53
jnweiger added a commit that referenced this pull request Sep 16, 2020
phil-davis pushed a commit that referenced this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants