From 66b638908be109b184cd918b3d0b42ef9fb93b37 Mon Sep 17 00:00:00 2001 From: amrita Date: Fri, 3 Feb 2023 12:19:17 +0545 Subject: [PATCH] Refactor share permission related scenario --- .../multilinkSharing.feature | 6 +- .../reShareAsPublicLinkToRoot.feature | 181 ------------------ .../reShareAsPublicLinkToSharesNewDav.feature | 8 +- .../reShareAsPublicLinkToSharesOldDav.feature | 117 ----------- 4 files changed, 6 insertions(+), 306 deletions(-) delete mode 100644 tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToRoot.feature delete mode 100644 tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesOldDav.feature diff --git a/tests/acceptance/features/coreApiSharePublicLink2/multilinkSharing.feature b/tests/acceptance/features/coreApiSharePublicLink2/multilinkSharing.feature index 1fb94635f37..6c32c876574 100644 --- a/tests/acceptance/features/coreApiSharePublicLink2/multilinkSharing.feature +++ b/tests/acceptance/features/coreApiSharePublicLink2/multilinkSharing.feature @@ -137,7 +137,7 @@ Feature: multilinksharing | old | | new | - @personalSpace @skipOnOcV10 + @personalSpace Examples: | dav-path | | spaces | @@ -204,7 +204,7 @@ Feature: multilinksharing | old | | new | - @personalSpace @skipOnOcV10 + @personalSpace Examples: | dav-path | | spaces | @@ -239,7 +239,7 @@ Feature: multilinksharing | old | | new | - @personalSpace @skipOnOcV10 + @personalSpace Examples: | dav-path | | spaces | diff --git a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToRoot.feature b/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToRoot.feature deleted file mode 100644 index 6af5feb6b95..00000000000 --- a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToRoot.feature +++ /dev/null @@ -1,181 +0,0 @@ -@api @files_sharing-app-required @public_link_share-feature-required @notToImplementOnOCIS -Feature: reshare as public link - As a user - I want to create public link shares from files/folders shared with me - So that I can give controlled access to others - - Background: - Given these users have been created with default attributes and without skeleton files: - | username | - | Alice | - | Brian | - - - Scenario Outline: creating a public link from a share with read permission only is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "read" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test | - | publicUpload | false | - Then the OCS status code should be "404" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | - - - Scenario Outline: creating a public link from a share with share+read only permissions is allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test | - | publicUpload | false | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the old public WebDAV API without password and the content should be "some content" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the new public WebDAV API without password and the content should be "some content" - But uploading a file should not work using the old public WebDAV API - But uploading a file should not work using the new public WebDAV API - - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - Scenario Outline: creating an upload public link from a share with share+read only permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test | - | permissions | read,update,create,delete | - | publicUpload | true | - Then the OCS status code should be "404" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | - - - Scenario Outline: creating a public link from a share with read+write permissions only is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "change" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test | - | publicUpload | true | - Then the OCS status code should be "404" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | - - - Scenario Outline: creating a public link from a share with share+read+write permissions is allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test | - | publicUpload | false | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the old public WebDAV API without password and the content should be "some content" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the new public WebDAV API without password and the content should be "some content" - But uploading a file should not work using the old public WebDAV API - But uploading a file should not work using the new public WebDAV API - - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - Scenario Outline: creating an upload public link from a share with share+read+write permissions is allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test | - | permissions | read,update,create,delete | - | publicUpload | true | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the old public WebDAV API without password and the content should be "some content" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the new public WebDAV API without password and the content should be "some content" - And uploading a file should work using the old public WebDAV API - And uploading a file should work using the new public WebDAV API - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - - Scenario Outline: creating an upload public link from a sub-folder of a share with share+read only permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has created folder "/test/sub" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - When user "Brian" creates a public link share using the sharing API with settings - | path | /test/sub | - | permissions | read,update,create,delete | - | publicUpload | true | - Then the OCS status code should be "404" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | - - - Scenario Outline: increasing permissions of a public link of a share with share+read only permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has created folder "/test/sub" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has created a public link share with settings - | path | /test | - | permissions | read | - | publicUpload | false | - When user "Brian" updates the last public link share using the sharing API with - | permissions | read,update,create,delete | - Then the OCS status code should be "404" - And the HTTP status code should be "" - And uploading a file should not work using the old public WebDAV API - And uploading a file should not work using the new public WebDAV API - - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | - - - Scenario Outline: increasing permissions of a public link from a sub-folder of a share with share+read only permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has created folder "/test/sub" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has created a public link share with settings - | path | /test/sub | - | permissions | read | - | publicUpload | false | - And uploading a file should not work using the old public WebDAV API - And uploading a file should not work using the new public WebDAV API - When user "Brian" updates the last public link share using the sharing API with - | permissions | read,update,create,delete | - Then the OCS status code should be "404" - And the HTTP status code should be "" - And uploading a file should not work using the old public WebDAV API - And uploading a file should not work using the new public WebDAV API - - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | diff --git a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature b/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature index 135a24ce1bb..a0857b21a33 100644 --- a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature +++ b/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature @@ -6,11 +6,9 @@ Feature: reshare as public link Background: Given these users have been created with default attributes and without skeleton files: - | username | - | Alice | - | Brian | - And the administrator has set the default folder for received shares to "Shares" - And auto-accept shares has been disabled + | username | + | Alice | + | Brian | Scenario Outline: creating a public link from a share with read permission only is not allowed diff --git a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesOldDav.feature b/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesOldDav.feature deleted file mode 100644 index 7b478454fb1..00000000000 --- a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesOldDav.feature +++ /dev/null @@ -1,117 +0,0 @@ -@api @files_sharing-app-required @public_link_share-feature-required @notToImplementOnOCIS @issue-ocis-2079 -Feature: reshare as public link - As a user - I want to create public link shares from files/folders shared with me - So that I can give controlled access to others - - Background: - Given these users have been created with default attributes and without skeleton files: - | username | - | Alice | - | Brian | - And the administrator has set the default folder for received shares to "Shares" - And auto-accept shares has been disabled - - - Scenario Outline: creating a public link from a share with share+read only permissions is allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has accepted share "/test" offered by user "Alice" - When user "Brian" creates a public link share using the sharing API with settings - | path | /Shares/test | - | publicUpload | false | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the old public WebDAV API - And the downloaded content should be "some content" - But uploading a file should not work using the old public WebDAV API - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - - Scenario Outline: creating a public link from a share with share+read+write permissions is allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - And user "Brian" has accepted share "/test" offered by user "Alice" - When user "Brian" creates a public link share using the sharing API with settings - | path | /Shares/test | - | publicUpload | false | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the old public WebDAV API - And the downloaded content should be "some content" - But uploading a file should not work using the old public WebDAV API - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - - Scenario Outline: creating an upload public link from a share with share+read+write permissions is allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - And user "Brian" has accepted share "/test" offered by user "Alice" - When user "Brian" creates a public link share using the sharing API with settings - | path | /Shares/test | - | permissions | read,update,create,delete | - | publicUpload | true | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And the public should be able to download file "file.txt" from inside the last public link shared folder using the old public WebDAV API - And the downloaded content should be "some content" - And uploading a file should work using the old public WebDAV API - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - - Scenario Outline: increasing permissions of a public link of a share with share+read only permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has created folder "/test/sub" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has accepted share "/test" offered by user "Alice" - And user "Brian" has created a public link share with settings - | path | /Shares/test | - | permissions | read | - | publicUpload | false | - When user "Brian" updates the last public link share using the sharing API with - | permissions | read,update,create,delete | - Then the OCS status code should be "404" - And the HTTP status code should be "" - And uploading a file should not work using the old public WebDAV API - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 | - - - Scenario Outline: increasing permissions of a public link from a sub-folder of a share with share+read only permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has created folder "/test/sub" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has accepted share "/test" offered by user "Alice" - And user "Brian" has created a public link share with settings - | path | /Shares/test/sub | - | permissions | read | - | publicUpload | false | - And uploading a file should not work using the old public WebDAV API - When user "Brian" updates the last public link share using the sharing API with - | permissions | read,update,create,delete | - Then the OCS status code should be "404" - And the HTTP status code should be "" - And uploading a file should not work using the old public WebDAV API - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 404 |