From f5df71717c35340fe87061c8c2fa6074d48d767b Mon Sep 17 00:00:00 2001 From: pwengerter Date: Thu, 16 Sep 2021 11:34:17 +0100 Subject: [PATCH] Remove placeholder notifications endpoint in capabilities --- changelog/unreleased/remove-notifications-placeholder.md | 7 +++++++ storage/pkg/command/frontend.go | 3 --- 2 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 changelog/unreleased/remove-notifications-placeholder.md diff --git a/changelog/unreleased/remove-notifications-placeholder.md b/changelog/unreleased/remove-notifications-placeholder.md new file mode 100644 index 00000000000..b163f7c7c13 --- /dev/null +++ b/changelog/unreleased/remove-notifications-placeholder.md @@ -0,0 +1,7 @@ +Bugfix: Remove notifications placeholder + +Since Reva was communicating its notification capabilities incorrectly, oCIS relied on a hardcoding string to overwrite them. +This has been fixed in [reva#1819](https://github.com/cs3org/reva/pull/1819) so we now removed the hardcoded string +and don't modify Reva's notification capabilities anymore in order to fix clients having to poll a (non-existent) notifications endpoint. + +https://github.com/owncloud/ocis/pull/2514 diff --git a/storage/pkg/command/frontend.go b/storage/pkg/command/frontend.go index ef686698b8f..2735b68767f 100644 --- a/storage/pkg/command/frontend.go +++ b/storage/pkg/command/frontend.go @@ -250,9 +250,6 @@ func frontendConfigFromStruct(c *cli.Context, cfg *config.Config, filesCfg map[s "incoming": true, }, }, - "notifications": map[string]interface{}{ - "endpoints": []string{"disable"}, - }, }, "version": map[string]interface{}{ "edition": "reva",