Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] API test for REPORT request to webdav endpoint #9991

Closed
3 tasks
PrajwolAmatya opened this issue Sep 6, 2024 · 3 comments
Closed
3 tasks

[QA] API test for REPORT request to webdav endpoint #9991

PrajwolAmatya opened this issue Sep 6, 2024 · 3 comments
Assignees
Labels

Comments

@PrajwolAmatya
Copy link
Contributor

PrajwolAmatya commented Sep 6, 2024

Description

It seems there might not be full test coverage for REPORT request for endpoint /remote.php/dav/spaces/ with and without spaceUUID,

  • -XREPORT https://localhost:9200/dav/spaces/
  • -XREPORT https://localhost:9200/dav/spaces/spaceUUID

Both seems to behave the same way.

TODO:

  • Check for the related test coverages
  • Add test coverages for these endpoint
  • Check with and without remote.php in dav-path

Related bug reports:

@prashant-gurung899
Copy link
Contributor

@saw-jan @PrajwolAmatya

With remote.php

As per my research in OCIS-tests, i have found that tests cases for endpoints with remote.php are covered for all dav-paths in tests/acceptance/features/apiSearch1/search.feature:
- old : https://localhost:9200/remote.php/webdav
- new : https://localhost:9200/remote.php/dav/files/admin
- spaces: https://localhost:9200/remote.php/dav/spaces/{space-id}

I haven't found test coverage for endpoint without {space-id} i.e https://localhost:9200/remote.php/dav/spaces

Without remote.php

For the following endpoints without remote.php :
- old : https://localhost:9200/webdav
- new : https://localhost:9200/dav/files/admin
- spaces: https://localhost:9200/dav/spaces & https://localhost:9200/dav/spaces/{space-id}

I think it should be discussed on how to optimally implement these cases

@saw-jan
Copy link
Member

saw-jan commented Sep 18, 2024

  • Check for the related test coverages
  • Add test coverages for these endpoint

Tests now use these paths for REPORT request: (#10044)
https://localhost:9200/remote.php/webdav
https://localhost:9200/remote.php/dav/files
https://localhost:9200/remote.php/dav/spaces

And as per #7104 (comment), we really don't need to test with space-id in the request path.

  • Check with and without remote.php in dav-path

This will be done in another PR with different implementation.

And I want to move bug reports coverage in ticket #9948

So maybe we can close this one?
CC @prashant-gurung899 @amrita-shrestha @Salipa-Gurung @PrajwolAmatya

@saw-jan
Copy link
Member

saw-jan commented Sep 20, 2024

I am closing this here.

@saw-jan saw-jan closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants