Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA][API test] organize the test folders within the acceptance directory #9872

Closed
2 tasks done
saw-jan opened this issue Aug 21, 2024 · 4 comments · Fixed by #9924
Closed
2 tasks done

[QA][API test] organize the test folders within the acceptance directory #9872

saw-jan opened this issue Aug 21, 2024 · 4 comments · Fixed by #9924
Assignees
Labels

Comments

@saw-jan
Copy link
Member

saw-jan commented Aug 21, 2024

In order to better scope and organize the files and folders related to API tests, here is a proposed acceptance directory structure.

Current:

📁tests
|--📁acceptance
|  |--📁features
|  |  |--📁apiSuiteX
|  |  |--📁bootstrap
|--📁TestHelpers

Proposed:

📁tests
|--📁acceptance
|  |--📁features
|  |  |--📁apiSuiteX
|  |--📁bootstrap
|  |--📁TestHelpers
  • bootstrap moved out of the features dir (features only contains the test suites - feature files)
  • TestHelpers moved into acceptance dir (because those helpers are only for API acceptance tests)
@saw-jan
Copy link
Member Author

saw-jan commented Aug 21, 2024

CC @ScharfViktor @phil-davis

@ScharfViktor
Copy link
Contributor

I agree 👍
One suggestion: maybe we can join make test-acceptance-from-core-api to make test-acceptance-api?
but keep the old set naming (prefixes with core) to use only one command to run tests:

TEST_SERVER_URL="https://localhost:9200" \ BEHAT_FEATURE="tests/acceptance/features/coreApiWebdavOperations/downloadFile.feature:242" \ 
make test-acceptance-api
TEST_SERVER_URL="https://localhost:9200" \ 
BEHAT_FEATURE="tests/acceptance/features/apiGraph/activities.feature" \ 
make test-acceptance-api

@phil-davis
Copy link
Contributor

I agree with the acceptance test folder restructuring.

I will let @saw-jan and @ScharfViktor decide what make command targets should do what things.

@saw-jan
Copy link
Member Author

saw-jan commented Aug 21, 2024

One suggestion: maybe we can join make test-acceptance-from-core-api to make test-acceptance-api?
but keep the old set naming (prefixes with core) to use only one command to run tests:

currently, we have two different behat configs for them. But it looks doable. 👍
I will add to the list or create another ticket for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants