Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy file from shares shared by secure view role to personal space results in 500 status code error. #9482

Closed
S-Panta opened this issue Jun 27, 2024 · 8 comments · Fixed by #9677
Assignees
Labels

Comments

@S-Panta
Copy link
Contributor

S-Panta commented Jun 27, 2024

Describe the bug

Copying files from shared shares via the secure view role results in a 500 status code.

Steps to reproduce

  1. Create a new user test
  2. Share the folder folder1 from Admin via Secure Role to test.
  3. Sharee tries to copy share to personal space
curl -vk --location --request COPY 'https://host.docker.internal:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/folder1' --header 'Destination: https://host.docker.internal:9200/remote.php/dav/spaces/6fac54b6-feef-4157-abc5-02f79550dcff%24a7322a1c-b091-4ec4-8687-c9358f4bf196/folder1' -utest:test

Expected behavior

What should be the expected status code for the process? This only happens in secure view. File copying is possible while sharing with other permission role

Actual behavior

The server returns 500 status code

Setup

OCIS_XXX=Infinite Scale 6.0.0+5f03a566ee Community
OCIS_YYY=somevalue
PROXY_XXX=somevalue

@S-Panta
Copy link
Contributor Author

S-Panta commented Jun 27, 2024

Also, here lies the summary of status code of various copying process that happens when shared resources via Secure viewer role.
#9334 (comment)

@micbar
Copy link
Contributor

micbar commented Jun 27, 2024

Should be 403

@butonic @kobergj If you agree.

@phil-davis
Copy link
Contributor

@saw-jan @Salipa-Gurung can someone please make a test scenario for this in ocis, and check that it will pass with reva PR cs3org/reva#4775

@saw-jan
Copy link
Member

saw-jan commented Jul 24, 2024

@saw-jan @Salipa-Gurung can someone please make a test scenario for this in ocis, and check that it will pass with reva PR cs3org/reva#4775

we do have PR #9437 for the test scenario. now have to test it with the respective fix PRs.

@S-Panta
Copy link
Contributor Author

S-Panta commented Jul 26, 2024

The issue is fixed in the spaces path but with old and new dav , the status code is still 500
Reference: https://drone.owncloud.com/owncloud/ocis/37540/52/5
@2403905

@S-Panta S-Panta reopened this Jul 26, 2024
@saw-jan
Copy link
Member

saw-jan commented Jul 26, 2024

Curl examples:

# new dav path
curl -XCOPY "https://localhost:9200/dav/files/demo/Shares/shareme" \
-H"Destination: https://localhost:9200/dav/files/demo/shareme" \
-udemo:demo -vk

# old dav path
curl -XCOPY "https://localhost:9200/webdav/Shares/shareme" \        
-H"Destination: https://localhost:9200/webdav/shareme" \        
-udemo:demo -vk
  1. 500 for old/new dav paths ❌
< HTTP/1.1 500 Internal Server Error
  1. If the shared file or folder (if empty or contains zero-byte files) then COPY works and file/folder is created ❓
    Same for all dav paths: old, new and spaces

@prashant-gurung899
Copy link
Contributor

prashant-gurung899 commented Aug 6, 2024

Curl examples:

# new dav path
curl -XCOPY "https://localhost:9200/dav/files/demo/Shares/shareme" \
-H"Destination: https://localhost:9200/dav/files/demo/shareme" \
-udemo:demo -vk

# old dav path
curl -XCOPY "https://localhost:9200/webdav/Shares/shareme" \        
-H"Destination: https://localhost:9200/webdav/shareme" \        
-udemo:demo -vk
  1. 500 for old/new dav paths ❌
< HTTP/1.1 500 Internal Server Error
  1. If the shared file or folder (if empty or contains zero-byte files) then COPY works and file/folder is created ❓
    Same for all dav paths: old, new and spaces

@saw-jan The status code response for both the old/new dav paths is giving '403':

< HTTP/1.1 403 Forbidden

image

@saw-jan
Copy link
Member

saw-jan commented Aug 6, 2024

Then this can be closed here. THanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants