[Sharing NG] Add tests coverage for (enable sync/disable sync) share

[amrita-shrestha]

Description

This PR #7885 adds api endpoint for accept/decline share. After PR merge, add test coverage

• default (auto-accept)
  • decline share disable sync of share resource [tests-only][full-ci]added test for declining a share #8636
• disable auto-accept
  • accept share enable sync of share resource [tests-only][full-ci]added test with step definition for mounting share when auto accept env set to false #8623
• enable and disable sync feature in group share [tests-only][full-ci]adding scenerio for enable and disable sync feature in group share #8734
• enable sync twice [ Related issue: https://github.com/[sharing-ng] status code for multiple mount and unmount share #8876 ] [tests-only][full-ci] adding tests for multiple enable disable share #9256
  • Personal
  • Project
• disable sync twice [tests-only][full-ci] adding tests for multiple enable disable share #9256
  • Personal
  • Project
• enable /disable sync of resource from Project to user [tests-only][full-ci]Enable disable sync from project space #8789
• enable /disable sync of resource from Project to group [tests-only][full-ci]added test for enable disable share shared by project space to group #8796

Edge cases:

• try to sync when sharer is deleted (user/group)
  • Personal [tests-only][full-ci]adding tests for enable disable sync when sharer is deleted #9130
  • Project [tests-only][full-ci]adding tests for enable disable sync when sharer is deleted #9130
• try to unsync when sharer is deleted (user/group)
  • Personal [tests-only][full-ci]adding tests for enable disable sync when sharer is deleted #9130
  • Project [tests-only][full-ci]adding tests for enable disable sync when sharer is deleted #9130
• try to enable sync using:
  • non-existing item id ([Sharing-NG] creating a drive item with random item id results in 201 response. #8724)
    • [tests-only][full-ci] adding test for enabling sync of non-existent resource #8875
  • empty id ("") @grgprarup [full-ci] [tests-only] Added tests for enabling share sync with empty resource id #8963
  • not shared item id @grgprarup [full-ci] [tests-only] Added tests for enabling share sync with not shared resource id #8991
• try to disbale sync using non-existing id @grgprarup [full-ci] [tests-only] Add test for disable sync with non-existing resource #8992 [Sharing NG] disabling share sync for non-existing resource gives 400 #9001

Previously, the phrase mount and unmount was used. Currently enable and disable share is used. PR that refactors this change:

• [tests-only][full-ci] changed wording of mount unmount to enable and disable sync #8786

[S-Panta]

For declining disabling sync an upcoming share

curl -X DELETE 'https://host.docker.internal:9200/graph/v1beta1/drives/{drive-id}/items/{item-id}' -u username:password

This will change @client.synchronize property of the item to false (disable sync) which refer to declining incoming share

See #7792 (comment)
Swagger Reference: driveItem

[S-Panta]

For accepting pending share enabling share sync

curl -X POST 'https://host.docker.internal:9200/graph/v1beta1/drives/{share-Space-Id}/root/children'  
-d '{
    "remoteItem": {
        "id":"'remote-item-id"
    }
}'

This request returns drive item . remote-item-id and permission-id can be received from sharedWithMe object . Only item id is needed
See drives.root

[S-Panta]

Related bug issues for mount and unmount endpoint

• [Sharing-NG] creating a drive item with random item id results in 201 response. #8724
• [Sharing-NG] multiple mount request for items is allowed #8735
• [Sharing-NG] unmount item from share will result in 200 status code #8731

[saw-jan]

@S-Panta @SagarGi @nirajacharya2 Please, check if this can be closed or not

[S-Panta]

I think there are two bugs reported relating to enable and disable share. Test should be written to cover those scenarios too

[saw-jan]

I think there are two bugs reported relating to enable and disable share. Test should be written to cover those scenarios too

update the links if test has been added and check if those issues are tracked in other qa tickets or not

[saw-jan]

• sharer deleted (user/group) when sync enabled
  • Personal
  • Project
• sharer deleted (user/group) when sync disabled
  • Personal
  • Project

@amrita-shrestha Could elaborate the scenario for these?
Similar to these scenarios or different?

ocis/tests/acceptance/features/apiSharingNg/sharedByMe.feature

Line 1456 in 582f8b7

Scenario: user lists shared resources for deleted sharee

ocis/tests/acceptance/features/apiSharingNg/sharedByMe.feature

Line 1487 in 582f8b7

Scenario: user lists shared resources for deleted group

ocis/tests/acceptance/features/apiSharingNg/sharedWithMe.feature

Line 4194 in 582f8b7

Scenario: user lists the folder shared with them from project space after the sharer is deleted

ocis/tests/acceptance/features/apiSharingNg/sharedWithMe.feature

Line 4405 in 582f8b7

Scenario: user lists the file shared with them from personal space after the sharer is deleted

[saw-jan]

I am extending coverage in #8964 if that's the case

[saw-jan]

And in #8967

[amrita-shrestha]

@saw-jan @S-Panta, it appears that your PRs cover some scenarios, but there are still some that could be added to the "enable and disable sync" feature file. Those extended scenarios involve checking if the list shared with me lists all resources or not. However, what we need to address in the "enable/disable sync" is whether a user can change the sync state of shared resources whose owner has been deleted.
Additionally, we need to consider scenarios where a shared resource's sync state is changed and the sharee(user/group to whom resource is deleted) is deleted. In these cases, the sharer(resource owner) needs to check whether the shared resource contains information about the deleted user in the propfind response or not? similar to mentioned in this issue #9119

[S-Panta]

I will check on these scenerio.

@saw-jan @S-Panta, it appears that your PRs cover some scenarios, but there are still some that could be added to the "enable and disable sync" feature file. Those extended scenarios involve checking if the list shared with me lists all resources or not. However, what we need to address in the "enable/disable sync" is whether a user can change the sync state of shared resources whose owner has been deleted. Additionally, we need to consider scenarios where a shared resource's sync state is changed and the sharee(user/group to whom resource is deleted) is deleted. In these cases, the sharer(resource owner) needs to check whether the shared resource contains information about the deleted user in the propfind response or not?

[saw-jan]

@S-Panta What's the status of the remaining tasks here?

[S-Panta]

@S-Panta What's the status of the remaining tasks here?

Beside contract testing, I feel like most of the scenarios for this endpoint is covered.

[saw-jan]

Could you add those to the other mentioned issue? Then we can close this one

[S-Panta]

I have linked the share in another issue. I think we can close this now