-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File is still locked after removing or updating share #8273
Comments
The same behavior occurs when the permission has been changed from |
The logs are from a local setup.
@wkloucek I noticed that the lock has been changed before an error. It could be a reason for the issue. |
Update:
|
After some more testing and debugging we seem to understand that the root cause is that the wopiserver manages the locks in the scopes of users instead of applications. We also created a wopiserver issue to discuss the matters there. The options moving forward seem to be:
Additionally we could change our business logic - at least until a proper solution is in place - to allow adding grants (which doesn't trigger that issue and is probably the more common case) but prevent removing grants while a lock is in place. That at least makes sure that there won't be stale locks, but makes it impossible to revoke permissions while a wopi session is open. /cc @butonic |
The same error happens if user A working with a document in Collabora and user B tries to open the same document in Onlyoffice. |
@2403905 is that "in progress" or "to do" ? |
@micbar I moved back to the |
I mean the issue with the locks in a wopi |
@micbar To avoid annoying behavior with the locks, can we prevent removing or changing grants while a lock is in place for the ocis v5 until we implement the better solution? |
Reading the wopi docs from Microsoft it says that locks should be done on an application level, not bound to a user. |
We should take the workaround here, disallow remove grants or update grants. |
related #6368 #8264 #8060
Steps:
.odt
file to einstein with edit roleActual: file is still locked. admin cannot open this file

After removing access to einstein -> einstein does not unlock the file
<d:owner>OnlyOffice</d:owner><d:timeout>Second-2770</d:timeout>
Screen.Recording.2024-01-23.at.16.54.40.mov
cc @aduffeck
The text was updated successfully, but these errors were encountered: