Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing of Trashbin Items Slow #7844

Closed
3 tasks
dragotin opened this issue Nov 29, 2023 · 3 comments
Closed
3 tasks

Listing of Trashbin Items Slow #7844

dragotin opened this issue Nov 29, 2023 · 3 comments
Labels
Severity:sev2-high operations severely restricted, workaround available Type:Bug

Comments

@dragotin
Copy link
Contributor

Based on findings in https://github.com/owncloud/enterprise/issues/6213 it is understood that listing the trashbin items is taking too long if a significant amount of files were deleted and are in the trashbin.

The code is known to be not optimized. So the action to undertake is

  • Check the code and find the bottlenecks
  • Find a way to increase the listing performance by (probably) parallelize the reading of the items from the trashbin structure
  • Propose a as small as possible code patch to fix the behaviour and increase listing performance that can be applied to the v4 code branch.
@dragonchaser
Copy link
Contributor

dragonchaser commented Nov 29, 2023

With cs3org/reva#4374 & delay (vm nfs-server, delay via tc):

delay edge cold edge warm pr cold pr warm
2.5ms 33.5s 12.7s 20s 10.29s

@dragonchaser
Copy link
Contributor

After parallelizing the globbing we end up with the following values:

delay edge cold edge warm pr cold pr warm
2.5ms 28.46s 10.58s 703ms 280ms

@micbar
Copy link
Contributor

micbar commented Dec 8, 2023

fixed and relased with ocis v4.0.4

@micbar micbar moved this from In progress to Done in Infinite Scale Team Board Dec 8, 2023
@dragonchaser dragonchaser removed their assignment Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity:sev2-high operations severely restricted, workaround available Type:Bug
Projects
Archived in project
Development

No branches or pull requests

4 participants