COPY a `folder` to received share `file/folder` seems to work but no change in shares - lost share mountpoint in `me/drives` #6999

amrita-shrestha · 2023-08-09T10:05:47Z

Describe the bug

While trying to COPY a personal space FOLDER to (not inside) received share file or folder, the server responds with success response but the shares has no change and the share mountpoint is lost from the me/drives list.

Steps to reproduce

admin, share a folder adminFolder with demo user
demo, create a folder demoFolder in Personal space

demo, try to COPY demoFolder to received share adminFolder from admin

curl -XCOPY "https://localhost:9200/dav/files/demo/demoFolder" \
-H"Destination: https://localhost:9200/dav/files/demo/Shares/adminFolder" \
-udemo:demo -vk

< HTTP/1.1 201 Created

demo, check the drives list: no adminFolder share drive ❌

curl "https://host.docker.internal:9200/graph/v1.0/me/drives" -udemo:demo -vk | jq

demo, check the sharedWithMe list: adminFolder share is listed ✔️

curl "https://host.docker.internal:9200/graph/v1beta1/me/drive/sharedWithMe" -udemo:demo -vk | jq

admin, check the file permissions - share entry is there ✔️

curl "https://host.docker.internal:9200/graph/v1beta1/drives/{admin-drive-id}/items/{adminFolder-id}/permissions" \
-uadmin:admin -vk | jq

The text was updated successfully, but these errors were encountered:

amrita-shrestha · 2023-08-10T07:13:14Z

Related issues : #3874 and #4393 may be we can close
cc @micbar @ScharfViktor

ScharfViktor · 2023-08-10T08:09:18Z

Sorry, I couldn't reproduce it. Is /index.php at the end correct?

My request:

curl 'https://localhost:9200/remote.php/dav/spaces/803119ff-437b-4c58-b0f9-1b4b04910839%24f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/ironman.txt' \
  -X 'COPY' \
  -H $'Destination: https://localhost:9200/remote.php/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668\u0021803119ff-437b-4c58-b0f9-1b4b04910839%3A4c510ada-c86b-4815-8820-42cdf82c3d51%3A63e09646-6527-4e14-a7a1-ef3b17661af4/ironman.txt' \
  -H 'Overwrite: F' \
  --insecure

amrita-shrestha · 2023-08-10T09:45:13Z

Sorry, I couldn't reproduce it. Is /index.php at the end correct?

My request:

curl 'https://localhost:9200/remote.php/dav/spaces/803119ff-437b-4c58-b0f9-1b4b04910839%24f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/ironman.txt' \
  -X 'COPY' \
  -H $'Destination: https://localhost:9200/remote.php/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668\u0021803119ff-437b-4c58-b0f9-1b4b04910839%3A4c510ada-c86b-4815-8820-42cdf82c3d51%3A63e09646-6527-4e14-a7a1-ef3b17661af4/ironman.txt' \
  -H 'Overwrite: F' \
  --insecure

Sorry pasted api request where i try to copy index.php file
@ScharfViktor could you try removing ironman.txt from Destination and not setting -H 'Overwrite: F'
-H $'Destination: https://localhost:9200/remote.php/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668\u0021803119ff-437b-4c58-b0f9-1b4b04910839%3A4c510ada-c86b-4815-8820-42cdf82c3d51%3A63e09646-6527-4e14-a7a1-ef3b17661af4/

ScharfViktor · 2023-08-10T12:37:47Z

I don't know how realistic it is to move a file to a shared mount point.

I get 502 Error <s:message>gateway does not support cross storage move, use copy and delete</s:message> and shared folder moves to decline.

I'm interested in the same case(not realistic but) with project space that leads to data loss

Steps:

admin creates project space
admin shares space to marie (editor or manager role)
marie copies file from personal space to project space using:

curl --location --request MOVE 'https://localhost:9200/remote.php/dav/spaces/{personalSpaceUUID}/ironman.txt' \
--header 'Destination: https://localhost:9200/remote.php/dav/spaces/{projectSpaceUUID}' \
--header 'Authorization: Basic bWFyaWU6cmFkaW9hY3Rpdml0eQ=='

result: 500 error and no project space for users
log:
{"level":"error","service":"ocdav","name":"com.owncloud.web.ocdav","traceid":"00000000000000000000000000000000","request-id":"Viktors-Air.local/jtcZawt1wM-000470","spaceid":"803119ff-437b-4c58-b0f9-1b4b04910839$f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c","path":"/ironman.txt","status":{"code":15,"message":"delete:remove /Users/scharfviktor/.ocis/storage/users/spaces/6f/3a6508-db7b-4707-8682-40b843eed187/nodes/New space: no such file or directory","trace":"e139bc77c308591c570fc81aae2de966"},"code":500,"time":"2023-08-10T14:31:50.465315+02:00","message":"Internal Server Error"}

kobergj · 2023-08-10T12:59:44Z

probably same issue like: #6739

ScharfViktor · 2023-08-10T13:03:57Z

probably same issue like: #6739

Yes, thank you

ScharfViktor · 2023-08-10T13:14:09Z

like in #6739 /remote.php in Destination url is trigger. without /remote.php I get 400 error and nothing bad happens.

SwikritiT · 2023-08-21T10:46:08Z

The behavior is the same for copying a folder into a file using the webdav as well but in webdav we get 204 but the share gets declined

Here I'm copying a folder adad to a shared file test.txt then the status code is 204 but the share is declined and the test.txt is not changed.

curl -X COPY -u einstein:relativity 'https://localhost:9200/remote.php/webdav/adad' -H "Destination:  https://localhost:9200/remote.php/webdav/Shares/test.txt" -vk

response

*   Trying 127.0.0.1:9200...
* Connected to localhost (127.0.0.1) port 9200 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* TLSv1.0 (OUT), TLS header, Certificate Status (22):
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS header, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS header, Finished (20):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.2 (OUT), TLS header, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: O=Acme Corp; CN=OCIS
*  start date: Aug 21 10:03:10 2023 GMT
*  expire date: Aug 20 10:03:10 2024 GMT
*  issuer: O=Acme Corp; CN=OCIS
*  SSL certificate verify result: self-signed certificate (18), continuing anyway.
* Server auth using Basic with user 'einstein'
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
> COPY /remote.php/webdav/adad HTTP/1.1
> Host: localhost:9200
> Authorization: Basic ZWluc3RlaW46cmVsYXRpdml0eQ==
> User-Agent: curl/7.81.0
> Accept: */*
> Destination:  https://localhost:9200/remote.php/webdav/Shares/test.txt
> 
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* Mark bundle as not supporting multiuse
< HTTP/1.1 204 No Content
< Access-Control-Allow-Origin: *
< Content-Security-Policy: default-src 'none';
< Date: Mon, 21 Aug 2023 10:27:05 GMT
< Vary: Origin
< X-Content-Type-Options: nosniff
< X-Download-Options: noopen
< X-Frame-Options: SAMEORIGIN
< X-Permitted-Cross-Domain-Policies: none
< X-Request-Id: swikriti-OptiPlex-3070/rLnTbi8eJa-002326
< X-Robots-Tag: none
< X-Xss-Protection: 1; mode=block
< 
* Connection #0 to host localhost left intact

Note: In webdav, this request should overwrite the file text.txt converting it to the folder and copying the content of adad inside it. so the new folder should be something like /Shares/text.txt/adad

saw-jan · 2024-07-29T10:36:19Z

❗ Current behaviour: after performing COPY, the share drive (share mountpoint) got lost while listing the me/drives

Steps to reproduce

admin, share a folder adminFolder with demo user
demo, create a folder demoFolder in Pesronal space

demo, try to COPY demoFolder to received share adminFolder from admin

curl -XCOPY "https://localhost:9200/dav/files/demo/demoFolder" \
-H"Destination: https://localhost:9200/dav/files/demo/Shares/adminFolder" \
-udemo:demo -vk

< HTTP/1.1 201 Created

demo, check the drives list: no adminFolder share drive ❌

curl "https://host.docker.internal:9200/graph/v1.0/me/drives" -udemo:demo -vk | jq

demo, check the sharedWithMe list: adminFolder share is listed ✔️

curl "https://host.docker.internal:9200/graph/v1beta1/me/drive/sharedWithMe" -udemo:demo -vk | jq

admin, check the file permissions - share entry is there ✔️

curl "https://host.docker.internal:9200/graph/v1beta1/drives/{admin-drive-id}/items/{adminFolder-id}/permissions" \
-uadmin:admin -vk | jq

amrita-shrestha added the Type:Bug label Aug 9, 2023

This was referenced Aug 9, 2023

copy to overwrite (file and folder) from Personal to Shares Jail behaves differently #4393

Closed

create WebDAV API tests for accessing files by fileID #6737

Closed

This was referenced Aug 21, 2023

[tests-only]Update expected to fail file to link failing tests to correct issue #7081

Merged

[tests-only] Backport/7081 #7090

Merged

saw-jan changed the title ~~copy personal space file to shared folder root result share in decline state~~ COPY a "folder" to received share "file/folder" seems to work but no change in shares - lost share mountpoint in me/drives Jul 29, 2024

saw-jan changed the title ~~COPY a "folder" to received share "file/folder" seems to work but no change in shares - lost share mountpoint in me/drives~~ COPY a "folder" to received share "file/folder" seems to work but no change in shares - lost share mountpoint in "me/drives" Jul 29, 2024

saw-jan changed the title ~~COPY a "folder" to received share "file/folder" seems to work but no change in shares - lost share mountpoint in "me/drives"~~ COPY a "folder" to received share "file/folder" seems to work but no change in shares - lost share mountpoint in me/drives Jul 29, 2024

saw-jan changed the title ~~COPY a "folder" to received share "file/folder" seems to work but no change in shares - lost share mountpoint in me/drives~~ COPY a folder to received share file/folder seems to work but no change in shares - lost share mountpoint in me/drives Jul 29, 2024

micbar added this to Infinite Scale Team Board Jul 29, 2024

github-project-automation bot moved this to Qualification in Infinite Scale Team Board Jul 29, 2024

micbar moved this from Qualification to Prio 2 in Infinite Scale Team Board Jul 29, 2024

micbar added the Priority:p2-high Escalation, on top of current planning, release blocker label Jul 29, 2024

kobergj self-assigned this Jul 31, 2024

kobergj moved this from Prio 2 to In progress in Infinite Scale Team Board Jul 31, 2024

This was referenced Jul 31, 2024

Block overwriting mountpoints through COPY cs3org/reva#4785

Merged

[full-ci] Bump Reva #9719

Closed

[full-ci] Bump Reva & Tusd #9714

Merged

kobergj closed this as completed in #9714 Aug 7, 2024

github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Aug 7, 2024

saw-jan mentioned this issue Aug 7, 2024

COPY file/folder to share mountpoint: inconsistent behavior between dav paths #9753

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COPY a `folder` to received share `file/folder` seems to work but no change in shares - lost share mountpoint in `me/drives` #6999

COPY a `folder` to received share `file/folder` seems to work but no change in shares - lost share mountpoint in `me/drives` #6999

amrita-shrestha commented Aug 9, 2023 •

edited by saw-jan

Loading

amrita-shrestha commented Aug 10, 2023

ScharfViktor commented Aug 10, 2023

amrita-shrestha commented Aug 10, 2023 •

edited

Loading

ScharfViktor commented Aug 10, 2023 •

edited

Loading

kobergj commented Aug 10, 2023

ScharfViktor commented Aug 10, 2023

ScharfViktor commented Aug 10, 2023

SwikritiT commented Aug 21, 2023 •

edited

Loading

saw-jan commented Jul 29, 2024

COPY a folder to received share file/folder seems to work but no change in shares - lost share mountpoint in me/drives #6999

COPY a folder to received share file/folder seems to work but no change in shares - lost share mountpoint in me/drives #6999

Comments

amrita-shrestha commented Aug 9, 2023 • edited by saw-jan Loading

Describe the bug

Steps to reproduce

amrita-shrestha commented Aug 10, 2023

ScharfViktor commented Aug 10, 2023

amrita-shrestha commented Aug 10, 2023 • edited Loading

ScharfViktor commented Aug 10, 2023 • edited Loading

kobergj commented Aug 10, 2023

ScharfViktor commented Aug 10, 2023

ScharfViktor commented Aug 10, 2023

SwikritiT commented Aug 21, 2023 • edited Loading

saw-jan commented Jul 29, 2024

Steps to reproduce

COPY a `folder` to received share `file/folder` seems to work but no change in shares - lost share mountpoint in `me/drives` #6999

COPY a `folder` to received share `file/folder` seems to work but no change in shares - lost share mountpoint in `me/drives` #6999

amrita-shrestha commented Aug 9, 2023 •

edited by saw-jan

Loading

amrita-shrestha commented Aug 10, 2023 •

edited

Loading

ScharfViktor commented Aug 10, 2023 •

edited

Loading

SwikritiT commented Aug 21, 2023 •

edited

Loading