Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the email body does not contain the name of the receiver when the receiver has set the language to german #6656

Closed
nirajacharya2 opened this issue Jun 28, 2023 · 4 comments

Comments

@nirajacharya2
Copy link
Contributor

Describe the bug

When a space is shared to a group and if a member of that group is using german language he gets a mail notification without his name.

Hallo <no value>,

Admin hat Sie eingeladen, dem Space "<space-name>" beizutreten.

Zum Ansehen hier klicken: <base-url>/f/<space-id>

Steps to reproduce

Steps to reproduce the behavior:

  1. create a space as marie
  2. create a group group1
  3. add einstein to that group
  4. change einstein's language to de
  5. share that space with group1
  6. einstein gets a mail notification

Expected behavior

einstein should receive mail notification with his name

Expected email body

Hallo <user-name>,

Admin hat Sie eingeladen, dem Space "<space-name>" beizutreten.

Zum Ansehen hier klicken: <base-url>/f/<space-id>

Actual behavior

einstein receives mail notification without his name

Setup

Ocis : latest master

Additional context

Add any other context about the problem here.

@phil-davis
Copy link
Contributor

Do space-name and base-url get filled in correctly in the email?

@micbar
Copy link
Contributor

micbar commented Jun 28, 2023

I fixed the placeholder in transifex.

Needs a re-sync

@micbar
Copy link
Contributor

micbar commented Jun 28, 2023

Should be fixed now 164b24c

Can you re test please?

@phil-davis phil-davis changed the title the email body does not contain the name of the reciver when the reciver has set the language to german the email body does not contain the name of the receiver when the receiver has set the language to german Jun 28, 2023
@nirajacharya2
Copy link
Contributor Author

Do space-name and base-url get filled in correctly in the email?

yes space-name gets filled with the spaces name and base-url with https://localhost:9200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants