Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications] notification message should be more specific #6286

Closed
amrita-shrestha opened this issue May 8, 2023 · 2 comments
Closed
Labels
Category:Enhancement Add new functionality

Comments

@amrita-shrestha
Copy link
Contributor

Steps to reproduce

  1. Admin creates space hello
  2. Admin add user Roy to space hello with space-role manager
  3. notification contains message Admin added you to Space hello
  4. Admin changed Roy space-role to 'editor'
  5. new notification pop-up with the message Admin added you to Space hello
    Screenshot from 2023-05-08 11-10-38

Expected behaviour

While role changed notification message should be something like this `Admin changed your role to the editor in Space hello``

Actual behaviour

Admin added you to Space hello

Environment general

Operating system: ubuntu 22.04

Backend (ownCloud Core or Infinite Scale): ocis

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Environment ownCloud Infinite Scale

Version: latest

Updated from an older Infinite Scale or fresh install: fresh

Where did you install Infinite Scale from: github

@amrita-shrestha amrita-shrestha added the Category:Enhancement Add new functionality label May 8, 2023
@ScharfViktor
Copy link
Contributor

It is backend issue. This is because we use the same request for creating and changing space sharePOST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares so requests GET https://localhost:9200/ocs/v2.php/apps/notifications/api/v1/notifications?format=json are same

Web can't tell the difference

@amrita-shrestha amrita-shrestha transferred this issue from owncloud/web May 12, 2023
@ScharfViktor
Copy link
Contributor

The user does not receive notification of a space role change anymore
#6649 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

2 participants