[QA][ocis] Share notification doesn't have all necessary action buttons

[saw-jan]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

Share notification in the Server Activity tab doesn't have all action buttons (Dismiss, Accept, Decline)

1. Share a file from server
2. Open desktop client
3. Activity tab -> Server Activity

Expected behavior

Client version number

ownCloud 4.0.0.10781-rc2 bc29e0
Libraries Qt 5.15.8, OpenSSL 1.1.1t 7 Feb 2023
Using virtual files plugin: wincfapi
windows-10.0.17763

Server information

Infinite Scale 3.0.0-rc.2

Desktop client logs

• oCIS: ownCloud-ocis.log
• oC10: ownCloud-oc10.log

Similar to owncloud/client#10814

[michaelstingl]

@saw-jan where's the log? (oCIS and oC10)

[saw-jan]

where's the log? (oCIS and oC10)

I have now attached the logs. 👍

[michaelstingl]

• oC10: ownCloud-ocis.log

Not an oC10 log.

I uploaded and analysed the oCIS log here:

• https://cloud.owncloud.com/index.php/f/5999875

[michaelstingl]

Expected behavior

I'd say backend doesn't send the information for the 3 buttons:

                {
                    "notification_id": "5e0a7389-8476-4914-9458-ebf6c45e6e80",
                    "app": "userlog",
                    "user": "admin",
                    "datetime": "2023-05-08T11:39:20.728491231Z",
                    "object_id": "6efa9535-5307-499e-8c35-799bf498a3b4$721cbbb8-ad90-4daf-b229-793530f91219!8811ce3c-9860-45ae-9d0f-2c61a73a4d83",
                    "object_type": "share",
                    "subject": "Resource shared",
                    "subjectRich": "Resource shared",
                    "message": "Admin shared test with you",
                    "messageRich": "{user} shared {resource} with you",
                    "messageRichParameters":
                    {
                        "resource":
                        {
                            "id": "6efa9535-5307-499e-8c35-799bf498a3b4$721cbbb8-ad90-4daf-b229-793530f91219!8811ce3c-9860-45ae-9d0f-2c61a73a4d83",
                            "name": "test"
                        },
                        "share":
                        {
                            "id": "6efa9535-5307-499e-8c35-799bf498a3b4:721cbbb8-ad90-4daf-b229-793530f91219:dbeeea9b-95ab-4ab9-a7a8-1dbd89adb046"
                        },
                        "user":
                        {
                            "displayname": "Admin",
                            "id": "721cbbb8-ad90-4daf-b229-793530f91219",
                            "name": "admin"
                        }
                    }
                },

Looking forward for the oC10 log to compare… I'd expect something like https://doc.owncloud.com/server/next/developer_manual/core/apis/ocs-notification-endpoint-v1.html#response-with-notifications

			"actions": [{
				"label": "Accept",
				"link": "http:\/\/localhost\/ocs\/v1.php\/apps\/files_sharing\/api\/v1\/remote_shares\/13",
				"type": "POST",
				"primary": true
			}, {
				"label": "Decline",
				"link": "http:\/\/localhost\/ocs\/v1.php\/apps\/files_sharing\/api\/v1\/remote_shares\/13",
				"type": "DELETE",
				"primary": false
			}]

@micbar

[micbar]

The full support of all actions was not in scope of the server implementation.

We need to do a follow up if needed. @tbsbdr @michaelstingl

[tbsbdr]

yes, needs some rework

[saw-jan]

Not an oC10 log.

I uploaded the wrong file 😢
Here is the oc10 log: ownCloud-oc10.log
Also updated in the description

oC10 has actions properties in the response

{
  "notification_id": 6,
  "app": "files_sharing",
  "user": "admin",
  "datetime": "2023-05-08T12:02:16+00:00",
  "object_type": "local_share",
  "object_id": "ocinternal:32",
  "subject": "\\\"demo\\\" shared \\\"folder\\\" with you",
  "message": "\\\"demo\\\" invited you to view \\\"folder\\\"",
  "link": "http:\\/\\/10.0.2.2\\/ocstable\\/index.php\\/f\\/262",
  "actions": [
    {
      "label": "Decline",
      "link": "http:\\/\\/10.0.2.2\\/ocstable\\/ocs\\/v1.php\\/apps\\/files_sharing\\/api\\/v1\\/shares\\/pending\\/32",
      "type": "DELETE",
      "primary": false
    },
    {
      "label": "Accept",
      "link": "http:\\/\\/10.0.2.2\\/ocstable\\/ocs\\/v1.php\\/apps\\/files_sharing\\/api\\/v1\\/shares\\/pending\\/32",
      "type": "POST",
      "primary": true
    }
  ],
  "icon": "\\/ocstable\\/core\\/img\\/actions\\/shared.svg"
}

[michaelstingl]

Current backend implementation is fine for me. Maybe needs documentation. We could decide to invest efforts only in a future, nicer API…