Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userlog service not updating redis key if it doesn't exist #6251

Closed
Excds opened this issue May 8, 2023 · 4 comments
Closed

Userlog service not updating redis key if it doesn't exist #6251

Excds opened this issue May 8, 2023 · 4 comments
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug

Comments

@Excds
Copy link

Excds commented May 8, 2023

In the userlog service redis keys will not be updated if they do not exist. The problem is with catching an exception from the redis store at line:

if err != nil && err != store.ErrNotFound {

The PR micro/plugins#97 introduced the problem because the store.ErrNotFound was replaced with the redis error.

@Excds Excds added the Type:Bug label May 8, 2023
@micbar
Copy link
Contributor

micbar commented May 8, 2023

what is the user impact?

@wkloucek
Copy link
Contributor

wkloucek commented May 8, 2023

what is the user impact?

If using an initially empty redis(-sentinal) store, no user will ever receive a notification.

@micbar micbar moved this from Qualification to Prio 1 in Infinite Scale Team Board May 8, 2023
@micbar micbar added the Priority:p1-urgent Consider a hotfix release with only that fix label May 8, 2023
@dragonchaser
Copy link
Contributor

@micbar
Copy link
Contributor

micbar commented May 8, 2023

should be fixed in rc.3

@micbar micbar closed this as completed May 8, 2023
@github-project-automation github-project-automation bot moved this from Prio 1 to Done in Infinite Scale Team Board May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug
Projects
Archived in project
Development

No branches or pull requests

4 participants