-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin-settings] Spaces: Admin cannot disable space which he is not member of #5960
Comments
That's because the
In general: content revealing actions are only possible for |
@micbar told me that an admin (not space admin) should be able to disable/enable a space even when he's not member of it, which sounds reasonable to me from a UI perspective. That's why I opened this issue. Did I got that wrong? If so, I'm sorry. |
@micbar just confirmed that it's a bug |
let us check. I was not aware that the Admin misses that permission. |
@hurradieweltgehtunter Is that a default ocis instance? |
|
There is also a permission called |
seems they are redundant. Let me do a code check in the backend. |
@micbar What's the status here, should we move the issue to the oCIS repo? |
@JammingBen I think we can close this issue because this issue has been resolved and we have passing API tests for this issue ocis/tests/acceptance/features/apiSpaces/disableAndDeleteSpaces.feature Lines 90 to 122 in 7094891
Similar issue #5872 |
@JammingBen @ScharfViktor This issue is fixed so may be this can be closed. Test has been added for it and seems to be working fine more tests covered up by this PR as well related to admin managing the spaces created by others (where he is not the member of the space) owncloud/web#9132 |
Steps to reproduce
Expected behaviour
Actions to disable/enable a space are disabled
Actual behaviour
I cannot disable / enable a space
From my current understanding, this should be possible, because it's not a space content revealing action. (Content revealing actions like name, description,... are reserved to space managers)
The text was updated successfully, but these errors were encountered: