Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Viewer can modify shared folder on owncloud and ocis driver #236

Closed
jnweiger opened this issue Sep 15, 2020 · 13 comments
Closed

[QA] Viewer can modify shared folder on owncloud and ocis driver #236

jnweiger opened this issue Sep 15, 2020 · 13 comments
Labels
bug Something isn't working p3-medium qa Type:Bug

Comments

@jnweiger
Copy link

Tested with

Version details ocis-1.0.0-rc1 
OCIS_VERSION:         master
ocis --version:       ocis version 3f8fb10
git log:              commit 3f8fb10990c37377a0e102492922ffd4807571d6 (HEAD -> refs/heads/master, refs/remotes/origin/master, refs/remotes/origin/HEAD)
eos --version:        EOS 4.6.5 (2019)
xrootd -v:            v4.11.0
bin/ocis contains:
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/ocis-pkg/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]
	owncloud/[email protected]

Reproducer

  • use two differnet browser session. log in marie and einstein simultaneously.
  • marie creates a folder and adds a photo into that folder
  • marie shares the folder with einstein as Viewer
  • einstein visits 'shared with me' and accepts the folder
  • einstein visits his "Shares", and enters the folder.
  • einstein renames the photo.
  • einstein deletes the photo
  • einstein adds another file

Expected behaviour: einsteins should not be able to rename, delete add as role viewer.

This was changed since RC1. In rc1, all shared folders were readonly.
@PVince81
Copy link

PVince81 commented Sep 16, 2020 •
edited
Loading

This was changed

it was actually broken, so it wasn't permission enforcement but rather that file operations were not working at all within received shares.

we fixed file operations to work correctly, so now the error is gone and the operations go through

however, we need now to work on actually enforcing permissions.
I didn't find any existing ticket for this, so this is likely an open task

Correction: the above comment only applies to OC storage

@PVince81
Copy link

@butonic were sharing permissions implemented with EOS ? AFAIK we are setting ACLs already, so this would be expected to work and is a bug if it doesn't ? or is it a task ?

@butonic
Copy link
Member

butonic commented Sep 18, 2020 •
edited
Loading

reproducible on ocis and owncloud driver

the permissions should have been enforced by the storage driver. will check with eos

@pmaier1 pmaier1 transferred this issue from owncloud/ocis Sep 18, 2020
@pmaier1 pmaier1 added the qa label Sep 18, 2020
@exalate-issue-sync exalate-issue-sync bot added bug Something isn't working p3-medium labels Sep 18, 2020
@butonic
Copy link
Member

butonic commented Sep 18, 2020 •
edited
Loading

when I am on eos I cannot upload into a shared folder, the acls are stored and enforced properly

but I still get this error:

ocis          | 2020-09-18T09:12:44Z INF access token is already provided pkg=rhttp service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG http routing head=remote.php pkg=rhttp service=reva tail="/webdav/Shares/from einstein ro/f2" traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/Stat pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG gateway: split: path:/home/Shares/from einstein ro/f2 parts:[home Shares from einstein ro f2] shareFolder:Shares pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG gateway: split: path:/home/Shares/from einstein ro/f2 parts:[home Shares from einstein ro f2] shareFolder:Shares pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG gateway: split: path:/home/Shares/from einstein ro/f2 parts:[home Shares from einstein ro f2] shareFolder:Shares pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z INF unary code=OK end="18/Sep/2020:09:12:44 +0000" from=tcp://127.0.0.1:40318 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=185291 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:44Z INF eos: get md for ref:path:"/Shares/from einstein ro"  pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info /eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/Shares/from einstein ro -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err= exit=0 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: unwrapInternal: trim=/eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c external=/Shares/from einstein ro ns=/eos/dockertest/reva/users/.shadow np=/eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/Shares/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: unwrap: internal=/eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/Shares/from einstein ro external=/Shares/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG skipping auth method=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z ERR reva/internal/grpc/services/userprovider/userprovider.go:125 > error getting user by claim error="userprovidersvc: error getting user by claim: error: not found: uidnumber:0" pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z INF unary code=OK end="18/Sep/2020:09:12:44 +0000" from=tcp://127.0.0.1:57398 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=62634023 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:44Z INF unary code=OK end="18/Sep/2020:09:12:44 +0000" from=tcp://127.0.0.1:42834 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=63287857 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:44Z INF unary code=OK end="18/Sep/2020:09:12:44 +0000" from=tcp://127.0.0.1:51240 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=93693689 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:44Z INF unary code=OK end="18/Sep/2020:09:12:44 +0000" from=tcp://127.0.0.1:40318 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=110036 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:44Z INF eos: get md for ref:id:<opaque_id:"49" >  pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info inode:49 -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err= exit=0 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: unwrapInternal: trim=/eos/dockertest/reva/users external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro ns=/eos/dockertest/reva/users np=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: unwrap: internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: wrap external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info /eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err= exit=0 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: unwrapInternal: trim=/eos/dockertest/reva/users external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro ns=/eos/dockertest/reva/users np=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG eos: unwrap: internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:44Z DBG skipping auth method=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG entries entries=[{"Attributes":[{"ByteValues":["ZWluc3RlaW4="],"Name":"cn","Values":["einstein"]},{"ByteValues":["NGM1MTBhZGEtYzg2Yi00ODE1LTg4MjAtNDJjZGY4MmMzZDUx"],"Name":"ownCloudUUID","Values":["4c510ada-c86b-4815-8820-42cdf82c3d51"]},{"ByteValues":["QWxiZXJ0IEVpbnN0ZWlu"],"Name":"displayName","Values":["Albert Einstein"]},{"ByteValues":["ZWluc3RlaW5AZXhhbXBsZS5vcmc="],"Name":"mail","Values":["[email protected]"]},{"ByteValues":["MjAwMDA="],"Name":"uidnumber","Values":["20000"]},{"ByteValues":["MzAwMDA="],"Name":"gidnumber","Values":["30000"]}],"DN":"cn=einstein,ou=users,dc=example,dc=org"}] pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:57398 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=102683290 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:43958 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=103121997 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:43274 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=137356584 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:40318 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=139588 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF eos: get md for ref:path:"/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2"  pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: wrap external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info /eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err="error: cannot stat '/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2'\n (errc=2) (No such file or directory)\n" exit=2 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z WRN reva/internal/grpc/services/storageprovider/storageprovider.go:468 > file not found pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:43274 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=18193610 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z WRN reva/internal/grpc/services/gateway/storageprovider.go:1163 > gateway: file not found:path:"/eos/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2"  pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:40348 pkg=rgrpc service=reva start="18/Sep/2020:09:12:44 +0000" time_ns=252470514 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.gateway.v1beta1.GatewayAPI/Stat user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/CreateContainer pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG gateway: split: path:/home/Shares/from einstein ro/f2 parts:[home Shares from einstein ro f2] shareFolder:Shares pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG gateway: split: path:/home/Shares/from einstein ro/f2 parts:[home Shares from einstein ro f2] shareFolder:Shares pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG gateway: split: path:/home/Shares/from einstein ro/f2 parts:[home Shares from einstein ro f2] shareFolder:Shares pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG shared child: /home/Shares/from einstein ro/f2 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:40318 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=112905 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF eos: get md for ref:path:"/Shares/from einstein ro"  pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info /eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/Shares/from einstein ro -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err= exit=0 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: unwrapInternal: trim=/eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c external=/Shares/from einstein ro ns=/eos/dockertest/reva/users/.shadow np=/eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/Shares/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: unwrap: internal=/eos/dockertest/reva/users/.shadow/f/f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c/Shares/from einstein ro external=/Shares/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG skipping auth method=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z ERR reva/internal/grpc/services/userprovider/userprovider.go:125 > error getting user by claim error="userprovidersvc: error getting user by claim: error: not found: uidnumber:0" pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:57398 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=50368576 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:42834 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=50775458 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:51240 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=69419136 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:40318 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=111845 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF eos: get md for ref:id:<opaque_id:"49" >  pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info inode:49 -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err= exit=0 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: unwrapInternal: trim=/eos/dockertest/reva/users external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro ns=/eos/dockertest/reva/users np=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: unwrap: internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: wrap external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 file info /eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro -m --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err= exit=0 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: unwrapInternal: trim=/eos/dockertest/reva/users external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro ns=/eos/dockertest/reva/users np=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: unwrap: internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG skipping auth method=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG entries entries=[{"Attributes":[{"ByteValues":["ZWluc3RlaW4="],"Name":"cn","Values":["einstein"]},{"ByteValues":["NGM1MTBhZGEtYzg2Yi00ODE1LTg4MjAtNDJjZGY4MmMzZDUx"],"Name":"ownCloudUUID","Values":["4c510ada-c86b-4815-8820-42cdf82c3d51"]},{"ByteValues":["QWxiZXJ0IEVpbnN0ZWlu"],"Name":"displayName","Values":["Albert Einstein"]},{"ByteValues":["ZWluc3RlaW5AZXhhbXBsZS5vcmc="],"Name":"mail","Values":["[email protected]"]},{"ByteValues":["MjAwMDA="],"Name":"uidnumber","Values":["20000"]},{"ByteValues":["MzAwMDA="],"Name":"gidnumber","Values":["30000"]}],"DN":"cn=einstein,ou=users,dc=example,dc=org"}] pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:57398 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=109246671 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.identity.user.v1beta1.UserAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:43958 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=109763787 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.gateway.v1beta1.GatewayAPI/GetUserByClaim user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:43274 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=144449888 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:40318 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=129292 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF eos: createdir: path=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z DBG eos: wrap external=/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 internal=/eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF eos cmd args="[/usr/bin/eos -r 20001 30000 mkdir -p /eos/dockertest/reva/users/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2 --comment 1f3c96bb5f1aaf64cc7963af552ab513]" env=[EOS_MGM_URL=root://mgm-master.testnet:1094] err="error: unable to create directory (errc=1) (Operation not permitted)\n" exit=1 pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z ERR reva/internal/grpc/services/storageprovider/storageprovider.go:384 > error creating container: path:"/eos/4/4c510ada-c86b-4815-8820-42cdf82c3d51/from einstein ro/f2"  error="eosclient: error while executing command: exit status 1" pkg=rgrpc service=reva traceid=1f3c96bb5f1aaf64cc7963af552ab513
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:43274 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=24887411 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.storage.provider.v1beta1.ProviderAPI/CreateContainer user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z INF unary code=OK end="18/Sep/2020:09:12:45 +0000" from=tcp://127.0.0.1:40348 pkg=rgrpc service=reva start="18/Sep/2020:09:12:45 +0000" time_ns=242601883 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateContainer user-agent=grpc-go/1.26.0
ocis          | 2020-09-18T09:12:45Z ERR http end="18/Sep/2020:09:12:45 +0000" host=127.0.0.1 method=MKCOL pkg=rhttp proto=HTTP/1.1 service=reva size=0 start="18/Sep/2020:09:12:44 +0000" status=500 time_ns=496319381 traceid=1f3c96bb5f1aaf64cc7963af552ab513 uri=/remote.php/webdav/Shares/from%20einstein%20ro//f2/ url=/remote.php/webdav/Shares/from%20einstein%20ro//f2/

this smells: error getting user by claim error="userprovidersvc: error getting user by claim: error: not found: uidnumber:0"

  • also the ui just sits there, the dialog does not close and no error pops up ... maybe because of the 500 error ... @LukasHirt maybe?

@butonic
Copy link
Member

butonic commented Sep 18, 2020

@jnweiger I see you are trying to create some skeleton in einsteins home in https://github.com/owncloud-docker/compose-playground/blob/master/examples/hetzner-deploy/make_ocis_eos_compose_test.sh#L272-L284

In the process you are omitting some of the things that the eoshome driver does to create the storage, eg setting some special attributes: see https://github.com/cs3org/reva/blob/master/pkg/storage/utils/eosfs/eosfs.go#L818-L952

instead of doing that you could trigger a basic auth login: curl -X PROPFIND https:.../remote.php/webdav -u einstein:relativity this would set up the users home with all the bells and whistles.

@butonic
Copy link
Member

butonic commented Sep 18, 2020

fixing related bugs on eos client as I go: cs3org/reva#1183

@butonic
Copy link
Member

butonic commented Sep 18, 2020

trying to reproduce the above steps I can neither rename, nor delete, nor upload a new file (or folder). I do see ui glitches like no error popping up and a refresh when the file upload fails ... but acls are enforced.

enforcing ACLs on owncloud and ocis storage drivers needs to be implemented.

@butonic butonic changed the title [QA] Viewer can modify shared folder [QA] Viewer can modify shared folder on owncloud and ocis driver Sep 18, 2020
@LukasHirt
Copy link
Collaborator

also the ui just sits there, the dialog does not close and no error pops up ... maybe because of the 500 error ... @LukasHirt maybe?

Seems we're missing hide dialogue logic in case of errors - https://github.com/owncloud/phoenix/blob/fcbfd6346cfed4c45edc0b1b1813de60fcdde86c/apps/files/src/mixins/deleteResources.js#L150

@jnweiger
Copy link
Author

@LukasHirt This was marked a release blocker in RC1, any updates here?

@LukasHirt
Copy link
Collaborator

LukasHirt commented Oct 30, 2020 •
edited
Loading

This was marked a release blocker in RC1, any updates here?

@jnweiger The UI part hasn't been touched. I am not sure about the enforcing of ACLs though

@jnweiger
Copy link
Author

Thanks. I'll retest with RC2

@jnweiger
Copy link
Author

Retested in RC3. Fixed. Thanks!
I succeeded twice to make (as share receiver) the shared folder unaccessible for the sharer --
Will try to find a clear reproducer and post a followup :-)

@jnweiger
Copy link
Author

follow up: owncloud/ocis#875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p3-medium qa Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@PVince81 @butonic @jnweiger @pmaier1 @LukasHirt