Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The webfinger service needs an update to get it completed #5557

Closed
mmattel opened this issue Feb 13, 2023 · 0 comments · Fixed by #5560
Closed

The webfinger service needs an update to get it completed #5557

mmattel opened this issue Feb 13, 2023 · 0 comments · Fixed by #5560
Assignees
Labels

Comments

@mmattel
Copy link
Contributor

mmattel commented Feb 13, 2023

Creating an issue as the webfinger services was already merged, seen too late, also see the issue comment

I strongly believe that we need additional entries in:
(I stumbled across this as we needed to add that for the postprocessing service too)

  • ocis-pkg/config/config.go already in
  • makefile-OCIS_MODULES
  • The default value of the envvar OCIS_URL / WEBFINGER_OWNCLOUD_SERVER_INSTANCE_URL is empty but should be https://localhost:9200 (ocis_url has that as default value). The description text tells: It defaults to the OCIS_URL but can be overridden to support some reverse proxy corner cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants