Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The branches docs-stable-x.0 have no protection rules #5299

Closed
mmattel opened this issue Dec 28, 2022 · 8 comments
Closed

The branches docs-stable-x.0 have no protection rules #5299

mmattel opened this issue Dec 28, 2022 · 8 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Dec 28, 2022

There are no protection rules for the docs-stable-x.0 branches.
I identified this as we had to add a file that is relevant for that branch but was added post the branch was created.

@micbar is this intended that you just can merge a PR without any review in that branch?

Also see the issue: #5298 where codacy complains about not being "setup"...

@stale
Copy link

stale bot commented Mar 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Mar 6, 2023
@mmattel
Copy link
Contributor Author

mmattel commented Mar 7, 2023

keep open

@stale stale bot removed the Status:Stale label Mar 7, 2023
@stale
Copy link

stale bot commented May 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label May 8, 2023
@mmattel
Copy link
Contributor Author

mmattel commented May 9, 2023

keep alive

@stale stale bot removed the Status:Stale label May 9, 2023
@mmattel mmattel changed the title The branch docs-stable-2.0 has no protection rules The branches docs-stable-x.0 have no protection rules Jun 16, 2023
@mmattel
Copy link
Contributor Author

mmattel commented Jul 19, 2023

Doc Board Meeting
@micbar if this is no longer an issue, we can close this and set it to wont-fix

@mmattel
Copy link
Contributor Author

mmattel commented Aug 30, 2023

Important info:

  • docs-stable-x gets daily "resetted" by the CI based on content from the source stable-x, or on merge in stable-x. Means that any info falsly or whyever committed into docs-stable-x gets reverted back to the original state.
  • The question now is, do/can we protect against any manual changes not coming from stable-x.
  • If not, we have to be aware that there is the possibility for "bogus" content for max 24h and we can close the issue.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Dec 15, 2023
@micbar
Copy link
Contributor

micbar commented May 29, 2024

No harm was done. Closing.

@micbar micbar closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants