Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCIS] Rework ocis-reva commands and env vars #216

Open
PVince81 opened this issue Aug 26, 2020 · 5 comments
Open

[OCIS] Rework ocis-reva commands and env vars #216

PVince81 opened this issue Aug 26, 2020 · 5 comments

Comments

@PVince81
Copy link

PVince81 commented Aug 26, 2020

There is a difference between storage provider and storage driver, but the environment variable names are all mixed up and cause great confusion.

For ocis all we want to do with ocis-reva server is to start reva in a configuration that brings up reva services that use a specific driver. Either eos or ocis.

We should implement ocis-reva server to start multiplve services using pman. We need at least three storageproviders, one mounted at /home, one mounted at /users, one mounted at /meta or /sys for eg the accounts service.

We should also rename the env variables, maybe include "EOS_DRIVER" and "EOS PROVIDER" in the new names.

The confusion greatly increases the probability of human error due to misunderstanding and slows debugging efforts (already happened before)

@PVince81
Copy link
Author

PVince81 commented Sep 9, 2020

as discussed with @butonic, we should reduce the env vars and configurations to only two:

  • /home mount (REVA_HOME_xxx)
  • /root mount (REVA_ROOT_xxx)

because the current configuration is extremely confusing. The REVA_XXX_* variables are referring to the matching mount point, so REVA_EOS_* are for the "/eos" mount point while REVA_OC_* is for "/oc" and can use any driver. One could use the eos driver for "/oc".

the simplification in two would make it clearer what drivers to be used.
and even here, it is likely that one should only ever pick a single driver for both "home" and "root"...

@PVince81
Copy link
Author

PVince81 commented Sep 9, 2020

let's introduce REVA_DRIVER_* variables for configuring the drivers themselves

@PVince81 PVince81 changed the title Reword configuration and env names for storages [OCIS] Reword configuration and env names for storages Sep 9, 2020
@PVince81 PVince81 transferred this issue from owncloud/ocis Sep 9, 2020
@PVince81 PVince81 changed the title [OCIS] Reword configuration and env names for storages [OCIS] Rework configuration and env names for storages Sep 9, 2020
@PVince81
Copy link
Author

PVince81 commented Sep 9, 2020

when spaces are introduced, we could have an additional mount:

  • /spaces/users with a non home enabled config

that would likely be REVA_STORAGE_SPACES_xxx with its own driver

@PVince81
Copy link
Author

we might also want to get rid of those extra services and only have a "storage" and "storage-data" service, and have a driver or mount point attached to it, and the ability to start multiple ones in parallel

@exalate-issue-sync
Copy link

Jörn Friedrich Dreyer commented: ocis-reva has the different storage * commands because we wanted to be able to preconfigure the different drivers so that you could switch from eg owncloud to eos by using a different storage provider. I think it makes more sense to start with three storage commands: home, users and meta (which ineumann is using to store account metadata)

the home an users storage only differ in the home enabled flag .... hm or should we combine that as well ... so there would be a single commant to start an eos-reva vs an oc-reva ... let me check if we can run start storage providers with a single reva config ...
not possible arararrrrrrrr
:tableflip:
ok, but we could implement a command that just starts two reva instances ...
ok that would drastically change the number of commands. to two: ocis-reva server with a --driver option, defaulting to ocis switching it to eos however would start two storage providers (at /home and /users) with eos configured.
I like this, but I guess I am overlooking something.

@exalate-issue-sync exalate-issue-sync bot changed the title [OCIS] Rework configuration and env names for storages [OCIS] Rework ocis-reva Sep 14, 2020
@exalate-issue-sync exalate-issue-sync bot changed the title [OCIS] Rework ocis-reva [OCIS] Rework ocis-reva commands and env vars Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant