-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCIS] Rework ocis-reva commands and env vars #216
Comments
as discussed with @butonic, we should reduce the env vars and configurations to only two:
because the current configuration is extremely confusing. The REVA_XXX_* variables are referring to the matching mount point, so REVA_EOS_* are for the "/eos" mount point while REVA_OC_* is for "/oc" and can use any driver. One could use the eos driver for "/oc". the simplification in two would make it clearer what drivers to be used. |
let's introduce REVA_DRIVER_* variables for configuring the drivers themselves |
when spaces are introduced, we could have an additional mount:
that would likely be REVA_STORAGE_SPACES_xxx with its own driver |
we might also want to get rid of those extra services and only have a "storage" and "storage-data" service, and have a driver or mount point attached to it, and the ability to start multiple ones in parallel |
Jörn Friedrich Dreyer commented: ocis-reva has the different storage * commands because we wanted to be able to preconfigure the different drivers so that you could switch from eg owncloud to eos by using a different storage provider. I think it makes more sense to start with three storage commands: home, users and meta (which ineumann is using to store account metadata) the home an users storage only differ in the home enabled flag .... hm or should we combine that as well ... so there would be a single commant to start an eos-reva vs an oc-reva ... let me check if we can run start storage providers with a single reva config ... |
There is a difference between storage provider and storage driver, but the environment variable names are all mixed up and cause great confusion.
For ocis all we want to do with
ocis-reva server
is to start reva in a configuration that brings up reva services that use a specific driver. Either eos or ocis.We should implement
ocis-reva server
to start multiplve services using pman. We need at least three storageproviders, one mounted at/home
, one mounted at/users
, one mounted at/meta
or/sys
for eg the accounts service.We should also rename the env variables, maybe include "EOS_DRIVER" and "EOS PROVIDER" in the new names.
The confusion greatly increases the probability of human error due to misunderstanding and slows debugging efforts (already happened before)
The text was updated successfully, but these errors were encountered: