Connection closed while TUS makes the client stuck

[michaelstingl]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

Connection closed during TUS-uploads make the desktop client stuck.

Expected behavior

Clients should recover automatically.

Steps to reproduce the issue

Upload plenty of files to ocis.team.owncloud.works, so it hits the 5-Minute token renewal.

Screenshots

Logs

08-11 13:16:27:144 [ info sync.propagator ]:	Starting SyncInstruction(CSYNC_INSTRUCTION_NEW) propagation of "Example Files/DSLR Photos/DSC_1062.JPG" by OCC::PropagateUploadFileTUS(0x600000f0ccf0)
08-11 13:16:27:144 [ info sync.checksums ]:	Computing "SHA1" checksum of "/Users/michaelstingl/testpilotcloud/Personal/Example Files/DSLR Photos/DSC_1062.JPG" in a thread
08-11 13:16:27:191 [ info sync.checksums ]:	Computing "SHA1" checksum of "/Users/michaelstingl/testpilotcloud/Personal/Example Files/DSLR Photos/DSC_1062.JPG" in a thread
08-11 13:16:27:221 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::startNextChunk ]:	Starting creation with upload: "/Example Files/DSLR Photos/DSC_1062.JPG"
08-11 13:16:27:221 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::makeCreationWithUploadJob ]:	FullPath: "/Example Files/DSLR Photos/DSC_1062.JPG"
08-11 13:16:27:221 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::startNextChunk ]:	Offset: 0 0 Chunk: 6997791 0
08-11 13:16:27:221 [ info sync.httplogger ]:	"789c4fee-0dd4-4c97-ba47-3b2c655d12c8: Request: POST https://ocis.team.owncloud.works/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157$6b6253d5-cea6-4533-bd59-a34d160ffd24 Header: { X-OC-Mtime: 1591010792, Content-Type: application/offset+octet-stream, Content-Length: 6997791, Upload-Offset: 0, Tus-Resumable: 1.0.0, Upload-Metadata: filename L0V4YW1wbGUgRmlsZXMvRFNMUiBQaG90b3MvRFNDXzEwNjIuSlBH,checksum U0hBMSBiZTNkMjkyNzAxNjc1Yjg0NWM1YzRjMTE5YjNmNTM0ZGRkNDUyOGMy, Upload-Length: 6997791, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/3.0.0.8306-daily20220811 (testpilotcloud, osx-21.6.0 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, X-Request-ID: 789c4fee-0dd4-4c97-ba47-3b2c655d12c8, Original-Request-ID: 789c4fee-0dd4-4c97-ba47-3b2c655d12c8, } Data: [6997791 bytes of application/offset+octet-stream data]"
08-11 13:16:27:221 [ info sync.networkjob ]:	Created OCC::SimpleNetworkJob("https://ocis.team.owncloud.works/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157$6b6253d5-cea6-4533-bd59-a34d160ffd24","POST", "789c4fee-0dd4-4c97-ba47-3b2c655d12c8", "789c4fee-0dd4-4c97-ba47-3b2c655d12c8") for OCC::PropagateUploadFileTUS(0x600000f0ccf0)
08-11 13:16:27:394 [ info sync.httplogger ]:	"789c4fee-0dd4-4c97-ba47-3b2c655d12c8: Response: POST 0 (Error: Connection closed,) https://ocis.team.owncloud.works/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157$6b6253d5-cea6-4533-bd59-a34d160ffd24 Header: { } Data: []"
08-11 13:16:27:394 [ warning sync.networkjob ]:	OCC::SimpleNetworkJob("https://ocis.team.owncloud.works/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157$6b6253d5-cea6-4533-bd59-a34d160ffd24","POST", "789c4fee-0dd4-4c97-ba47-3b2c655d12c8", "789c4fee-0dd4-4c97-ba47-3b2c655d12c8", "Connection closed") QNetworkReply::RemoteHostClosedError "Connection closed" 0
08-11 13:16:27:395 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::slotChunkFinished ]:	"/Example Files/DSLR Photos/DSC_1062.JPG" "POST"
08-11 13:16:27:395 [ critical default ]:	ASSERT: "!_responseTimestamp.isEmpty() || _aborted" in file /private/var/folders/s_/29j5jn_972502zl0mp1m6n9h0000gn/T/drone-kMx271qJ0BOQDvI2/drone/src/src/macos-64-clang/testpilotcloud-3.0.0-daily20220811.8306/src/libsync/abstractnetworkjob.cpp, line 230 QByteArray OCC::AbstractNetworkJob::responseTimestamp()
08-11 13:16:27:395 [ debug sync.propagator.upload ]	[ OCC::PropagateUploadFileCommon::commonErrorHandling ]:	""
08-11 13:16:27:395 [ warning sync.propagator.upload ]:	void OCC::PropagateUploadFileCommon::abortWithError(SyncFileItem::Status, const QString &) "Example Files/DSLR Photos/DSC_1062.JPG" "Connection closed"
08-11 13:16:27:395 [ info sync.database ]:	Setting blacklist entry for "Example Files/DSLR Photos/DSC_1062.JPG" 1 "Connection closed" 1660216587 25 1591010792 "" "" OCC::SyncJournalErrorBlacklistRecord::Category::Normal
08-11 13:16:27:395 [ info sync.propagator ]:	blacklisting  "Example Files/DSLR Photos/DSC_1062.JPG"  for  25 , retry count  1
08-11 13:16:27:396 [ warning sync.propagator ]:	Could not complete propagation of "Example Files/DSLR Photos/DSC_1062.JPG" by OCC::PropagateUploadFileTUS(0x600000f0ccf0) with status OCC::SyncFileItem::NormalError and error: "Connection closed"
08-11 13:16:27:397 [ debug sync.statustracker ]	[ OCC::SyncFileStatusTracker::slotItemCompleted ]:	Item completed "Example Files/DSLR Photos/DSC_1062.JPG" OCC::SyncFileItem::NormalError SyncInstruction(CSYNC_INSTRUCTION_NEW)
08-11 13:16:27:398 [ debug sync.localdiscoverytracker ]	[ OCC::LocalDiscoveryTracker::slotItemCompleted ]:	inserted error item "Example Files/DSLR Photos/DSC_1062.JPG"

Full logs here:

• https://cloud.owncloud.com/index.php/f/5861437

Client version number

testpilotcloud 3.0.0.8306-daily20220811 e81c9b Aug 11 2022 02:10:42
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: suffix
osx-21.6.0

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

ocis.team.owncloud.works

Additional context

"Restart sync" helps to upload the files again.

[dragotin]

Bumped prio to one b'cause this needs attention ASAP because of vacation dependencies.

[C0rby]

This will be resolved once we merge #4374

[TheOneRing]

Closing as #4374 was merged