You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// TODO: This is a hack for now.// Can we do that cleaner somehow?// The `ListStorageSpaces` method in sharesstorageprovider/sharesstorageprovider.go needs the etags.shareMetaData:=make(map[string]share.Metadata, len(res.Shares))
for_, rs:=rangeres.Shares {
// Stat .. here, only for etag and mtime? and then we throw the rest away?sRes, err:=s.Stat(ctx, &provider.StatRequest{Ref: &provider.Reference{ResourceId: rs.Share.ResourceId}})
iferr!=nil {
logger.Error().
Err(err).
Interface("resourceID", rs.Share.ResourceId).
Msg("ListRecievedShares: failed to stat the resource")
continue
}
ifsRes.Status.Code!=rpc.Code_CODE_OK {
logger.Error().
Interface("resourceID", rs.Share.ResourceId).
Msg("ListRecievedShares: failed to stat the resource")
continue
}
shareMetaData[rs.Share.Id.OpaqueId] = share.Metadata{ETag: sRes.Info.Etag, Mtime: sRes.Info.Mtime}
}
The sharesstorageproevider not only needs the etag and mtime. It may need a full stat response to build the virtual share jail #3719
The sharesstorageprovider should make the stat requests itself. PR in cs3org/reva#2885
And it can omit that for unmounted shares ... which brings us to the next issue...
cannot filter by un/accepted shares
When listing mountpoints unaccepted shares can be omitted. The CS3 API needs a filter to allow filtering.
tracked in #3843
The text was updated successfully, but these errors were encountered:
stats every shared resource
The sharesstorageproevider not only needs the etag and mtime. It may need a full stat response to build the virtual share jail #3719
The sharesstorageprovider should make the stat requests itself. PR in cs3org/reva#2885
And it can omit that for unmounted shares ... which brings us to the next issue...
cannot filter by un/accepted shares
When listing mountpoints unaccepted shares can be omitted. The CS3 API needs a filter to allow filtering.
tracked in #3843
The text was updated successfully, but these errors were encountered: