Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve users/groups graph api endpoint #3837

Closed
AlexAndBear opened this issue May 19, 2022 · 6 comments
Closed

Improve users/groups graph api endpoint #3837

AlexAndBear opened this issue May 19, 2022 · 6 comments
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@AlexAndBear
Copy link
Contributor

AlexAndBear commented May 19, 2022

To build up a performant user management with user and group assignments it is necessary to improve the graph API:

  1. /graph/v1.0/users/ endpoint should include a field where assigned groups are listed (maybe $expand is necessary)
  2. /graph/v1.0/users/{id}/ endpoint should include a field where assigned groups are listed (maybe $expand is necessary)
  3. /graph/v1.0/groups/ endpoint should include a field where assigned users are listed (maybe $expand is necessary)
  4. /graph/v1.0/groups/{id}/ endpoint should include a field where users are listed (maybe $expand is necessary)
  5. We need an endpoint to set the user's group with one request instead of adding and deleting group relations by single requests
  6. We need an endpoint to set the group's users with one request instead of adding and deleting user relations by single requests

5 & 6 extracted into it's own issue

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented May 19, 2022

FYI @butonic

Please NOTE: The API specification claims that point 1-4 is already possible, which is not the case. We SHOULD really not add things to our API specification which are not included yet, the specification should represent the current state AND NOT contain future improvements

@micbar micbar added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels May 20, 2022
@micbar
Copy link
Contributor

micbar commented May 20, 2022

let us treat it as a bug and fix it.

@dragonchaser dragonchaser self-assigned this May 24, 2022
@dragonchaser
Copy link
Contributor

@janackermann && @micbar 5 & 6 are not part of the spec (see https://docs.microsoft.com/en-us/graph/api/resources/user?view=graph-rest-1.0#relationships) do we want to implement outside of the spec?

@fschade
Copy link
Contributor

fschade commented Jun 14, 2022

i would say skip 5 & 6 for now, i'm really not happy to work around the spec atm.

@kulmann
Copy link
Member

kulmann commented Jun 14, 2022

I agree, 5 & 6 can be mitigated client side for the moment. 1-4 would be good to have.

@fschade
Copy link
Contributor

fschade commented Jun 14, 2022

@dragonchaser, point 5 & 6 is extracted into a separate issue to keep this rolling.

#3963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Archived in project
Development

No branches or pull requests

5 participants