Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REVA services have wrong name in traces #3815

Closed
wkloucek opened this issue May 17, 2022 · 1 comment
Closed

REVA services have wrong name in traces #3815

wkloucek opened this issue May 17, 2022 · 1 comment
Assignees
@rhafer
Labels
Priority:p3-medium Normal priority Type:Bug

Comments

@wkloucek
Copy link
Contributor

Describe the bug

REVA services have wrong names in traces:
image

This is because the tracing provider is stored at package level (and therefore our reva services overwrite their names => last one wins) https://github.com/cs3org/reva/blob/627d0d3f2cd15ebd359c010ce65013fdc778ba8b/pkg/trace/trace.go#L38-L39
@micbar micbar added the Priority:p3-medium Normal priority label May 19, 2022
@rhafer rhafer self-assigned this Jun 8, 2022
@rhafer
Copy link
Contributor

rhafer commented Jun 16, 2022

fixed via cs3org/reva#2962

@rhafer rhafer closed this as completed Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Priority:p3-medium Normal priority Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhafer @micbar @wkloucek