Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share jail: how to rename shares? #3721

Closed
kulmann opened this issue May 6, 2022 · 6 comments
Closed

Share jail: how to rename shares? #3721

kulmann opened this issue May 6, 2022 · 6 comments
Labels

Comments

@kulmann
Copy link
Member

kulmann commented May 6, 2022

Describe the bug

Before the share jail, renaming a share is a MOVE on the mountpoint in the personal home via webdav v2 personal home.
After the share jail, renaming a share would be a MOVE on a webdav root, i.e. dav/spaces/<share jail id>!<share id>. Which is kind of expected. But this brings up the question of how to rename a share per user. Is that forbidden in oCIS for now? Does it need an entirely new concept?

We've disabled renaming shares in the web ui for now when the share jail is enabled via capabilities. So this is not urgent, but still a regression.

@butonic
Copy link
Member

butonic commented May 19, 2022

cs3org/reva#2884 got merged. It should be possible to do a rename in the share jail.

@butonic
Copy link
Member

butonic commented May 19, 2022

@butonic
Copy link
Member

butonic commented May 19, 2022

I think we can drop the needs concept tag

@butonic
Copy link
Member

butonic commented May 20, 2022

stat and move requests need to handle more cases to make this possible. work is started with cs3org/reva#2886 but I'll go play with the parallel deployment now ...

@butonic
Copy link
Member

butonic commented May 31, 2022

should be fixed with cs3org/reva#2904, cs3org/reva#2886 was only a partial fix

@butonic
Copy link
Member

butonic commented Jun 10, 2022

With https://github.com/owncloud/ocis/releases/tag/v2.0.0-beta.3 the share jail can be used to rename a share mount point by sending a MOVE /dav/spaces/{sharejailid}/oldname with a Destination: .../dav/spaces/{sharejailid}/newname.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants