Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--config-file #3506

Closed
wkloucek opened this issue Apr 11, 2022 · 4 comments
Closed

--config-file #3506

wkloucek opened this issue Apr 11, 2022 · 4 comments

Comments

@wkloucek
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When starting an extension without runtime, I want to specify an exact config file.

Describe the solution you'd like

have a --config-file flag, eg. ocis proxy server --config-file /lorem/foo.bar

Describe alternatives you've considered

I could set some environment variables.

Additional context

Add any other context or screenshots about the feature request here.

CC @mmattel

@mmattel
Copy link
Contributor

mmattel commented Apr 19, 2022

Two points:

  • Maybe to do some renaming on top to make it more clear:
    When starting an extension without runtime --> When starting a killed runtime extension

  • Consider how to handle this command line option when using docker:
    When you are in the shell of the container, kill and restart (run) an extension, you must add this parameter as discussed, but the question raises - compared when using the plain binary - where is this file located physically - because we have the host (where it should be) and the container (where ist should not be)...
    I have already set an internal reminder in the admin docs that this needs documentation
    Maybe related: improve systemd docs and simplify config file arithmetics #3480

Adding @dragonchaser because we discussed this topic today in the morning.

@wkloucek
Copy link
Contributor Author

Two points:

  • Maybe to do some renaming on top to make it more clear:
    When starting an extension without runtime --> When starting a killed runtime extension

There is no runtime at all... Even no killed runtime or killed runtime extension.

ocis server => starts a runtime and all extensions
ocis start => starts an extension in an already running runtime. Fails if no runtime is available
ocis kill => stops an running extension in an already running runtime. Fails if no runtime is available

ocis <extension-name> server => starts the extension without runtime... There is no running runtime needed nor does it start a runtime.

  • Consider how to handle this command line option when using docker:
    When you are in the shell of the container, kill and restart (run) an extension, you must add this parameter as discussed, but the question raises - compared when using the plain binary - where is this file located physically - because we have the host (where it should be) and the container (where it should not be)...

I don't get the problem. You'll need to use volumes if you want to have the config file on your host disk and inside the container. If it's only on the host disk, you can't access it inside the container. But that's how containers work

@stale
Copy link

stale bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@wkloucek
Copy link
Contributor Author

wkloucek commented Jun 6, 2024

I personally no longer see a use case since the current configuration mechanisms seems to be working fine, too

@wkloucek wkloucek closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants