Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the space name in the OCS sharing API #3359

Closed
JammingBen opened this issue Mar 22, 2022 · 14 comments
Closed

Include the space name in the OCS sharing API #3359

JammingBen opened this issue Mar 22, 2022 · 14 comments

Comments

@JammingBen
Copy link
Contributor

Web needs the space name in the OCS sharing API in case of shared spaces (via link), as well as shared resources within a space. Otherwise we'd need to query the space for each share to get the space name.

Having the space name in regular PROPFIND requests would also be nice, but not a must for now.

Is this possible?

@C0rby @micbar fyi

@C0rby
Copy link
Contributor

C0rby commented Apr 4, 2022

Is the space name required for shared with other AND shared with me?

@C0rby
Copy link
Contributor

C0rby commented Apr 5, 2022

@JammingBen, see the question above. I already implemented this for shared with others but shared with me is a bit trickier.
Do we need that for both? If so I need to figure out a way to make it work.

@JammingBen
Copy link
Contributor Author

Sorry, totally forgot to answer. I'm afraid we need it for both cases.

@C0rby
Copy link
Contributor

C0rby commented Apr 5, 2022

No, worries. Ok, then more work is needed. 👍

@kulmann
Copy link
Member

kulmann commented Jun 10, 2022

@C0rby any update on this? 😅

@C0rby
Copy link
Contributor

C0rby commented Jun 13, 2022

No, I haven't been working on this. But maybe it also makes sense to wait on this until we have the static registry back in oCIS since this will kind of dictate the implementation of this.

@micbar micbar added the Priority:p3-medium Normal priority label Jun 14, 2022
@micbar
Copy link
Contributor

micbar commented Jul 4, 2022

@C0rby Could you please check again the feasibility?

@micbar
Copy link
Contributor

micbar commented Jul 4, 2022

@pmaier1 @tbsbdr Is this ok from a product POV? Do we leak information?

@C0rby
Copy link
Contributor

C0rby commented Jul 5, 2022

@C0rby Could you please check again the feasibility?

This is still not easily possible, AFAICT.

@stale
Copy link

stale bot commented Sep 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Sep 4, 2022
@stale stale bot closed this as completed Sep 15, 2022
@micbar
Copy link
Contributor

micbar commented Sep 16, 2022

re opening

@micbar micbar reopened this Sep 16, 2022
@stale
Copy link

stale bot commented Nov 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Nov 19, 2022
@stale stale bot closed this as completed Dec 3, 2022
@micbar
Copy link
Contributor

micbar commented Dec 6, 2022

still an issue

@micbar micbar reopened this Dec 6, 2022
@dragonchaser
Copy link
Contributor

According to @JammingBen not relevant atm, closing.

@github-project-automation github-project-automation bot moved this from Prio 3 or less to Done in Infinite Scale Team Board Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants