Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't edit office document on a public share with editor role #2803

Closed
Tracked by #2766
wkloucek opened this issue Nov 22, 2021 · 0 comments · Fixed by cs3org/reva#2310
Closed
Tracked by #2766

can't edit office document on a public share with editor role #2803

wkloucek opened this issue Nov 22, 2021 · 0 comments · Fixed by cs3org/reva#2310
Labels

Comments

@wkloucek
Copy link
Contributor

Describe the bug

As a public share receiver with editor role, I can't edit office documents.

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a public share with editor roles
  2. Place an office document in the public share
  3. Try to edit the office document

Expected behavior

The office document can be edited and saved.

Actual behavior

Depending on the office app, the open action will fail in different ways:

  • OnlyOffice fails hard with an error message
  • Collabora fails gracefully by falling back to ready only view

The oCIS log says:

ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","user-agent":"grpc-python/1.41.1 grpc-c/19.0.0 (linux; chttp2)","from":"tcp://172.19.0.5:47786","uri":"/cs3.gateway.v1beta1.GatewayAPI/SetArbitraryMetadata","start":"22/Nov/2021:09:22:22 +0000","end":"22/Nov/2021:09:22:22 +0000","time_ns":2345550,"code":"Unknown","time":"2021-11-22T09:22:22Z","message":"unary"}
ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","user-agent":"grpc-go/1.42.0","from":"tcp://127.0.0.1:33472","uri":"/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProviders","start":"22/Nov/2021:09:22:30 +0000","end":"22/Nov/2021:09:22:30 +0000","time_ns":4055195,"code":"PermissionDenied","time":"2021-11-22T09:22:30Z","message":"unary"}
ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","error":"gateway: error calling GetStorageProvider: rpc error: code = PermissionDenied desc = auth: core access token is invalid","time":"2021-11-22T09:22:30Z","caller":"/go/pkg/mod/github.com/cs3org/[email protected]/pkg/rgrpc/status/status.go:186","message":"gateway: error finding home: gateway: error calling GetStorageProvider: rpc error: code = PermissionDenied desc = auth: core access token is invalid"}
ocis_wopi-ocis-1  | {"level":"error","service":"proxy","error":"gateway: grpc failed with code CODE_PERMISSION_DENIED","time":"2021-11-22T09:22:30Z","message":"error when calling Createhome"}
ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","user-agent":"grpc-go/1.42.0","from":"tcp://127.0.0.1:33472","uri":"/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProviders","start":"22/Nov/2021:09:22:31 +0000","end":"22/Nov/2021:09:22:31 +0000","time_ns":5196821,"code":"PermissionDenied","time":"2021-11-22T09:22:31Z","message":"unary"}
ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","error":"gateway: error calling GetStorageProvider: rpc error: code = PermissionDenied desc = auth: core access token is invalid","time":"2021-11-22T09:22:31Z","caller":"/go/pkg/mod/github.com/cs3org/[email protected]/pkg/rgrpc/status/status.go:186","message":"gateway: error finding home: gateway: error calling GetStorageProvider: rpc error: code = PermissionDenied desc = auth: core access token is invalid"}
ocis_wopi-ocis-1  | {"level":"error","service":"proxy","error":"gateway: grpc failed with code CODE_PERMISSION_DENIED","time":"2021-11-22T09:22:31Z","message":"error when calling Createhome"}
ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","user-agent":"grpc-go/1.42.0","from":"tcp://127.0.0.1:58982","uri":"/cs3.storage.provider.v1beta1.ProviderAPI/SetArbitraryMetadata","start":"22/Nov/2021:09:22:31 +0000","end":"22/Nov/2021:09:22:31 +0000","time_ns":332654,"code":"Unimplemented","time":"2021-11-22T09:22:31Z","message":"unary"}
ocis_wopi-ocis-1  | {"level":"error","service":"storage","pkg":"rgrpc","traceid":"00000000000000000000000000000000","user-agent":"grpc-python/1.41.1 grpc-c/19.0.0 (linux; chttp2)","from":"tcp://172.19.0.5:47786","uri":"/cs3.gateway.v1beta1.GatewayAPI/SetArbitraryMetadata","start":"22/Nov/2021:09:22:31 +0000","end":"22/Nov/2021:09:22:31 +0000","time_ns":2446052,"code":"Unknown","time":"2021-11-22T09:22:31Z","message":"unary"}

Setup

oCIS with WOPI deployment example with oCIS 1.15.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant