Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trace disconnect #10692

Open
butonic opened this issue Nov 29, 2024 · 8 comments
Open

fix trace disconnect #10692

butonic opened this issue Nov 29, 2024 · 8 comments
Labels

Comments

@butonic
Copy link
Member

butonic commented Nov 29, 2024

when analyzing trace informatien we disconnect the context in upload.go:

func (store OcisStore) CreateNodeForUpload(session *OcisSession, initAttrs node.Attributes) (*node.Node, error) {
	ctx, span := tracer.Start(session.Context(context.Background()), "CreateNodeForUpload")

this leads to the trace information for an upload not showing what is going on in CreateNodeForUpload:
grafik

What happens in these 280ms?

traces produced with cs3org/reva#4978

@butonic
Copy link
Member Author

butonic commented Nov 29, 2024

well we can find out by searching jaeger for CreateNodeForUpload:
grafik

@butonic
Copy link
Member Author

butonic commented Nov 29, 2024

file operations are just slow:
grafik
CheckLock 137ms
InitNewNode 81ms
SetXAttrsWithContext 166ms which is mostly Read and WriteFile
Persist 70ms

that adds up to 470ms

@butonic
Copy link
Member Author

butonic commented Nov 29, 2024

more details:
grafik

grafik

requests seem to be faster right now 🤔

@butonic
Copy link
Member Author

butonic commented Dec 2, 2024

ok, with a 6min loadtast running, the io oparations become much slower:
grafik

@butonic
Copy link
Member Author

butonic commented Dec 2, 2024

TODO weird long ReadNode requests:
grafik

@butonic
Copy link
Member Author

butonic commented Dec 2, 2024

next bunch of requests that are slow are tagging requests:
grafik

@butonic
Copy link
Member Author

butonic commented Dec 2, 2024

it seems graph invite requests are slow:
grafik

need te add graph to the trace to see what is going on...

@butonic
Copy link
Member Author

butonic commented Dec 2, 2024

fetching the group takes a long time:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant