Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance test degradation #10545

Closed
ScharfViktor opened this issue Nov 12, 2024 · 4 comments · Fixed by #10557
Closed

Performance test degradation #10545

ScharfViktor opened this issue Nov 12, 2024 · 4 comments · Fixed by #10557
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@ScharfViktor
Copy link
Contributor

last 4 days we see some degradation in the nightly k6 testing. see here https://grafana.k6.infra.owncloud.works/

k6-test is red in CI because thresholds on metrics 'http_req_duration (rate<0.02), http_req_failed (p(95)<500ms)' have been crossed

example:

last green test was 6 days ago https://drone.owncloud.com/owncloud/ocis/40699/58/1

how to test:

  • create PR with [k6-test] in the title
  • see CI output
@ScharfViktor ScharfViktor added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels Nov 12, 2024
@ScharfViktor ScharfViktor moved this from Qualification to Prio 2 in Infinite Scale Team Board Nov 12, 2024
@kobergj
Copy link
Collaborator

kobergj commented Nov 12, 2024

Since last successful run was on 6th November at 1am the degradation must have happened on Nov 6th. Luckily there were not so many relevant PRs that day. It must be one of these:

Other PRs on that day only touch docs or unrelated systems.

#10476 adds 25 workers to the frontend service. Maybe that is somehow affecting request duration? Frontend service taking too much mem/cpu? THATS THE BADDY

#10481 bumps a grpc dependency. That could impact grpc request duration. But since we bumped it, it should be quicker if anything, shouldn't it? Tested - No impact on performance

#10494 bumps reva. But I don't see any changes in there that would affect performance. Just some cs3api bump.

There is also the possibility that the infrastructure changed. Where there any changes to it last week?

@kobergj kobergj self-assigned this Nov 12, 2024
@kobergj kobergj moved this from Prio 2 to In progress in Infinite Scale Team Board Nov 12, 2024
@ScharfViktor
Copy link
Contributor Author

There is also the possibility that the infrastructure changed. Where there any changes to it last week?

there have been no changes to the infrastructure in the last week.

@micbar
Copy link
Contributor

micbar commented Nov 12, 2024

Have there been some changes to the k6 tests?

@micbar micbar mentioned this issue Nov 12, 2024
85 tasks
@ScharfViktor
Copy link
Contributor Author

Have there been some changes to the k6 tests?

Nope, there was nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants