Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deployment][ocis-keycloak] Both old and new group names appear in OCIS web-UI after renaming the group name from keycloak #10445

Closed
Tracked by #10373
nabim777 opened this issue Oct 30, 2024 · 3 comments · Fixed by #10537
Labels

Comments

@nabim777
Copy link
Member

nabim777 commented Oct 30, 2024

Describe the bug

When a group is renamed from the Keycloak, both the old and new group names appear in the OCIS web UI, leading to confusion.

Steps to reproduce

NOTE:

  1. Here is using example deployment of ocis_keycloak link here
  2. User need to log in to sync the group.
  1. In keycloak, create a group named demo.
  2. In keycloak, add member einstein in the group demo.
  3. In keycloak, rename the group from demo to demo_rename.
  4. In OCIS-webUI, both old group name demo and new group name demo_rename will appear in the group list.

Expected behavior

Only the renamed group name demo_rename should be appeared in the OCIS web UI group list.

Actual behavior

Both the old group name demo and the new group name demo_rename appear in the OCIS web UI group list.

Tested on

OwnCloud Web UI 11.0.0
Infinite Scale 6.6.1

CC @rhafer @mmattel

@nabim777 nabim777 changed the title [deployment][ocis-keycloak] Both old and new group names appear in OCIS web-UI after renaming the group name in keycloak [deployment][ocis-keycloak] Both old and new group names appear in OCIS web-UI after renaming the group name from keycloak Oct 30, 2024
@nabim777 nabim777 mentioned this issue Oct 30, 2024
87 tasks
@rhafer rhafer moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Oct 30, 2024
@rhafer
Copy link
Contributor

rhafer commented Oct 30, 2024

Hm, I fear there is not much we can do here apart from documenting the behavior. The only thing we get from the IDP is a list of group memberships for the specific user that is logging in (via the user's claims). There is no way to figure out if one of the groups was renamed or if the user was just moved into a different group and the old group does still exist.

I guess the best we can do here is to document the current behavior in the README.

@mmattel
Copy link
Contributor

mmattel commented Oct 30, 2024

@nabim777 just discussed with @rhafer.
Keycloak has no events procatively sending changes. Which means, that when a users has a change like being assigned to a group or group renaming, this can only be recognized by ocis when the user logges out and relogs in. Then the updated claims are sent and ocis can process them.

This belongs to the proxy service, I will add a note about this asap both in the dev as well in the admin docs.

@nabim777
Copy link
Member Author

nabim777 commented Oct 31, 2024

@rhafer @mmattel Thank you for clarifying! Documenting the current behavior seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants