Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] Add X-Request-ID to the metadata #1022

Closed
michaelstingl opened this issue Dec 4, 2020 · 6 comments
Closed

[Jaeger] Add X-Request-ID to the metadata #1022

michaelstingl opened this issue Dec 4, 2020 · 6 comments
Labels
Category:Enhancement Add new functionality OCIS-Fastlane Planned outside of the sprint Priority:p3-medium Normal priority Status:Completed

Comments

@michaelstingl
Copy link
Contributor

All ownCloud (desktop-/mobile-/web-)clients already send X-Request-ID HTTP header with every request. They're shown in the client logfiles, and in the beginning of every line of the owncloud.log. They can also be easily added to the Apache log and to the logs from various middleware.

As far as I know, they're not really used from oCIS yet. (maybe in the logs?)

A beginning could be, to add the X-Request-ID HTTP header to the Jaeger metadata…

CleanShot 2020-12-04 at 11 01 49

In the future, clients could also support opentelemetry.io:

@C0rby @micbar @dragotin

@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@micbar
Copy link
Contributor

micbar commented Jun 7, 2021

still needed. will become hot when the first real use of ocis is approaching.

@stale
Copy link

stale bot commented Aug 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Aug 9, 2021
@phil-davis
Copy link
Contributor

@butonic the API test suite is sending X-Request-Id nowadays.
Is the server logging it yet, when things go wrong?

@stale stale bot removed the Status:Stale label Aug 9, 2021
@stale
Copy link

stale bot commented Oct 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Oct 8, 2021
@stale stale bot closed this as completed Oct 18, 2021
@micbar
Copy link
Contributor

micbar commented Dec 13, 2022

The X-Request-ID was added to the first span and to all possible log output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality OCIS-Fastlane Planned outside of the sprint Priority:p3-medium Normal priority Status:Completed
Projects
None yet
Development

No branches or pull requests

4 participants