From e07a65af40df9330d6c73af26b77bc06bc623650 Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi Date: Thu, 11 Jan 2024 15:49:46 +0545 Subject: [PATCH] Address reviews Signed-off-by: Swikriti Tripathi --- .../acceptance/features/bootstrap/SharingNgContext.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/features/bootstrap/SharingNgContext.php b/tests/acceptance/features/bootstrap/SharingNgContext.php index c66a64a53e9..c5be113768c 100644 --- a/tests/acceptance/features/bootstrap/SharingNgContext.php +++ b/tests/acceptance/features/bootstrap/SharingNgContext.php @@ -352,12 +352,10 @@ public function removeSharePermissionOfAResource( $itemId = ($resourceType === 'folder') ? $this->spacesContext->getResourceId($sharer, $space, $resource) : $this->spacesContext->getFileId($sharer, $space, $resource); - $permId = null; - if ($shareType === 'link') { - $permId = $this->featureContext->shareNgGetLastCreatedLinkShareID(); - } else { - $permId = $this->featureContext->shareNgGetLastCreatedUserGroupShareID(); - } + + $permId = ($shareType === 'link') + ? $this->featureContext->shareNgGetLastCreatedLinkShareID() + : $this->featureContext->shareNgGetLastCreatedUserGroupShareID(); return GraphHelper::deleteSharePermission( $this->featureContext->getBaseUrl(),