From d113c5ab615e75592651cd7af1b62f87f59cc217 Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi Date: Thu, 27 Apr 2023 15:20:13 +0545 Subject: [PATCH] Refactor feature files to add correct description --- .../coreApiCapabilities/capabilities.feature | 5 ++- .../capabilitiesWithNormalUser.feature | 3 ++ .../coreApiFavorites/favorites.feature | 19 ++++---- .../favoritesSharingToShares.feature | 3 ++ .../features/coreApiMain/checksums.feature | 43 ++++++++++--------- .../features/coreApiMain/main.feature | 5 ++- .../features/coreApiMain/status.feature | 3 ++ ...eateShareResourceCaseSensitiveName.feature | 3 ++ .../createShareUniqueReceivedNames.feature | 7 ++- ...hareDefaultFolderForReceivedShares.feature | 5 ++- ...reateShareGroupAndUserWithSameName.feature | 3 ++ .../createShareReceivedInMultipleWays.feature | 29 +++++++------ .../createShareWithDisabledUser.feature | 7 ++- .../createShareWithInvalidPermissions.feature | 13 +++--- .../createShareToSharesFolder.feature | 39 +++++++++-------- .../deleteShareFromShares.feature | 9 ++-- .../features/coreApiSharees/sharees.feature | 27 ++++++------ 17 files changed, 137 insertions(+), 86 deletions(-) diff --git a/tests/acceptance/features/coreApiCapabilities/capabilities.feature b/tests/acceptance/features/coreApiCapabilities/capabilities.feature index b0d3c8cfd83..1c895f22ea5 100644 --- a/tests/acceptance/features/coreApiCapabilities/capabilities.feature +++ b/tests/acceptance/features/coreApiCapabilities/capabilities.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: capabilities + As an admin + I want to list the capabilities + So that I can know what capabilities are available Background: Given using OCS API version "1" @@ -210,7 +213,7 @@ Feature: capabilities """ @smokeTest - Scenario: getting default capabilities with admin user + Scenario: getting default capabilities with version string with admin user When the administrator retrieves the capabilities using the capabilities API Then the ocs JSON data of the response should match """ diff --git a/tests/acceptance/features/coreApiCapabilities/capabilitiesWithNormalUser.feature b/tests/acceptance/features/coreApiCapabilities/capabilitiesWithNormalUser.feature index 80c6d7ba0b4..7d76993b3c3 100644 --- a/tests/acceptance/features/coreApiCapabilities/capabilitiesWithNormalUser.feature +++ b/tests/acceptance/features/coreApiCapabilities/capabilitiesWithNormalUser.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: default capabilities for normal user + As a user + I want to list capabilities + So that I can make sure what capabilities are available to me Background: Given using OCS API version "1" diff --git a/tests/acceptance/features/coreApiFavorites/favorites.feature b/tests/acceptance/features/coreApiFavorites/favorites.feature index bd3782a63d0..d3cc913da3e 100644 --- a/tests/acceptance/features/coreApiFavorites/favorites.feature +++ b/tests/acceptance/features/coreApiFavorites/favorites.feature @@ -1,5 +1,8 @@ @api Feature: favorite + As a user + I want to favorite resources + So that I can access them quickly Background: Given using OCS API version "1" @@ -14,7 +17,7 @@ Feature: favorite And user "Alice" has uploaded file with content "some data" to "/PARENT/parent.txt" @issue-1263 - Scenario Outline: Favorite a folder + Scenario Outline: favorite a folder Given using DAV path When user "Alice" favorites element "/FOLDER" using the WebDAV API Then the HTTP status code should be "207" @@ -35,7 +38,7 @@ Feature: favorite | spaces | @issue-1263 - Scenario Outline: Unfavorite a folder + Scenario Outline: unfavorite a folder Given using DAV path And user "Alice" has favorited element "/FOLDER" When user "Alice" unfavorites element "/FOLDER" using the WebDAV API @@ -57,7 +60,7 @@ Feature: favorite | spaces | @smokeTest @issue-1263 - Scenario Outline: Favorite a file + Scenario Outline: favorite a file Given using DAV path When user "Alice" favorites element "/textfile0.txt" using the WebDAV API Then the HTTP status code should be "207" @@ -78,7 +81,7 @@ Feature: favorite | spaces | @smokeTest @issue-1263 - Scenario Outline: Unfavorite a file + Scenario Outline: unfavorite a file Given using DAV path And user "Alice" has favorited element "/textfile0.txt" When user "Alice" unfavorites element "/textfile0.txt" using the WebDAV API @@ -100,7 +103,7 @@ Feature: favorite | spaces | @smokeTest - Scenario Outline: Get favorited elements of a folder + Scenario Outline: get favorited elements of a folder Given using DAV path When user "Alice" favorites element "/FOLDER" using the WebDAV API And user "Alice" favorites element "/textfile0.txt" using the WebDAV API @@ -121,7 +124,7 @@ Feature: favorite | spaces | - Scenario Outline: Get favorited elements of a subfolder + Scenario Outline: get favorited elements of a subfolder Given using DAV path And user "Alice" has created folder "/subfolder" And user "Alice" has uploaded file with content "some data" to "/subfolder/textfile0.txt" @@ -148,7 +151,7 @@ Feature: favorite | spaces | - Scenario Outline: Get favorited elements and limit count of entries + Scenario Outline: get favorited elements and limit count of entries Given using DAV path And user "Alice" has favorited element "/textfile0.txt" And user "Alice" has favorited element "/textfile1.txt" @@ -173,7 +176,7 @@ Feature: favorite | spaces | - Scenario Outline: Get favorited elements paginated in subfolder + Scenario Outline: get favorited elements paginated in subfolder Given using DAV path And user "Alice" has created folder "/subfolder" And user "Alice" has copied file "/textfile0.txt" to "/subfolder/textfile0.txt" diff --git a/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature b/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature index 8668c4c5117..67504e83e19 100644 --- a/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature +++ b/tests/acceptance/features/coreApiFavorites/favoritesSharingToShares.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: favorite + As a user + I want to favorite the shared resources + So that I can access them quickly Background: Given auto-accept shares has been disabled diff --git a/tests/acceptance/features/coreApiMain/checksums.feature b/tests/acceptance/features/coreApiMain/checksums.feature index c17d6ccfd8e..a0324d5a755 100644 --- a/tests/acceptance/features/coreApiMain/checksums.feature +++ b/tests/acceptance/features/coreApiMain/checksums.feature @@ -1,10 +1,13 @@ @api Feature: checksums + As a user + I want to upload files with checksum + So that I can make sure that the files are uploaded with correct checksums Background: Given user "Alice" has been created with default attributes and without skeleton files - Scenario Outline: Uploading a file with checksum should work + Scenario Outline: uploading a file with checksum should work Given using DAV path When user "Alice" uploads file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" using the WebDAV API Then the HTTP status code should be "201" @@ -19,7 +22,7 @@ Feature: checksums | spaces | @smokeTest @issue-1291 - Scenario Outline: Uploading a file with checksum should return the checksum in the propfind + Scenario Outline: uploading a file with checksum should return the checksum in the propfind Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" When user "Alice" requests the checksum of "/myChecksumFile.txt" via propfind @@ -35,7 +38,7 @@ Feature: checksums | spaces | @smokeTest @issue-1316 - Scenario Outline: Uploading a file with checksum should return the checksum in the download header + Scenario Outline: uploading a file with checksum should return the checksum in the download header Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" When user "Alice" downloads file "/myChecksumFile.txt" using the WebDAV API @@ -52,7 +55,7 @@ Feature: checksums | spaces | @issue-1291 - Scenario Outline: Moving a file with checksum should return the checksum in the propfind + Scenario Outline: moving a file with checksum should return the checksum in the propfind Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" When user "Alice" moves file "/myChecksumFile.txt" to "/myMovedChecksumFile.txt" using the WebDAV API @@ -69,7 +72,7 @@ Feature: checksums | spaces | @issue-1316 - Scenario Outline: Downloading a file with checksum should return the checksum in the download header + Scenario Outline: downloading a file with checksum should return the checksum in the download header Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" And user "Alice" has moved file "/myChecksumFile.txt" to "/myMovedChecksumFile.txt" @@ -87,7 +90,7 @@ Feature: checksums | spaces | @issue-1291 - Scenario Outline: Uploading a chunked file with checksum should return the checksum in the propfind + Scenario Outline: uploading a chunked file with checksum should return the checksum in the propfind Given using DAV path And user "Alice" has uploaded chunk file "1" of "3" with "AAAAA" to "/myChecksumFile.txt" with checksum "MD5:45a72715acdd5019c5be30bdbb75233e" And user "Alice" has uploaded chunk file "2" of "3" with "BBBBB" to "/myChecksumFile.txt" with checksum "MD5:45a72715acdd5019c5be30bdbb75233e" @@ -105,7 +108,7 @@ Feature: checksums | spaces | @issue-1343 - Scenario Outline: Uploading a chunked file with checksum should return the checksum in the download header + Scenario Outline: uploading a chunked file with checksum should return the checksum in the download header Given using DAV path And user "Alice" has uploaded chunk file "1" of "3" with "AAAAA" to "/myChecksumFile.txt" with checksum "MD5:45a72715acdd5019c5be30bdbb75233e" And user "Alice" has uploaded chunk file "2" of "3" with "BBBBB" to "/myChecksumFile.txt" with checksum "MD5:45a72715acdd5019c5be30bdbb75233e" @@ -123,7 +126,7 @@ Feature: checksums | spaces | - Scenario Outline: Moving file with checksum should return the checksum in the download header + Scenario Outline: moving file with checksum should return the checksum in the download header Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" When user "Alice" moves file "/myChecksumFile.txt" to "/myMovedChecksumFile.txt" using the WebDAV API @@ -141,7 +144,7 @@ Feature: checksums | spaces | @issue-1291 - Scenario Outline: Copying a file with checksum should return the checksum in the propfind using new DAV path + Scenario Outline: copying a file with checksum should return the checksum in the propfind using new DAV path Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" When user "Alice" copies file "/myChecksumFile.txt" to "/myChecksumFileCopy.txt" using the WebDAV API @@ -157,7 +160,7 @@ Feature: checksums | spaces | @issue-1316 - Scenario Outline: Copying file with checksum should return the checksum in the download header using new DAV path + Scenario Outline: copying file with checksum should return the checksum in the download header using new DAV path Given using DAV path And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/myChecksumFile.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" When user "Alice" copies file "/myChecksumFile.txt" to "/myChecksumFileCopy.txt" using the WebDAV API @@ -173,7 +176,7 @@ Feature: checksums | spaces | @files_sharing-app-required @issue-1291 - Scenario Outline: Sharing a file with checksum should return the checksum in the propfind using new DAV path + Scenario Outline: sharing a file with checksum should return the checksum in the propfind using new DAV path Given auto-accept shares has been disabled And using DAV path And user "Brian" has been created with default attributes and without skeleton files @@ -188,7 +191,7 @@ Feature: checksums | new | @files_sharing-app-required @issue-1291 @skipOnOcV10 - Scenario Outline: Modifying a shared file should return correct checksum in the propfind using new DAV path + Scenario Outline: modifying a shared file should return correct checksum in the propfind using new DAV path Given auto-accept shares has been disabled And using DAV path And user "Brian" has been created with default attributes and without skeleton files @@ -203,7 +206,7 @@ Feature: checksums | new | SHA1:ce5582148c6f0c1282335b87df5ed4be4b781399 MD5:56e57920c3c8c727bfe7a5288cdf61c4 ADLER32:1048035a | @issue-1315 - Scenario Outline: Upload a file where checksum does not match + Scenario Outline: upload a file where checksum does not match Given using DAV path When user "Alice" uploads file with checksum "SHA1:f005ba11" and content "Some Text" to "/chksumtst.txt" using the WebDAV API Then the HTTP status code should be "400" @@ -220,7 +223,7 @@ Feature: checksums | spaces | - Scenario Outline: Upload a file where checksum does match + Scenario Outline: upload a file where checksum does match Given using DAV path When user "Alice" uploads file with checksum "SHA1:ce5582148c6f0c1282335b87df5ed4be4b781399" and content "Some Text" to "/chksumtst.txt" using the WebDAV API Then the HTTP status code should be "201" @@ -235,7 +238,7 @@ Feature: checksums | spaces | @issue-1315 - Scenario Outline: Uploaded file should have the same checksum when downloaded + Scenario Outline: uploaded file should have the same checksum when downloaded Given using DAV path And user "Alice" has uploaded file with checksum "SHA1:ce5582148c6f0c1282335b87df5ed4be4b781399" and content "Some Text" to "/chksumtst.txt" When user "Alice" downloads file "/chksumtst.txt" using the WebDAV API @@ -255,7 +258,7 @@ Feature: checksums ## Validation Plugin or Old Endpoint Specific @issue-1343 - Scenario Outline: Uploading an old method chunked file with checksum should fail using new DAV path + Scenario Outline: uploading an old method chunked file with checksum should fail using new DAV path Given using DAV path When user "Alice" uploads chunk file "1" of "3" with "AAAAA" to "/myChecksumFile.txt" with checksum "MD5:45a72715acdd5019c5be30bdbb75233e" using the WebDAV API Then the HTTP status code should be "503" @@ -272,7 +275,7 @@ Feature: checksums ## upload overwriting @issue-1291 - Scenario Outline: Uploading a file with MD5 checksum overwriting an existing file + Scenario Outline: uploading a file with MD5 checksum overwriting an existing file Given using DAV path And user "Alice" has uploaded file with content "some data" to "textfile0.txt" When user "Alice" uploads file "filesForUpload/textfile.txt" to "/textfile0.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" using the WebDAV API @@ -295,7 +298,7 @@ Feature: checksums | spaces | @issue-1291 - Scenario Outline: Uploading a file with SHA1 checksum overwriting an existing file + Scenario Outline: uploading a file with SHA1 checksum overwriting an existing file Given using DAV path And user "Alice" has uploaded file with content "some data" to "textfile0.txt" When user "Alice" uploads file "filesForUpload/textfile.txt" to "/textfile0.txt" with checksum "SHA1:3ee962b839762adb0ad8ba6023a4690be478de6f" using the WebDAV API @@ -318,7 +321,7 @@ Feature: checksums | spaces | @skipOnStorage:ceph @skipOnStorage:scality @files_primary_s3-issue-224 @issue-1291 - Scenario Outline: Uploading a file with invalid SHA1 checksum overwriting an existing file + Scenario Outline: uploading a file with invalid SHA1 checksum overwriting an existing file Given using DAV path And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" When user "Alice" uploads file "filesForUpload/textfile.txt" to "/textfile0.txt" with checksum "SHA1:f005ba11f005ba11f005ba11f005ba11f005ba11" using the WebDAV API @@ -336,7 +339,7 @@ Feature: checksums | spaces | @issue-1296 - Scenario Outline: Uploading a file with checksum should work for file with special characters + Scenario Outline: uploading a file with checksum should work for file with special characters Given using DAV path When user "Alice" uploads file "filesForUpload/textfile.txt" to with checksum "MD5:d70b40f177b14b470d1756a3c12b963a" using the WebDAV API Then the HTTP status code should be "201" diff --git a/tests/acceptance/features/coreApiMain/main.feature b/tests/acceptance/features/coreApiMain/main.feature index 1f921ff3fe0..01192d41754 100644 --- a/tests/acceptance/features/coreApiMain/main.feature +++ b/tests/acceptance/features/coreApiMain/main.feature @@ -1,5 +1,8 @@ @api -Feature: Other tests related to api +Feature: get robots.txt + As a user + I want to get a file + So that I can check its content @issue-1314 Scenario: robots.txt file should be accessible diff --git a/tests/acceptance/features/coreApiMain/status.feature b/tests/acceptance/features/coreApiMain/status.feature index f24c8b9761c..275d05f3ed6 100644 --- a/tests/acceptance/features/coreApiMain/status.feature +++ b/tests/acceptance/features/coreApiMain/status.feature @@ -1,5 +1,8 @@ @api Feature: Status + As a admin + I want to check status of the server + So that I can ensure that the server is working @smokeTest Scenario: Status.php is correct diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareResourceCaseSensitiveName.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareResourceCaseSensitiveName.feature index 5da8ef760fe..ac6e6beccda 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareResourceCaseSensitiveName.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareResourceCaseSensitiveName.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: Sharing resources with different case names with the sharee and checking the coexistence of resources on sharee/receivers side + As a user + I want to share resources with case sensitive names + So that I can make sure that the shares aren't case sensitive Background: Given auto-accept shares has been disabled diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareUniqueReceivedNames.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareUniqueReceivedNames.feature index 7f2b8591d66..85a8f9004be 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareUniqueReceivedNames.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares1/createShareUniqueReceivedNames.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: resources shared with the same name are received with unique names + As a user + I want to share resources with same name + So that I can make sure the naming is handled properly by the server Background: Given auto-accept shares has been disabled @@ -21,5 +24,5 @@ Feature: resources shared with the same name are received with unique names Then the OCS status code of responses on all endpoints should be "100" And the HTTP status code of responses on all endpoints should be "200" And user "Carol" should see the following elements - | Shares/foo/ | - | /Shares/foo (1)/ | + | Shares/foo/ | + | /Shares/foo (1)/ | diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature index 3a63f14664f..3d2b7d2f47d 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature @@ -1,12 +1,15 @@ @api @files_sharing-app-required @issue-1327 Feature: shares are received in the default folder for received shares + As a user + I want to share the default Shares folder + So that I can make sure it does not work Background: Given auto-accept shares has been disabled And user "Alice" has been created with default attributes and without skeleton files - Scenario Outline: Do not allow sharing of the entire share_folder + Scenario Outline: do not allow sharing of the entire share folder Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "FOLDER" diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature index 3011ace85cf..61c348884c2 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareGroupAndUserWithSameName.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: sharing works when a username and group name are the same + As a user + I want to share resources with group and users having same name + So that I can make sure that the sharing works Background: Given auto-accept shares has been disabled diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature index d155e46437e..6f097e82aae 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: share resources where the sharee receives the share in multiple ways + As a user + I want to receives the same resource share from multiple channels + So that I can make sure that the sharing works Background: Given auto-accept shares has been disabled @@ -38,7 +41,7 @@ Feature: share resources where the sharee receives the share in multiple ways | 2 | 200 | /textfile0 (2).txt | @issue-1289 - Scenario Outline: Share of folder and sub-folder to same user + Scenario Outline: share of folder and sub-folder to same user Given using OCS API version "" And group "grp4" has been created And user "Brian" has been added to group "grp4" @@ -191,7 +194,7 @@ Feature: share resources where the sharee receives the share in multiple ways | 2 | 200 | - Scenario Outline: Sharing parent folder to user with all permissions and its child folder to group with read permission then check create operation + Scenario Outline: sharing parent folder to user with all permissions and its child folder to group with read permission then check create operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -225,7 +228,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to user with all permissions and its child folder to group with read permission then check rename operation + Scenario Outline: sharing parent folder to user with all permissions and its child folder to group with read permission then check rename operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -260,7 +263,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to user with all permissions and its child folder to group with read permission then check delete operation + Scenario Outline: sharing parent folder to user with all permissions and its child folder to group with read permission then check delete operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -295,7 +298,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to user with all permissions and its child folder to group with read permission then check reshare operation + Scenario Outline: sharing parent folder to user with all permissions and its child folder to group with read permission then check reshare operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -334,7 +337,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to group with read permission and its child folder to user with all permissions then check create operation + Scenario Outline: sharing parent folder to group with read permission and its child folder to user with all permissions then check create operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -369,7 +372,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to group with read permission and its child folder to user with all permissions then check rename operation + Scenario Outline: sharing parent folder to group with read permission and its child folder to user with all permissions then check rename operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -404,7 +407,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to group with read permission and its child folder to user with all permissions then check delete operation + Scenario Outline: sharing parent folder to group with read permission and its child folder to user with all permissions then check delete operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -439,7 +442,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to group with read permission and its child folder to user with all permissions then check reshare operation + Scenario Outline: sharing parent folder to group with read permission and its child folder to user with all permissions then check reshare operation Given group "grp1" has been created And user "Carol" has been created with default attributes and without skeleton files And user "Carol" has created the following folders @@ -474,7 +477,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Sharing parent folder to one group with all permissions and its child folder to another group with read permission + Scenario Outline: sharing parent folder to one group with all permissions and its child folder to another group with read permission Given these groups have been created: | groupname | | grp1 | @@ -519,7 +522,7 @@ Feature: share resources where the sharee receives the share in multiple ways | /child1 | - Scenario Outline: Share receiver renames the received group share and shares same folder through user share again + Scenario Outline: share receiver renames the received group share and shares same folder through user share again Given using OCS API version "" And group "grp" has been created And user "Brian" has been added to group "grp" @@ -550,7 +553,7 @@ Feature: share resources where the sharee receives the share in multiple ways | 2 | 200 | - Scenario Outline: Share receiver renames a group share and receives same resource through user share with additional permissions + Scenario Outline: share receiver renames a group share and receives same resource through user share with additional permissions Given using OCS API version "" And group "grp" has been created And user "Brian" has been added to group "grp" @@ -579,7 +582,7 @@ Feature: share resources where the sharee receives the share in multiple ways | 2 | - Scenario Outline: Share receiver renames a group share and receives same resource through user share with less permissions + Scenario Outline: share receiver renames a group share and receives same resource through user share with less permissions Given using OCS API version "" And group "grp" has been created And user "Brian" has been added to group "grp" diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithDisabledUser.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithDisabledUser.feature index e76258a5872..6b63881b6a7 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithDisabledUser.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithDisabledUser.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required @issue-1328 Feature: share resources with a disabled user + As a user + I want to share resources to disabled user + So that I can make sure it doesn't work Background: Given auto-accept shares has been disabled @@ -7,7 +10,7 @@ Feature: share resources with a disabled user And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt" @issue-2212 - Scenario Outline: Creating a new share with a disabled user + Scenario Outline: creating a new share with a disabled user Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has been disabled @@ -19,7 +22,7 @@ Feature: share resources with a disabled user | 1 | 997 | - Scenario: Creating a new share with a disabled user + Scenario: creating a new share with a disabled user Given using OCS API version "2" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has been disabled diff --git a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature index c737f6082b6..dc77eb22faf 100644 --- a/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature +++ b/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required Feature: cannot share resources with invalid permissions + As a user + I want to share resources with invalid permission + So that I can make sure it doesn't work Background: Given auto-accept shares has been disabled @@ -8,7 +11,7 @@ Feature: cannot share resources with invalid permissions And user "Alice" has created folder "/PARENT" - Scenario Outline: Cannot create a share of a file or folder with invalid permissions + Scenario Outline: cannot create a share of a file or folder with invalid permissions Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files When user "Alice" creates a share using the sharing API with settings @@ -33,7 +36,7 @@ Feature: cannot share resources with invalid permissions | 2 | 404 | 404 | PARENT | 32 | - Scenario Outline: Cannot create a share of a file with a user with only create permission + Scenario Outline: cannot create a share of a file with a user with only create permission Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files When user "Alice" creates a share using the sharing API with settings @@ -52,7 +55,7 @@ Feature: cannot share resources with invalid permissions | 2 | 400 | - Scenario Outline: Cannot create a share of a file with a user with only (create,delete) permission + Scenario Outline: cannot create a share of a file with a user with only (create,delete) permission Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files When user "Alice" creates a share using the sharing API with settings @@ -73,7 +76,7 @@ Feature: cannot share resources with invalid permissions | 2 | 400 | create,delete | - Scenario Outline: Cannot create a share of a file with a group with only create permission + Scenario Outline: cannot create a share of a file with a group with only create permission Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created @@ -94,7 +97,7 @@ Feature: cannot share resources with invalid permissions | 2 | 400 | - Scenario Outline: Cannot create a share of a file with a group with only (create,delete) permission + Scenario Outline: cannot create a share of a file with a group with only (create,delete) permission Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And group "grp1" has been created diff --git a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature index 8efb791bb20..6ae1f67455c 100644 --- a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature +++ b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature @@ -1,12 +1,15 @@ @api @files_sharing-app-required Feature: sharing + As a user + I want to share resources to others + So that they can have access on them Background: Given auto-accept shares has been disabled And user "Alice" has been created with default attributes and without skeleton files @smokeTest @skipOnEncryptionType:user-keys - Scenario Outline: Creating a share of a file with a user, the default permissions are read(1)+update(2)+can-share(16) + Scenario Outline: creating a share of a file with a user, the default permissions are read(1)+update(2)+can-share(16) Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" @@ -36,7 +39,7 @@ Feature: sharing | 2 | 200 | @smokeTest @skipOnEncryptionType:user-keys @issue-2133 - Scenario Outline: Creating a share of a file containing commas in the filename, with a user, the default permissions are read(1)+update(2)+can-share(16) + Scenario Outline: creating a share of a file containing commas in the filename, with a user, the default permissions are read(1)+update(2)+can-share(16) Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "file with comma in filename" to "/sample,1.txt" @@ -65,7 +68,7 @@ Feature: sharing | 2 | 200 | @issue-2133 @issue-1270 @issue-1271 - Scenario Outline: Creating a share of a file with a user and asking for various permission combinations + Scenario Outline: creating a share of a file with a user and asking for various permission combinations Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" @@ -100,7 +103,7 @@ Feature: sharing | 2 | 2 | 2 | 200 | - Scenario Outline: Creating a share of a file with no permissions should fail + Scenario Outline: creating a share of a file with no permissions should fail Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "Random data" to "randomfile.txt" @@ -116,7 +119,7 @@ Feature: sharing | 2 | 400 | - Scenario Outline: Creating a share of a folder with no permissions should fail + Scenario Outline: creating a share of a folder with no permissions should fail Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "/afolder" @@ -132,7 +135,7 @@ Feature: sharing | 2 | 400 | @issue-2133 - Scenario Outline: Creating a share of a folder with a user, the default permissions are all permissions(31) + Scenario Outline: creating a share of a folder with a user, the default permissions are all permissions(31) Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "/FOLDER" @@ -157,7 +160,7 @@ Feature: sharing | 2 | 200 | - Scenario Outline: Creating a share of a file with a group, the default permissions are read(1)+update(2)+can-share(16) + Scenario Outline: creating a share of a file with a group, the default permissions are read(1)+update(2)+can-share(16) Given using OCS API version "" And group "grp1" has been created And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" @@ -182,7 +185,7 @@ Feature: sharing | 2 | 200 | - Scenario Outline: Creating a share of a folder with a group, the default permissions are all permissions(31) + Scenario Outline: creating a share of a folder with a group, the default permissions are all permissions(31) Given using OCS API version "" And group "grp1" has been created And user "Alice" has created folder "/FOLDER" @@ -207,7 +210,7 @@ Feature: sharing | 2 | 200 | @smokeTest - Scenario Outline: Share of folder to a group + Scenario Outline: share of folder to a group Given using OCS API version "" And these users have been created with default attributes and without skeleton files: | username | @@ -235,7 +238,7 @@ Feature: sharing | 2 | 200 | @smokeTest @skipOnReva # reva doesn't have a pre-created admin user - Scenario Outline: User included in multiple groups receives a share from the admin + Scenario Outline: user included in multiple groups receives a share from the admin Given using OCS API version "" And group "grp1" has been created And group "grp2" has been created @@ -434,7 +437,7 @@ Feature: sharing And the content of file "/Shares/randomfile.txt" for user "Brian" should be "Random data" - Scenario Outline: Share of folder to a group with emoji in the name + Scenario Outline: share of folder to a group with emoji in the name Given using OCS API version "" And these users have been created with default attributes and without skeleton files: | username | @@ -529,7 +532,7 @@ Feature: sharing | 2 | 200 | /textfile0.txt | @skipOnFilesClassifier @issue-files-classifier-291 @issue-2146 - Scenario: Share a file by multiple channels and download from sub-folder and direct file share + Scenario: share a file by multiple channels and download from sub-folder and direct file share Given these users have been created with default attributes and without skeleton files: | username | | Brian | @@ -624,7 +627,7 @@ Feature: sharing | /userOneFolder | @smokeTest - Scenario Outline: Creating a share of a renamed file + Scenario Outline: creating a share of a renamed file Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" @@ -677,7 +680,7 @@ Feature: sharing | 2 | 200 | @issue-719 - Scenario Outline: Creating a share of a renamed file when another share exists + Scenario Outline: creating a share of a renamed file when another share exists Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has created folder "/Folder1" @@ -710,7 +713,7 @@ Feature: sharing | 2 | 200 | @issue-1710 - Scenario Outline: Sharing a same file twice to the same group is not possible + Scenario Outline: sharing a same file twice to the same group is not possible Given using OCS API version "" And group "grp1" has been created And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" @@ -725,7 +728,7 @@ Feature: sharing | 2 | 403 | @issue-2215 - Scenario Outline: Sharing the shares folder to users is not possible + Scenario Outline: sharing the shares folder to users is not possible Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Carol" has been created with default attributes and without skeleton files @@ -742,7 +745,7 @@ Feature: sharing | 2 | 403 | @issue-2215 - Scenario Outline: Sharing the shares folder to groups is not possible + Scenario Outline: sharing the shares folder to groups is not possible Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Carol" has been created with default attributes and without skeleton files @@ -761,7 +764,7 @@ Feature: sharing | 2 | 403 | @issue-2215 - Scenario Outline: Sharing the shares folder as public link is not possible + Scenario Outline: sharing the shares folder as public link is not possible Given using OCS API version "" And user "Brian" has been created with default attributes and without skeleton files And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" diff --git a/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature b/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature index bd9e428050c..134ef48a6b2 100644 --- a/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature +++ b/tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required @issue-1328 @issue-1289 Feature: sharing + As a user + I want to delete shares + So that I don't have redundant shares Background: Given auto-accept shares has been disabled @@ -10,7 +13,7 @@ Feature: sharing And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" - Scenario Outline: Delete all group shares + Scenario Outline: delete all group shares Given using OCS API version "" And group "grp1" has been created And user "Brian" has been added to group "grp1" @@ -152,7 +155,7 @@ Feature: sharing And as "Brian" file "/Shares/shared/textfile.txt" should not exist - Scenario Outline: A Group share recipient tries to delete the share + Scenario Outline: group share recipient tries to delete the share Given using OCS API version "" And group "grp1" has been created And these users have been created with default attributes and without skeleton files: @@ -179,7 +182,7 @@ Feature: sharing | /shared | 2 | 404 | /Shares/shared | /Shares/shared | - Scenario Outline: An individual share recipient tries to delete the share + Scenario Outline: individual share recipient tries to delete the share Given using OCS API version "" And user "Alice" has created folder "/shared" And user "Alice" has moved file "/textfile0.txt" to "/shared/shared_file.txt" diff --git a/tests/acceptance/features/coreApiSharees/sharees.feature b/tests/acceptance/features/coreApiSharees/sharees.feature index 46b7a696a0f..2cffeffcd96 100644 --- a/tests/acceptance/features/coreApiSharees/sharees.feature +++ b/tests/acceptance/features/coreApiSharees/sharees.feature @@ -1,5 +1,8 @@ @api @files_sharing-app-required -Feature: sharees +Feature: search sharees + As a user + I want to search sharees + So that I can find them quickly Background: Given these users have been created with default attributes and without skeleton files: @@ -11,7 +14,7 @@ Feature: sharees And user "Alice" has been added to group "ShareeGroup2" @smokeTest - Scenario Outline: Search without exact match + Scenario Outline: search without exact match Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | sharee | @@ -33,7 +36,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Search without exact match not-exact casing + Scenario Outline: search without exact match not-exact casing Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | sHaRee | @@ -55,7 +58,7 @@ Feature: sharees | 2 | 200 | 200 | @skipOnLDAP - Scenario Outline: Search only with group members - allowed + Scenario Outline: search only with group members - allowed Given using OCS API version "" And parameter "shareapi_only_share_with_group_members" of app "core" has been set to "yes" And user "Sharee1" has been added to group "ShareeGroup2" @@ -79,7 +82,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Search with exact match + Scenario Outline: search with exact match Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | Sharee1 | @@ -99,7 +102,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Search with exact match not-exact casing + Scenario Outline: search with exact match not-exact casing Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | sharee1 | @@ -119,7 +122,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Search with exact match not-exact casing group + Scenario Outline: search with exact match not-exact casing group Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | shareegroup2 | @@ -139,7 +142,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Search with "self" + Scenario Outline: search with "self" Given using OCS API version "" When user "Sharee1" gets the sharees using the sharing API with parameters | search | Sharee1 | @@ -159,7 +162,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Federated sharee for files + Scenario Outline: federated sharee for files Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | test@localhost | @@ -179,7 +182,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Federated sharee for calendars not allowed + Scenario Outline: federated sharee for calendars not allowed Given using OCS API version "" When user "Alice" gets the sharees using the sharing API with parameters | search | test@localhost | @@ -198,7 +201,7 @@ Feature: sharees | 2 | 200 | 200 | @skipOnLDAP - Scenario Outline: Enumerate only group members - only show partial results from member of groups + Scenario Outline: enumerate only group members - only show partial results from member of groups Given using OCS API version "" And these users have been created with default attributes and without skeleton files: | username | displayname | @@ -223,7 +226,7 @@ Feature: sharees | 2 | 200 | 200 | - Scenario Outline: Search without exact match such that the search string matches the user getting the sharees + Scenario Outline: search without exact match such that the search string matches the user getting the sharees Given user "sharee2" has been created with default attributes and without skeleton files And using OCS API version "" When user "sharee1" gets the sharees using the sharing API with parameters