diff --git a/tests/TestHelpers/SharingHelper.php b/tests/TestHelpers/SharingHelper.php index 62ec4d8f9fa..dbf738e4d1b 100644 --- a/tests/TestHelpers/SharingHelper.php +++ b/tests/TestHelpers/SharingHelper.php @@ -39,7 +39,6 @@ class SharingHelper { 'update' => 2, 'create' => 4, 'delete' => 8, - // 'share' => 16, 'invite' => 0 ]; diff --git a/tests/acceptance/expected-failures-API-on-OCIS-storage.md b/tests/acceptance/expected-failures-API-on-OCIS-storage.md index b3a940a092a..60689d45dc0 100644 --- a/tests/acceptance/expected-failures-API-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-API-on-OCIS-storage.md @@ -71,14 +71,6 @@ File and sync features in a shared scenario - [coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature:159](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature#L159) - [coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature:160](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareCreateSpecialToShares2/createShareReceivedInMultipleWays.feature#L160) -#### [sharing the shares folder to users exits with different status code than in oc10 backend](https://github.com/owncloud/ocis/issues/2215) - -- [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:654](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L654) -- [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:655](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L655) -- [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:672](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L672) -- [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:673](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L673) -- [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:687](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L687) -- [coreApiShareManagementBasicToShares/createShareToSharesFolder.feature:688](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature#L688) #### [file_target of an auto-renamed file is not correct directly after sharing](https://github.com/owncloud/core/issues/32322) diff --git a/tests/acceptance/features/apiNotification/emailNotification.feature b/tests/acceptance/features/apiNotification/emailNotification.feature index 9c1f231391f..b8c1bf5a73d 100644 --- a/tests/acceptance/features/apiNotification/emailNotification.feature +++ b/tests/acceptance/features/apiNotification/emailNotification.feature @@ -30,7 +30,7 @@ Feature: Email notification Scenario: user gets an email notification when someone shares a file Given user "Alice" has uploaded file with content "sample text" to "lorem.txt" - When user "Alice" shares file "lorem.txt" with user "Brian" with permissions "17" using the sharing API + When user "Alice" shares file "lorem.txt" with user "Brian" using the sharing API Then the HTTP status code should be "200" And the OCS status code should be "100" And user "Brian" should have received the following email from user "Alice" diff --git a/tests/acceptance/features/apiReshare/resharing.feature b/tests/acceptance/features/apiReshare/resharing.feature index 225984e9ad5..23ae0c42a2e 100644 --- a/tests/acceptance/features/apiReshare/resharing.feature +++ b/tests/acceptance/features/apiReshare/resharing.feature @@ -77,3 +77,19 @@ Feature: re-share resources | new | viewer | | spaces | editor | | spaces | viewer | + + + Scenario Outline: try to create a link to the shared folder + Given using OCS API version "" + And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" + When user "Brian" creates a public link share using the sharing API with settings + | path | /Shares/test | + | permissions | 1 | + | password | %public% | + Then the OCS status code should be "" + And the HTTP status code should be "" + Examples: + | ocs_api_version | ocs_status_code | http_status_code | + | 1 | 403 | 200 | + | 2 | 403 | 403 | + \ No newline at end of file diff --git a/tests/acceptance/features/apiSpaces/listSpaces.feature b/tests/acceptance/features/apiSpaces/listSpaces.feature index 4676e3dd7fd..59a82a6df84 100644 --- a/tests/acceptance/features/apiSpaces/listSpaces.feature +++ b/tests/acceptance/features/apiSpaces/listSpaces.feature @@ -80,7 +80,7 @@ Feature: List and create spaces Scenario: ordinary user can request information about their Space via the Graph API using a filter Given user "Brian" has been created with default attributes and without skeleton files And user "Brian" has created folder "folder" - And user "Brian" has shared folder "folder" with user "Alice" with permissions "31" + And user "Brian" has shared folder "folder" with user "Alice" with permissions "15" When user "Alice" lists all available spaces via the Graph API with query "$filter=driveType eq 'personal'" Then the HTTP status code should be "200" And the JSON response should contain space called "Alice Hansen" and match diff --git a/tests/acceptance/features/apiSpacesShares/copySpaces.feature b/tests/acceptance/features/apiSpacesShares/copySpaces.feature index a1b1922881a..1f5ffe0c73d 100644 --- a/tests/acceptance/features/apiSpacesShares/copySpaces.feature +++ b/tests/acceptance/features/apiSpacesShares/copySpaces.feature @@ -116,7 +116,7 @@ Feature: copy file And user "Brian" has shared a space "Project" with settings: | shareWith | Alice | | role | | - And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "31" + And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "15" When user "Alice" copies file "/project.txt" from space "Project" to "/testshare/project.txt" inside space "Shares" using the WebDAV API Then the HTTP status code should be "201" And for user "Alice" folder "testshare" of the space "Shares" should contain these files: @@ -137,7 +137,7 @@ Feature: copy file And user "Brian" has shared a space "Project" with settings: | shareWith | Alice | | role | | - And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "17" + And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "1" When user "Alice" copies file "/project.txt" from space "Project" to "/testshare/project.txt" inside space "Shares" using the WebDAV API Then the HTTP status code should be "403" And for user "Alice" folder "testshare" of the space "Shares" should not contain these files: @@ -182,7 +182,7 @@ Feature: copy file Scenario: user copies a file from personal space to share space with role editor Given user "Brian" has created folder "/testshare" - And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "31" + And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "15" And user "Alice" has uploaded file with content "personal content" to "personal.txt" When user "Alice" copies file "/personal.txt" from space "Personal" to "/testshare/personal.txt" inside space "Shares" using the WebDAV API Then the HTTP status code should be "201" @@ -193,7 +193,7 @@ Feature: copy file Scenario: user copies a file from personal space to share space with role viewer Given user "Brian" has created folder "/testshare" - And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "17" + And user "Brian" has shared folder "/testshare" with user "Alice" with permissions "1" And user "Alice" has uploaded file with content "personal content" to "/personal.txt" When user "Alice" copies file "/personal.txt" from space "Personal" to "/testshare/personal.txt" inside space "Shares" using the WebDAV API Then the HTTP status code should be "403" @@ -213,8 +213,8 @@ Feature: copy file And for user "Alice" the content of the file "/testshare.txt" of the space "Personal" should be "testshare content" Examples: | permissions | - | 31 | - | 17 | + | 15 | + | 1 | Scenario Outline: user copies a file from share space with different role to project space with different role @@ -233,10 +233,10 @@ Feature: copy file And for user "Alice" the content of the file "/testshare.txt" of the space "Project" should be "testshare content" Examples: | role | permissions | - | manager | 31 | - | manager | 17 | - | editor | 31 | - | editor | 17 | + | manager | 15 | + | manager | 1 | + | editor | 15 | + | editor | 1 | Scenario Outline: user copies a file from share space with different role to project space with role viewer @@ -263,7 +263,7 @@ Feature: copy file And user "Brian" has created folder "/testshare2" And user "Brian" has uploaded file with content "testshare1 content" to "/testshare1/testshare1.txt" And user "Brian" has shared folder "/testshare1" with user "Alice" with permissions "" - And user "Brian" has shared folder "/testshare2" with user "Alice" with permissions "31" + And user "Brian" has shared folder "/testshare2" with user "Alice" with permissions "15" When user "Alice" copies file "/testshare1/testshare1.txt" from space "Shares" to "/testshare2/testshare1.txt" inside space "Shares" using the WebDAV API Then the HTTP status code should be "201" And for user "Alice" folder "testshare2" of the space "Shares" should contain these files: @@ -274,8 +274,8 @@ Feature: copy file And for user "Brian" the content of the file "/testshare1/testshare1.txt" of the space "Personal" should be "testshare1 content" Examples: | permissions | - | 31 | - | 17 | + | 15 | + | 1 | Scenario Outline: user copies a file from share space with different role to share space with role viewer @@ -283,7 +283,7 @@ Feature: copy file And user "Brian" has created folder "/testshare2" And user "Brian" has uploaded file with content "testshare1 content" to "/testshare1/testshare1.txt" And user "Brian" has shared folder "/testshare1" with user "Alice" with permissions "" - And user "Brian" has shared folder "/testshare2" with user "Alice" with permissions "17" + And user "Brian" has shared folder "/testshare2" with user "Alice" with permissions "1" When user "Alice" copies file "/testshare1/testshare1.txt" from space "Shares" to "/testshare2/testshare1.txt" inside space "Shares" using the WebDAV API Then the HTTP status code should be "403" And for user "Alice" folder "testshare2" of the space "Shares" should not contain these files: @@ -292,8 +292,8 @@ Feature: copy file | testshare1.txt | Examples: | permissions | - | 31 | - | 17 | + | 15 | + | 1 | Scenario Outline: copying a folder within the same project space with different role @@ -378,12 +378,12 @@ Feature: copy file | | Examples: | role | shouldOrNot | permissions | status-code | parent-folder | entry | - | manager | should | 31 | 201 | testshare/folder1 | demo.txt | - | editor | should | 31 | 201 | testshare/folder1 | demo.txt | - | viewer | should | 31 | 201 | testshare/folder1 | demo.txt | - | manager | should not | 17 | 403 | testshare | folder1 | - | editor | should not | 17 | 403 | testshare | folder1 | - | viewer | should not | 17 | 403 | testshare | folder1 | + | manager | should | 15 | 201 | testshare/folder1 | demo.txt | + | editor | should | 15 | 201 | testshare/folder1 | demo.txt | + | viewer | should | 15 | 201 | testshare/folder1 | demo.txt | + | manager | should not | 1 | 403 | testshare | folder1 | + | editor | should not | 1 | 403 | testshare | folder1 | + | viewer | should not | 1 | 403 | testshare | folder1 | Scenario Outline: user copies a folder from personal space to project space with different role @@ -416,8 +416,8 @@ Feature: copy file | | Examples: | permissions | shouldOrNot | status-code | parent-folder | entry | - | 31 | should | 201 | testshare/folder1 | demo.txt | - | 17 | should not | 403 | testshare | folder1 | + | 15 | should | 201 | testshare/folder1 | demo.txt | + | 1 | should not | 403 | testshare | folder1 | Scenario Outline: user copies a folder from share space with different role to personal space @@ -432,8 +432,8 @@ Feature: copy file And for user "Alice" the content of the file "/testshare.txt" of the space "Personal" should be "testshare content" Examples: | permissions | - | 31 | - | 17 | + | 15 | + | 1 | Scenario Outline: user copies a folder from share space with different role to project space with different role @@ -452,10 +452,10 @@ Feature: copy file | testshare.txt | Examples: | role | permissions | - | manager | 31 | - | manager | 17 | - | editor | 31 | - | editor | 17 | + | manager | 15 | + | manager | 1 | + | editor | 15 | + | editor | 1 | Scenario Outline: user copies a folder from share space with different role to project space with role viewer @@ -474,8 +474,8 @@ Feature: copy file | folder1 | Examples: | permissions | - | 31 | - | 17 | + | 15 | + | 1 | Scenario: copying a file to a folder with no permissions @@ -775,7 +775,7 @@ Feature: copy file When user "Brian" overwrites file "/personal.txt" from space "Personal" to "/newfolder/personal.txt" inside space "Shares" while copying using the WebDAV API Then the HTTP status code should be "204" And for user "Alice" folder "newfolder" of the space "Project" should contain these entries: - | personal.txt | + | personal.txt | And for user "Alice" the content of the file "/newfolder/personal.txt" of the space "Project" should be "new content" When user "Alice" downloads version of the file "/newfolder/personal.txt" with the index "1" of the space "Project" using the WebDAV API Then the HTTP status code should be "200" diff --git a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature index 8ea802c8388..8ae835e1b19 100644 --- a/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature +++ b/tests/acceptance/features/coreApiShareManagementBasicToShares/createShareToSharesFolder.feature @@ -83,11 +83,11 @@ Feature: sharing Examples: | ocs_api_version | requested_permissions | granted_permissions | ocs_status_code | # Ask for full permissions. You get share plus read plus update. create and delete do not apply to shares of a file - | 1 | 31 | 19 | 100 | - | 2 | 31 | 19 | 200 | + | 1 | 15 | 3 | 100 | + | 2 | 15 | 3 | 200 | # Ask for read, share (17), create and delete. You get share plus read - | 1 | 29 | 17 | 100 | - | 2 | 29 | 17 | 200 | + | 1 | 13 | 1 | 100 | + | 2 | 13 | 1 | 200 | # Ask for read, update, create, delete. You get read plus update. | 1 | 15 | 3 | 100 | | 2 | 15 | 3 | 200 | @@ -496,56 +496,6 @@ Feature: sharing And the content of file "/Shares/common/sub/textfile0.txt" for user "Brian" should be "BLABLABLA" plus end-of-line And the content of file "/common/sub/textfile0.txt" for user "Alice" should be "BLABLABLA" plus end-of-line - @issue-enterprise-3896 @issue-2201 - Scenario: sharing back to resharer is allowed - Given these users have been created with default attributes and without skeleton files: - | username | - | Brian | - | Carol | - And user "Alice" has created folder "userZeroFolder" - And user "Alice" has shared folder "userZeroFolder" with user "Brian" - And user "Brian" has created folder "/Shares/userZeroFolder/userOneFolder" - And user "Brian" has shared folder "/Shares/userZeroFolder/userOneFolder" with user "Carol" with permissions "read, share" - When user "Carol" shares folder "/Shares/userOneFolder" with user "Brian" using the sharing API - Then the HTTP status code should be "200" - # Then the HTTP status code should be "405" - And the sharing API should report to user "Brian" that no shares are in the pending state - And as "Brian" folder "/Shares/userOneFolder" should not exist - - @issue-enterprise-3896 @issue-2201 - Scenario: sharing back to original sharer is allowed - Given these users have been created with default attributes and without skeleton files: - | username | - | Brian | - | Carol | - And user "Alice" has created folder "userZeroFolder" - And user "Alice" has shared folder "userZeroFolder" with user "Brian" - And user "Brian" has created folder "/Shares/userZeroFolder/userOneFolder" - And user "Brian" has shared folder "/Shares/userZeroFolder/userOneFolder" with user "Carol" with permissions "read, share" - When user "Carol" shares folder "/Shares/userOneFolder" with user "Alice" using the sharing API - Then the HTTP status code should be "200" - # Then the HTTP status code should be "405" - And the sharing API should report to user "Alice" that no shares are in the pending state - And as "Alice" folder "/Shares/userOneFolder" should not exist - - @issue-enterprise-3896 @issue-2201 - Scenario: sharing a subfolder to a user that already received parent folder share - Given these users have been created with default attributes and without skeleton files: - | username | - | Brian | - | Carol | - | David | - And user "Alice" has created folder "userZeroFolder" - And user "Alice" has shared folder "userZeroFolder" with user "Brian" - And user "Alice" has shared folder "userZeroFolder" with user "Carol" - And user "Brian" has created folder "/Shares/userZeroFolder/userOneFolder" - And user "Brian" has shared folder "/Shares/userZeroFolder/userOneFolder" with user "David" with permissions "read, share" - When user "David" shares folder "/Shares/userOneFolder" with user "Carol" using the sharing API - Then the HTTP status code should be "200" - # Then the HTTP status code should be "405" - And the sharing API should report to user "Carol" that no shares are in the pending state - And as "Carol" folder "/Shares/userOneFolder" should not exist - @smokeTest Scenario Outline: creating a share of a renamed file Given using OCS API version "" @@ -637,52 +587,3 @@ Feature: sharing | ocs-api-version | http-status | | 1 | 200 | | 2 | 403 | - - @issue-2215 - Scenario Outline: sharing the shares folder to users is not possible - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Carol" has been created with default attributes and without skeleton files - And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" - And user "Alice" has shared file "textfile0.txt" with user "Brian" - When user "Brian" shares folder "Shares" with user "Carol" using the sharing API - Then the HTTP status code should be "" - And the OCS status code should be "403" - And the OCS status message should be "Path contains files shared with you" - Examples: - | ocs-api-version | http-status | - | 1 | 200 | - | 2 | 403 | - - @issue-2215 - Scenario Outline: sharing the shares folder to groups is not possible - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Carol" has been created with default attributes and without skeleton files - And group "share_group" has been created - And user "Carol" has been added to group "share_group" - And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" - And user "Alice" has shared file "textfile0.txt" with user "Brian" - When user "Brian" shares folder "Shares" with group "share_group" using the sharing API - Then the HTTP status code should be "" - And the OCS status code should be "403" - And the OCS status message should be "Path contains files shared with you" - Examples: - | ocs-api-version | http-status | - | 1 | 200 | - | 2 | 403 | - - @issue-2215 - Scenario Outline: sharing the shares folder as public link is not possible - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" - And user "Alice" has shared file "textfile0.txt" with user "Brian" - When user "Brian" creates a public link share of folder "Shares" using the sharing API - Then the HTTP status code should be "" - And the OCS status code should be "403" - And the OCS status message should be "Path contains files shared with you" - Examples: - | ocs-api-version | http-status | - | 1 | 200 | - | 2 | 403 | diff --git a/tests/acceptance/features/coreApiShareManagementToShares/moveReceivedShare.feature b/tests/acceptance/features/coreApiShareManagementToShares/moveReceivedShare.feature index 8ee20c53bd2..4c1a3913a97 100644 --- a/tests/acceptance/features/coreApiShareManagementToShares/moveReceivedShare.feature +++ b/tests/acceptance/features/coreApiShareManagementToShares/moveReceivedShare.feature @@ -136,10 +136,10 @@ Feature: sharing And as "Alice" file "Shares/TMP" should not exist - Scenario: receiver renames a received share with share, read, change permissions inside the Shares folder + Scenario: receiver renames a received share with read, change permissions inside the Shares folder Given user "Alice" has created folder "folderToShare" And user "Alice" has uploaded file with content "thisIsAFileInsideTheSharedFolder" to "/folderToShare/fileInside" - And user "Alice" has shared folder "folderToShare" with user "Brian" with permissions "share,read,change" + And user "Alice" has shared folder "folderToShare" with user "Brian" with permissions "read,change" When user "Brian" moves folder "/Shares/folderToShare" to "/Shares/myFolder" using the WebDAV API Then the HTTP status code should be "201" And as "Brian" folder "/Shares/myFolder" should exist @@ -151,10 +151,10 @@ Feature: sharing But as "Alice" file "/folderToShare/fileInside" should not exist - Scenario: receiver tries to rename a received share with share, read permissions inside the Shares folder + Scenario: receiver tries to rename a received share with read permissions inside the Shares folder Given user "Alice" has created folder "folderToShare" And user "Alice" has uploaded file with content "thisIsAFileInsideTheSharedFolder" to "/folderToShare/fileInside" - And user "Alice" has shared folder "folderToShare" with user "Brian" with permissions "share,read" + And user "Alice" has shared folder "folderToShare" with user "Brian" with permissions "read" When user "Brian" moves folder "/Shares/folderToShare" to "/Shares/myFolder" using the WebDAV API Then the HTTP status code should be "201" And as "Brian" folder "/Shares/myFolder" should exist @@ -205,22 +205,22 @@ Feature: sharing But as "Alice" folder "myFolder" should not exist - Scenario: receiver renames a received file share with read,update,share permissions inside the Shares folder in group sharing + Scenario: receiver renames a received file share with read,update permissions inside the Shares folder in group sharing Given group "grp1" has been created And user "Brian" has been added to group "grp1" And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "fileToShare.txt" - And user "Alice" has shared file "fileToShare.txt" with group "grp1" with permissions "read,update,share" + And user "Alice" has shared file "fileToShare.txt" with group "grp1" with permissions "read,update" When user "Brian" moves folder "/Shares/fileToShare.txt" to "/Shares/newFile.txt" using the WebDAV API Then the HTTP status code should be "201" And as "Brian" file "/Shares/newFile.txt" should exist But as "Alice" file "/Shares/newFile.txt" should not exist - Scenario: receiver renames a received folder share with share, read, change permissions inside the Shares folder in group sharing + Scenario: receiver renames a received folder share with read, change permissions inside the Shares folder in group sharing Given group "grp1" has been created And user "Alice" has created folder "PARENT" And user "Brian" has been added to group "grp1" - And user "Alice" has shared folder "PARENT" with group "grp1" with permissions "share,read,change" + And user "Alice" has shared folder "PARENT" with group "grp1" with permissions "read,change" When user "Brian" moves folder "/Shares/PARENT" to "/Shares/myFolder" using the WebDAV API Then the HTTP status code should be "201" And as "Brian" folder "/Shares/myFolder" should exist @@ -231,18 +231,18 @@ Feature: sharing Given group "grp1" has been created And user "Brian" has been added to group "grp1" And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "fileToShare.txt" - And user "Alice" has shared file "fileToShare.txt" with group "grp1" with permissions "share,read" + And user "Alice" has shared file "fileToShare.txt" with group "grp1" with permissions "read" When user "Brian" moves file "/Shares/fileToShare.txt" to "/Shares/newFile.txt" using the WebDAV API Then the HTTP status code should be "201" And as "Brian" file "/Shares/newFile.txt" should exist But as "Alice" file "/Shares/newFile.txt" should not exist - Scenario: receiver renames a received folder share with share, read permissions inside the Shares folder in group sharing + Scenario: receiver renames a received folder share with read permissions inside the Shares folder in group sharing Given group "grp1" has been created And user "Alice" has created folder "PARENT" And user "Brian" has been added to group "grp1" - And user "Alice" has shared folder "PARENT" with group "grp1" with permissions "share,read" + And user "Alice" has shared folder "PARENT" with group "grp1" with permissions "read" When user "Brian" moves folder "/Shares/PARENT" to "/Shares/myFolder" using the WebDAV API Then the HTTP status code should be "201" And as "Brian" folder "/Shares/myFolder" should exist @@ -270,19 +270,19 @@ Feature: sharing | @a#8a=b?c=d | @a#8a=b?c=d grp | ?a#8 a=b?c=d | @issue-2141 - Scenario Outline: receiver renames a received file share to name with special characters with share, read, change permissions in group sharing + Scenario Outline: receiver renames a received file share to name with special characters with read, change permissions in group sharing Given group "grp1" has been created And user "Carol" has been added to group "grp1" And user "Alice" has created folder "" And user "Alice" has created folder "" And user "Alice" has uploaded file with content "thisIsAFileInsideTheSharedFolder" to "//fileInside" And user "Alice" has uploaded file with content "thisIsAFileInsideTheSharedFolder" to "//fileInside" - And user "Alice" has shared folder "" with user "Brian" with permissions "share,read,change" + And user "Alice" has shared folder "" with user "Brian" with permissions "read,change" When user "Brian" moves folder "/Shares//fileInside" to "/Shares//" using the WebDAV API Then the HTTP status code should be "201" And as "Alice" file "/" should exist And as "Brian" file "/Shares//" should exist - When user "Alice" shares folder "" with group "grp1" with permissions "share,read,change" using the sharing API + When user "Alice" shares folder "" with group "grp1" with permissions "read,change" using the sharing API And user "Carol" moves folder "/Shares//fileInside" to "/Shares//" using the WebDAV API Then the HTTP status code should be "201" And as "Alice" file "/" should exist diff --git a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature b/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature deleted file mode 100644 index 72347dba001..00000000000 --- a/tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature +++ /dev/null @@ -1,59 +0,0 @@ -Feature: reshare as public link - As a user - I want to create public link shares from files/folders shared with me - So that I can give controlled access to others - - Background: - Given these users have been created with default attributes and without skeleton files: - | username | - | Alice | - | Brian | - - @skipOnReva - Scenario Outline: creating a public link from a share with read permission only is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "read" - When user "Brian" creates a public link share using the sharing API with settings - | path | /Shares/test | - | publicUpload | false | - | password | %public% | - Then the OCS status code should be "403" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 403 | - - @skipOnReva - Scenario Outline: creating a public link from a share with read+write permissions only is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "change" - When user "Brian" creates a public link share using the sharing API with settings - | path | /Shares/test | - | publicUpload | true | - | password | %public% | - Then the OCS status code should be "403" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 403 | - - @skipOnReva - Scenario Outline: creating a public link from a share with all permissions is not allowed - Given using OCS API version "" - And user "Alice" has created folder "/test" - And user "Alice" has uploaded file with content "some content" to "/test/file.txt" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - When user "Brian" creates a public link share using the sharing API with settings - | path | /Shares/test | - | publicUpload | false | - | password | %public% | - Then the OCS status code should be "403" - And the HTTP status code should be "" - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 403 | diff --git a/tests/acceptance/features/coreApiSharePublicLink2/updatePublicLinkShare.feature b/tests/acceptance/features/coreApiSharePublicLink2/updatePublicLinkShare.feature index 07970716cbf..6db28e60c6d 100644 --- a/tests/acceptance/features/coreApiSharePublicLink2/updatePublicLinkShare.feature +++ b/tests/acceptance/features/coreApiSharePublicLink2/updatePublicLinkShare.feature @@ -232,89 +232,6 @@ Feature: update a public link share | 1 | 100 | | 2 | 200 | - @skipOnReva - Scenario Outline: adding public upload to a read only shared folder as recipient is not allowed using the public API - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has created a public link share with settings - | path | /Shares/test | - | publicUpload | false | - | password | %public% | - When user "Brian" updates the last public link share using the sharing API with - | publicUpload | true | - Then the OCS status code should be "403" - And the HTTP status code should be "" - And uploading a file should not work using the old public WebDAV API - And uploading a file should not work using the new public WebDAV API - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 403 | - - @skipOnReva - Scenario Outline:adding public upload to a shared folder as recipient is allowed with permissions using the public API - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - And user "Brian" has created a public link share with settings - | path | /Shares/test | - | publicUpload | false | - | password | %public% | - When user "Brian" updates the last public link share using the sharing API with - | publicUpload | true | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And uploading a file with password "%public%" should work using the old public WebDAV API - And uploading a file with password "%public%" should work using the new public WebDAV API - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - - @skipOnReva - Scenario Outline: adding public link with all permissions to a read only shared folder as recipient is not allowed using the public API - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "share,read" - And user "Brian" has created a public link share with settings - | path | /Shares/test | - | permissions | read | - | password | %public% | - When user "Brian" updates the last public link share using the sharing API with - | permissions | read,update,create,delete | - Then the OCS status code should be "403" - And the HTTP status code should be "" - And uploading a file should not work using the old public WebDAV API - And uploading a file should not work using the new public WebDAV API - Examples: - | ocs_api_version | http_status_code | - | 1 | 200 | - | 2 | 403 | - - @skipOnReva - Scenario Outline: adding public link with all permissions to a read only shared folder as recipient is allowed with permissions using the public API - Given using OCS API version "" - And user "Brian" has been created with default attributes and without skeleton files - And user "Alice" has created folder "/test" - And user "Alice" has shared folder "/test" with user "Brian" with permissions "all" - And user "Brian" has created a public link share with settings - | path | /Shares/test | - | permissions | read | - | password | %public% | - When user "Brian" updates the last public link share using the sharing API with - | permissions | read,update,create,delete | - Then the OCS status code should be "" - And the HTTP status code should be "200" - And uploading a file with password "%public%" should work using the new public WebDAV API - Examples: - | ocs_api_version | ocs_status_code | - | 1 | 100 | - | 2 | 200 | - @issue-1269 Scenario Outline: updating share permissions from change to read restricts public from deleting files using the public API Given using OCS API version ""