From 7206b567283a2495b77b475480f813b16a3b6a41 Mon Sep 17 00:00:00 2001 From: Swikriti Tripathi Date: Mon, 24 Jul 2023 15:33:39 +0545 Subject: [PATCH] remove space id --- ...ected-failures-localAPI-on-OCIS-storage.md | 8 ++-- .../shareSubItemOfSpaceViaPublicLink.feature | 37 ++++++++----------- 2 files changed, 20 insertions(+), 25 deletions(-) diff --git a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md index 259c6b21f53..8c6940a79e7 100644 --- a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md @@ -76,10 +76,10 @@ The expected failures in this file are from features in the owncloud/ocis repo. - [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:63](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L63) - [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:64](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L64) - [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:65](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L65) -- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:97](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L97) -- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:172](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L172) -- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:173](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L173) -- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:174](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L174) +- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:93](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L93) +- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:167](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L167) +- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:168](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L168) +- [apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature:169](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature#L169) #### [A User can get information of another user with Graph API](https://github.com/owncloud/ocis/issues/5125) diff --git a/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature b/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature index 82b8ca511b3..74024218f2f 100644 --- a/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature +++ b/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature @@ -1,22 +1,22 @@ @api Feature: Share a file or folder that is inside a space via public link - As a user with manager space role - I want to be able to share the data inside the space via public link - So that an anonymous user can have access to certain resources + As a user with manager space role + I want to be able to share the data inside the space via public link + So that an anonymous user can have access to certain resources - folder permissions: - | role | permissions | - | internal | 0 | - | viewer | 1 | - | uploader | 4 | - | contributor | 5 | - | editor | 15 | + folder permissions: + | role | permissions | + | internal | 0 | + | viewer | 1 | + | uploader | 4 | + | contributor | 5 | + | editor | 15 | - file permissions: - | role | permissions | - | internal | 0 | - | viewer | 1 | - | editor | 3 | + file permissions: + | role | permissions | + | internal | 0 | + | viewer | 1 | + | editor | 3 | Note - this feature is run in CI with ACCOUNTS_HASH_DIFFICULTY set to the default for production See https://github.com/owncloud/ocis/issues/1542 and https://github.com/owncloud/ocis/pull/839 @@ -53,8 +53,6 @@ Feature: Share a file or folder that is inside a space via public link | share_type | public_link | | displayname_owner | %displayname% | | name | | - | uid_file_owner | %space_id% | - | space_id | %space_id% | Examples: | entity | file_target | permissions | password | name | expireDate | item_type | mimetype | | folder | /folder | 0 | | link | | folder | httpd/unix-directory | @@ -89,8 +87,6 @@ Feature: Share a file or folder that is inside a space via public link | share_type | public_link | | displayname_owner | %displayname% | | name | public link | - | uid_file_owner | %space_id% | - | space_id | %space_id% | Examples: | entity | file_target | item_type | mimetype | | folder | /folder | folder | httpd/unix-directory | @@ -164,8 +160,7 @@ Feature: Share a file or folder that is inside a space via public link | displayname_file_owner | | | displayname_owner | %displayname% | | uid_owner | %username% | - | uid_file_owner | %space_id% | - | space_id | %space_id% | + | uid_file_owner | %username% | And for user "Brian" the space "share sub-item" should contain the last created public link of the file "folder/file.txt" Examples: | spaceRole |