Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissions grantedTo should be a single identitySet #68

Closed
butonic opened this issue Dec 7, 2022 · 2 comments
Closed

permissions grantedTo should be a single identitySet #68

butonic opened this issue Dec 7, 2022 · 2 comments
Labels

Comments

@butonic
Copy link
Member

butonic commented Dec 7, 2022

we should have used grantedToIdentities, which is a collection
https://learn.microsoft.com/en-us/graph/api/resources/permission?view=graph-rest-1.0

Since this is a breaking change we should

  1. add the grantedToIdentitiesV2 collection
  2. make all clients use that instead of grantedTo
  3. correct grantedTo

grantedToIdentities and grantedTo have been marked as deprecated in msgraph ... in favor of grantedToV2 and grantedToIdentitiesV2, which use a SharePointIdentitySet instead of an IdentitySet. The biggest difference is that the sharePointIdentitySet also carries a group property to allow associating groups with actions.

@butonic butonic transferred this issue from owncloud/libre-graph-api-go Dec 19, 2022
@micbar
Copy link
Contributor

micbar commented Dec 30, 2022

Quick Fix:

  • Rename grantedTo into grantedToIdentities.

@fschade will take care

@micbar
Copy link
Contributor

micbar commented Dec 30, 2022

Fixed by #74

@micbar micbar closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants